Prohibit trailing slashes in repository names (issue 104)

James Moger

2012-07-10 3fb41fdec5712b792da05e8549c2c0a31f112ca0

 src/com/gitblit/MailExecutor.java

@@ -15,6 +15,7 @@
 */

package com.gitblit;



import java.util.ArrayList;

import java.util.Arrays;

import java.util.Collections;

import java.util.Date;

@@ -24,6 +25,7 @@
import java.util.Queue;

import java.util.Set;

import java.util.concurrent.ConcurrentLinkedQueue;

import java.util.regex.Pattern;



import javax.mail.Authenticator;

import javax.mail.Message;

@@ -152,11 +154,28 @@
         InternetAddress from = new InternetAddress(fromAddress, "Gitblit");

         message.setFrom(from);



         InternetAddress[] tos = new InternetAddress[toAddresses.size()];

         for (int i = 0; i < toAddresses.size(); i++) {

            tos[i] = new InternetAddress(toAddresses.get(i));

         // determine unique set of addresses

         Set<String> uniques = new HashSet<String>();

         for (String address : toAddresses) {

            uniques.add(address.toLowerCase());

         }

         message.setRecipients(Message.RecipientType.TO, tos);

			
         Pattern validEmail = Pattern

               .compile("^([a-zA-Z0-9_\\-\\.]+)@((\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.)|(([a-zA-Z0-9\\-]+\\.)+))([a-zA-Z]{2,4}|[0-9]{1,3})(\\]?)$");

         List<InternetAddress> tos = new ArrayList<InternetAddress>();

         for (String address : uniques) {

            if (StringUtils.isEmpty(address)) {

               continue;

            }

            if (validEmail.matcher(address).find()) {

               try {

                  tos.add(new InternetAddress(address));

               } catch (Throwable t) {

               }

            }

         }			
         message.setRecipients(Message.RecipientType.BCC,

               tos.toArray(new InternetAddress[tos.size()]));

         message.setSentDate(new Date());

      } catch (Exception e) {

         logger.error("Failed to properly create message", e);