James Moger
2012-09-10 fabe060d3a435f116128851f828e35c2af5fde67
src/com/gitblit/wicket/pages/EditUserPage.java
@@ -17,13 +17,15 @@
import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import org.apache.wicket.PageParameters;
import org.apache.wicket.behavior.SimpleAttributeModifier;
import org.apache.wicket.extensions.markup.html.form.palette.Palette;
import org.apache.wicket.markup.html.form.Button;
import org.apache.wicket.markup.html.form.CheckBox;
import org.apache.wicket.markup.html.form.ChoiceRenderer;
import org.apache.wicket.markup.html.form.Form;
import org.apache.wicket.markup.html.form.PasswordTextField;
import org.apache.wicket.markup.html.form.TextField;
@@ -31,28 +33,31 @@
import org.apache.wicket.model.Model;
import org.apache.wicket.model.util.CollectionModel;
import org.apache.wicket.model.util.ListModel;
import org.eclipse.jetty.http.security.Credential.Crypt;
import org.eclipse.jetty.http.security.Credential.MD5;
import com.gitblit.Constants.AccessRestrictionType;
import com.gitblit.GitBlit;
import com.gitblit.GitBlitException;
import com.gitblit.Keys;
import com.gitblit.models.RepositoryModel;
import com.gitblit.models.TeamModel;
import com.gitblit.models.UserModel;
import com.gitblit.utils.StringUtils;
import com.gitblit.wicket.AdminPage;
import com.gitblit.wicket.BasePage;
import com.gitblit.wicket.RequiresAdminRole;
import com.gitblit.wicket.StringChoiceRenderer;
import com.gitblit.wicket.WicketUtils;
import com.gitblit.wicket.models.RepositoryModel;
import com.gitblit.wicket.models.UserModel;
@AdminPage
public class EditUserPage extends BasePage {
@RequiresAdminRole
public class EditUserPage extends RootSubPage {
   private final boolean isCreate;
   public EditUserPage() {
      // create constructor
      super();
      if (!GitBlit.self().supportsCredentialChanges()) {
         error(MessageFormat.format(getString("gb.userServiceDoesNotPermitAddUser"),
               GitBlit.getString(Keys.realm.userService, "users.conf")), true);
      }
      isCreate = true;
      setupPage(new UserModel(""));
   }
@@ -68,10 +73,11 @@
   protected void setupPage(final UserModel userModel) {
      if (isCreate) {
         super.setupPage("", getString("gb.newUser"));
         super.setupPage(getString("gb.newUser"), "");
      } else {
         super.setupPage("", getString("gb.edit"));
         super.setupPage(getString("gb.edit"), userModel.username);
      }
      final Model<String> confirmPassword = new Model<String>(
            StringUtils.isEmpty(userModel.password) ? "" : userModel.password);
      CompoundPropertyModel<UserModel> model = new CompoundPropertyModel<UserModel>(userModel);
@@ -83,10 +89,19 @@
            repos.add(repo);
         }
      }
      List<String> userTeams = new ArrayList<String>();
      for (TeamModel team : userModel.teams) {
         userTeams.add(team.name);
      }
      Collections.sort(userTeams);
      final String oldName = userModel.username;
      final Palette<String> repositories = new Palette<String>("repositories",
            new ListModel<String>(userModel.repositories), new CollectionModel<String>(repos),
            new ChoiceRenderer<String>("", ""), 10, false);
            new ListModel<String>(new ArrayList<String>(userModel.repositories)),
            new CollectionModel<String>(repos), new StringChoiceRenderer(), 10, false);
      final Palette<String> teams = new Palette<String>("teams", new ListModel<String>(
            new ArrayList<String>(userTeams)), new CollectionModel<String>(GitBlit.self()
            .getAllTeamnames()), new StringChoiceRenderer(), 10, false);
      Form<UserModel> form = new Form<UserModel>("editForm", model) {
         private static final long serialVersionUID = 1L;
@@ -98,54 +113,80 @@
          */
         @Override
         protected void onSubmit() {
            String username = userModel.username;
            if (StringUtils.isEmpty(username)) {
               error("Please enter a username!");
            if (StringUtils.isEmpty(userModel.username)) {
               error(getString("gb.pleaseSetUsername"));
               return;
            }
            // force username to lower-case
            userModel.username = userModel.username.toLowerCase();
            String username = userModel.username;
            if (isCreate) {
               UserModel model = GitBlit.self().getUserModel(username);
               if (model != null) {
                  error(MessageFormat.format("Username ''{0}'' is unavailable.", username));
                  error(MessageFormat.format(getString("gb.usernameUnavailable"), username));
                  return;
               }
            }
            if (!userModel.password.equals(confirmPassword.getObject())) {
               error("Passwords do not match!");
               return;
            }
            String password = userModel.password;
            if (!password.toUpperCase().startsWith(Crypt.__TYPE)
                  && !password.toUpperCase().startsWith(MD5.__TYPE)) {
               // This is a plain text password.
               // Check length.
               int minLength = GitBlit.getInteger(Keys.realm.minPasswordLength, 5);
               if (minLength < 4) {
                  minLength = 4;
               }
               if (password.trim().length() < minLength) {
                  error(MessageFormat.format(
                        "Password is too short. Minimum length is {0} characters.",
                        minLength));
            boolean rename = !StringUtils.isEmpty(oldName)
                  && !oldName.equalsIgnoreCase(username);
            if (GitBlit.self().supportsCredentialChanges()) {
               if (!userModel.password.equals(confirmPassword.getObject())) {
                  error(getString("gb.passwordsDoNotMatch"));
                  return;
               }
               // Optionally store the password MD5 digest.
               String type = GitBlit.getString(Keys.realm.passwordStorage, "md5");
               if (type.equalsIgnoreCase("md5")) {
                  // store MD5 digest of password
                  userModel.password = MD5.digest(userModel.password);
               String password = userModel.password;
               if (!password.toUpperCase().startsWith(StringUtils.MD5_TYPE)
                     && !password.toUpperCase().startsWith(StringUtils.COMBINED_MD5_TYPE)) {
                  // This is a plain text password.
                  // Check length.
                  int minLength = GitBlit.getInteger(Keys.realm.minPasswordLength, 5);
                  if (minLength < 4) {
                     minLength = 4;
                  }
                  if (password.trim().length() < minLength) {
                     error(MessageFormat.format(getString("gb.passwordTooShort"),
                           minLength));
                     return;
                  }
                  // Optionally store the password MD5 digest.
                  String type = GitBlit.getString(Keys.realm.passwordStorage, "md5");
                  if (type.equalsIgnoreCase("md5")) {
                     // store MD5 digest of password
                     userModel.password = StringUtils.MD5_TYPE
                           + StringUtils.getMD5(userModel.password);
                  } else if (type.equalsIgnoreCase("combined-md5")) {
                     // store MD5 digest of username+password
                     userModel.password = StringUtils.COMBINED_MD5_TYPE
                           + StringUtils.getMD5(username + userModel.password);
                  }
               } else if (rename
                     && password.toUpperCase().startsWith(StringUtils.COMBINED_MD5_TYPE)) {
                  error(getString("gb.combinedMd5Rename"));
                  return;
               }
            }
            Iterator<String> selectedRepositories = repositories.getSelectedChoices();
            List<String> repos = new ArrayList<String>();
            while (selectedRepositories.hasNext()) {
               repos.add(selectedRepositories.next());
               repos.add(selectedRepositories.next().toLowerCase());
            }
            userModel.setRepositories(repos);
            try {
               GitBlit.self().editUserModel(oldName, userModel, isCreate);
            userModel.repositories.clear();
            userModel.repositories.addAll(repos);
            Iterator<String> selectedTeams = teams.getSelectedChoices();
            userModel.teams.clear();
            while (selectedTeams.hasNext()) {
               TeamModel team = GitBlit.self().getTeamModel(selectedTeams.next());
               if (team == null) {
                  continue;
               }
               userModel.teams.add(team);
            }
            try {
               GitBlit.self().updateUserModel(oldName, userModel, isCreate);
            } catch (GitBlitException e) {
               error(e.getMessage());
               return;
@@ -153,27 +194,59 @@
            setRedirect(false);
            if (isCreate) {
               // create another user
               info(MessageFormat.format("New user ''{0}'' successfully created.",
               info(MessageFormat.format(getString("gb.userCreated"),
                     userModel.username));
               setResponsePage(EditUserPage.class);
            } else {
               // back to home
               setResponsePage(RepositoriesPage.class);
               // back to users page
               setResponsePage(UsersPage.class);
            }
         }
      };
      // do not let the browser pre-populate these fields
      form.add(new SimpleAttributeModifier("autocomplete", "off"));
      // not all user services support manipulating username and password
      boolean editCredentials = GitBlit.self().supportsCredentialChanges();
      // not all user services support manipulating display name
      boolean editDisplayName = GitBlit.self().supportsDisplayNameChanges();
      // not all user services support manipulating email address
      boolean editEmailAddress = GitBlit.self().supportsEmailAddressChanges();
      // not all user services support manipulating team memberships
      boolean editTeams = GitBlit.self().supportsTeamMembershipChanges();
      // field names reflective match UserModel fields
      form.add(new TextField<String>("username"));
      form.add(new TextField<String>("username").setEnabled(editCredentials));
      PasswordTextField passwordField = new PasswordTextField("password");
      passwordField.setResetPassword(false);
      form.add(passwordField);
      form.add(passwordField.setEnabled(editCredentials));
      PasswordTextField confirmPasswordField = new PasswordTextField("confirmPassword",
            confirmPassword);
      confirmPasswordField.setResetPassword(false);
      form.add(confirmPasswordField);
      form.add(confirmPasswordField.setEnabled(editCredentials));
      form.add(new TextField<String>("displayName").setEnabled(editDisplayName));
      form.add(new TextField<String>("emailAddress").setEnabled(editEmailAddress));
      form.add(new CheckBox("canAdmin"));
      form.add(new CheckBox("excludeFromFederation"));
      form.add(repositories);
      form.add(teams.setEnabled(editTeams));
      form.add(new Button("save"));
      Button cancel = new Button("cancel") {
         private static final long serialVersionUID = 1L;
         @Override
         public void onSubmit() {
            setResponsePage(UsersPage.class);
         }
      };
      cancel.setDefaultFormProcessing(false);
      form.add(cancel);
      add(form);
   }
}