Clarify update() result description, return boolean when ID didn't change

Aleksander Machniak

2013-12-08 029f7a157da4be15302b3eaf40232c110d27bcf1

 program/js/list.js

@@ -91,8 +91,7 @@
    var r, len, rows = this.tbody.childNodes;

    for (r=0, len=rows.length; r<len; r++) {
      this.init_row(rows[r]);
      this.rowcount++;
      this.rowcount += this.init_row(rows[r]) ? 1 : 0;
    }

    this.init_header();
@@ -148,6 +147,8 @@

    this.row_init(this.rows[uid]);  // legacy support
    this.triggerEvent('initrow', this.rows[uid]);

    return true;
  }
},

@@ -412,15 +413,18 @@
  if (rcube_event.get_button(e) == 2)
    return true;

  this.in_selection_before = e && e.istouch || this.in_selection(id) ? id : false;

  // selects currently unselected row
  if (!(e && e.istouch || this.in_selection(id))) {
  if (!this.in_selection_before) {
    var mod_key = rcube_event.get_modifier(e);
    this.select_row(id, mod_key, false);
    this.select_row(id, mod_key, true);
  }

  if (this.draggable && this.selection.length && this.in_selection(id)) {
    this.drag_start = true;
    this.drag_mouse_start = rcube_event.get_mouse_pos(e);

    rcube_event.add_listener({event:'mousemove', object:this, method:'drag_mouse_move'});
    rcube_event.add_listener({event:'mouseup', object:this, method:'drag_mouse_up'});
    if (bw.touch) {
@@ -448,11 +452,12 @@
  var now = new Date().getTime(),
    dblclicked = now - this.rows[id].clicked < this.dblclick_time;

  // selects (or unselects currently selected) row
  if (!this.drag_active && !dblclicked)
  // unselects currently selected row
  if (!this.drag_active && !dblclicked && this.in_selection_before == id)
    this.select_row(id, rcube_event.get_modifier(e), true);

  this.drag_start = false;
  this.in_selection_before = false;

  // row was double clicked
  if (this.rowcount && dblclicked && this.in_selection(id)) {
@@ -772,6 +777,7 @@
select_row: function(id, mod_key, with_mouse)
{
  var select_before = this.selection.join(',');

  if (!this.multiselect)
    mod_key = 0;

@@ -804,6 +810,7 @@
        this.highlight_row(id, false);
        break;
    }

    this.multi_selecting = true;
  }

@@ -889,7 +896,7 @@

  for (i=0; i<len; i++)
    if (!this.in_selection(children[i]))
      this.select_row(children[i], CONTROL_KEY);
      this.select_row(children[i], CONTROL_KEY, true);
},


@@ -1129,13 +1136,15 @@
      // Stop propagation so that the browser doesn't scroll
      rcube_event.cancel(e);
      return this.use_arrow_key(keyCode, mod_key);

    case 32:
      rcube_event.cancel(e);
      return this.select_row(this.last_selected, mod_key, true);

    case 37: // Left arrow key
    case 39: // Right arrow key
    case 107: // Plus sign on a numeric keypad
    case 109: // Minus sign on a numeric keypad      
    case 109: // Minus sign on a numeric keypad
      // Stop propagation
      rcube_event.cancel(e);
      var ret = this.use_plusminus_key(keyCode, mod_key);
@@ -1144,20 +1153,26 @@
      this.triggerEvent('keypress');
      this.modkey = 0;
      return ret;

    case 36: // Home
      this.select_first(mod_key);
      return rcube_event.cancel(e);

    case 35: // End
      this.select_last(mod_key);
      return rcube_event.cancel(e);

    case 27:
      if (this.drag_active)
        return this.drag_mouse_up(e);

      if (this.col_drag_active) {
        this.selected_column = null;
        return this.column_drag_mouse_up(e);
      }

      return rcube_event.cancel(e);

    default:
      this.key_pressed = keyCode;
      this.modkey = mod_key;
@@ -1550,7 +1565,7 @@
 */
del_dragfix: function()
{
  $('div.iframe-dragdrop-fix').each(function() { this.parentNode.removeChild(this); });
  $('div.iframe-dragdrop-fix').remove();
},