#1485286: don't use /e modifier with preg_replace()

alecpl

2008-08-20 6f488bb55f08d64bbdd5255079a24501e55e6851

 program/include/rcube_template.php

@@ -299,16 +299,13 @@
    private function parse($name = 'main', $exit = true)
    {
        $skin_path = $this->config['skin_path'];

        // read template file
        $templ = '';
        $path = "$skin_path/templates/$name.html";

        if (($fp = fopen($path, 'r')) === false) {
            $message = '';
        // read template file
   if (($templ = file_get_contents($path)) === false) {
            ob_start();
            fopen($path, 'r');
            $message.= ob_get_contents();
            file_get_contents($path);
            $message = ob_get_contents();
            ob_end_clean();
            raise_error(array(
                'code' => 501,
@@ -319,8 +316,6 @@
                ), true, true);
            return false;
        }
        $templ = fread($fp, filesize($path));
        fclose($fp);

        // parse for specialtags
        $output = $this->parse_conditions($templ);
@@ -489,7 +484,32 @@
     */
    private function parse_xml($input)
    {
        return preg_replace('/<roundcube:([-_a-z]+)\s+([^>]+)>/Uie', "\$this->xml_command('\\1', '\\2')", $input);
        return preg_replace_callback('/<roundcube:([-_a-z]+)\s+([^>]+)>/Ui', array($this, 'xml_command_callback'), $input);
    }


    /**
     * This is a callback function for preg_replace_callback (see #1485286)
     * It's only purpose is to reconfigure parameters for xml_command, so that the signature isn't disturbed
     */
    private function xml_command_callback($matches)
    {
   if (isset($matches[2])) {
       $str_attrib = $matches[2];
   } else {
       $str_attrib = '';
   }

   if (isset($matches[3])) {
       $add_attrib = $matches[3];
   } else {
       $add_attrib = array();
   }

   $command = $matches[1];
   //matches[0] is the entire matched portion of the string

   return $this->xml_command($command, $str_attrib, $add_attrib);
    }


@@ -529,14 +549,13 @@
            // include a file
            case 'include':
                $path = realpath($this->config['skin_path'].$attrib['file']);
                if ($fsize = filesize($path)) {
                if (is_readable($path)) {
                    if ($this->config['skin_include_php']) {
                        $incl = $this->include_php($path);
                    }
                    else if ($fp = fopen($path, 'r')) {
                        $incl = fread($fp, $fsize);
                        fclose($fp);
                    }
                    else {
              $incl = file_get_contents($path);
          }
                    return $this->parse_xml($incl);
                }
                break;