Make noshow attribute for roundcube:label tags actually work as supposed

Thomas Bruederli

2014-09-17 a5ce2d8ae28a9b086e7f445b27d24343f9a8a348

 program/include/rcmail.php

@@ -145,8 +145,13 @@
        $this->task      = $task;
        $this->comm_path = $this->url(array('task' => $this->task));

        if (!empty($_REQUEST['_framed'])) {
            $this->comm_path .= '&_framed=1';
        }

        if ($this->output) {
            $this->output->set_env('task', $this->task);
            $this->output->set_env('comm_path', $this->comm_path);
        }
    }

@@ -430,6 +435,9 @@
            $this->output->set_env('user_id', $this->user->get_hash());
        }

        // set compose mode for all tasks (message compose step can be triggered from everywhere)
        $this->output->set_env('compose_extwin', $this->config->get('compose_extwin',false));

        // add some basic labels to client
        $this->output->add_label('loading', 'servererror', 'connerror', 'requesttimedout', 'refreshing');

@@ -497,30 +505,18 @@
        $username_domain = $this->config->get('username_domain');
        $login_lc        = $this->config->get('login_lc', 2);

        if (!$host) {
            $host = $default_host;
        }

        // Validate that selected host is in the list of configured hosts
        if (is_array($default_host)) {
            $allowed = false;

            foreach ($default_host as $key => $host_allowed) {
                if (!is_numeric($key)) {
                    $host_allowed = $key;
                }
                if ($host == $host_allowed) {
                    $allowed = true;
                    break;
                }
        // host is validated in rcmail::autoselect_host(), so here
        // we'll only handle unset host (if possible)
        if (!$host && !empty($default_host)) {
            if (is_array($default_host)) {
                list($key, $val) = each($default_host);
                $host = is_numeric($key) ? $val : $key;
            }
            else {
                $host = $default_host;
            }

            if (!$allowed) {
                $host = null;
            }
        }
        else if (!empty($default_host) && $host != rcube_utils::parse_host($default_host)) {
            $host = null;
            $host = rcube_utils::parse_host($host);
        }

        if (!$host) {