Fixed XSS vulnerability (Bug #1484109)

thomascube

2006-11-22 e34ae17809c3dff8ed870405ffed4e0077cb8512

 index.php

@@ -2,7 +2,7 @@
/*
 +-----------------------------------------------------------------------+
 | RoundCube Webmail IMAP Client                                         |
 | Version 0.1-20060904                                                  |
 | Version 0.1-20061122                                                  |
 |                                                                       |
 | Copyright (C) 2005-2006, RoundCube Dev. - Switzerland                 |
 | Licensed under the GNU GPL                                            |
@@ -40,7 +40,7 @@

*/

define('RCMAIL_VERSION', '0.1-20060904');
define('RCMAIL_VERSION', '0.1-20061122');

// define global vars
$CHARSET = 'UTF-8';
@@ -81,6 +81,7 @@
require_once('include/bugs.inc');
require_once('include/main.inc');
require_once('include/cache.inc');
require_once('lib/html2text.inc');
require_once('PEAR.php');


@@ -89,11 +90,12 @@


// catch some url/post parameters
$_task = get_input_value('_task', RCUBE_INPUT_GPC);
$_action = get_input_value('_action', RCUBE_INPUT_GPC);
$_task = strip_quotes(get_input_value('_task', RCUBE_INPUT_GPC));
$_action = strip_quotes(get_input_value('_action', RCUBE_INPUT_GPC));
$_framed = (!empty($_GET['_framed']) || !empty($_POST['_framed']));

if (empty($_task))
// use main task if empty or invalid value
if (empty($_task) || !in_array($_task, $MAIN_TASKS))
  $_task = 'mail';

if (!empty($_GET['_remote']))
@@ -145,6 +147,21 @@
  raise_error(array('code' => hexdec($_GET['_code'])), FALSE, TRUE);
  }

// handle HTML->text conversion
if ($_action=='html2text')
  {
  $htmlText = $HTTP_RAW_POST_DATA;
  $converter = new html2text($htmlText);

  // TODO possibly replace with rcube_remote_response()
  send_nocacheing_headers();
  header('Content-Type: text/plain');
  $plaintext = $converter->get_text();
  print $plaintext;

  exit;
  }


// try to log in
if ($_action=='login' && $_task=='mail')
@@ -181,7 +198,7 @@
else if ($_action!='login' && $_SESSION['user_id'])
  {
  if (!rcmail_authenticate_session() ||
      ($CONFIG['session_lifetime'] && isset($SESS_CHANGED) && $SESS_CHANGED + $CONFIG['session_lifetime']*60 < mktime()))
      (!empty($CONFIG['session_lifetime']) && isset($SESS_CHANGED) && $SESS_CHANGED + $CONFIG['session_lifetime']*60 < mktime()))
    {
    $message = show_message('sessionerror', 'error');
    rcmail_kill_session();
@@ -240,7 +257,6 @@
  rcube_remote_response('');
  exit;
  }


// include task specific files
if ($_task=='mail')
@@ -357,9 +373,7 @@


// parse main template
// only allow these templates to be included
if (in_array($_task, $MAIN_TASKS))
  parse_template($_task);
parse_template($_task);


// if we arrive here, something went wrong