- don't set password via remoting if field is empty

Marius Cramer

2015-08-06 37b29231e47a0c4458dc1c15d98588f16f07e1e2

 interface/web/sites/ftp_user_edit.php

@@ -38,9 +38,8 @@
* End Form configuration
******************************************/

require_once('../../lib/config.inc.php');
require_once('../../lib/app.inc.php');
require_once('tools.inc.php');
require_once '../../lib/config.inc.php';
require_once '../../lib/app.inc.php';

//* Check permissions for module
$app->auth->check_module_permissions('sites');
@@ -50,26 +49,20 @@
$app->load('tform_actions');

class page_action extends tform_actions {
	

   function onShowNew() {
      global $app, $conf;
		

      // we will check only users, not admins
      if($_SESSION["s"]["user"]["typ"] == 'user') {
			
         // Get the limits of the client
         $client_group_id = $_SESSION["s"]["user"]["default_group"];
         $client = $app->db->queryOneRecord("SELECT limit_ftp_user FROM sys_group, client WHERE sys_group.client_id = client.client_id and sys_group.groupid = $client_group_id");
			
         // Check if the user may add another ftp user.
         if($client["limit_ftp_user"] >= 0) {
            $tmp = $app->db->queryOneRecord("SELECT count(ftp_user_id) as number FROM ftp_user WHERE sys_groupid = $client_group_id");
            if($tmp["number"] >= $client["limit_ftp_user"]) {
               $app->error($app->tform->wordbook["limit_ftp_user_txt"]);
            }
         if(!$app->tform->checkClientLimit('limit_ftp_user')) {
            $app->error($app->tform->wordbook["limit_ftp_user_txt"]);
         }
         if(!$app->tform->checkResellerLimit('limit_ftp_user')) {
            $app->error('Reseller: '.$app->tform->wordbook["limit_ftp_user_txt"]);
         }
      }
		

      parent::onShowNew();
   }

@@ -79,113 +72,150 @@
       * If the names are restricted -> remove the restriction, so that the
       * data can be edited
       */
		
      $app->uses('getconf');

      $app->uses('getconf,tools_sites');
      $global_config = $app->getconf->get_global_config('sites');
      $ftpuser_prefix = ($global_config['ftpuser_prefix'] == '')?'':str_replace('[CLIENTNAME]', $this->getClientName(), $global_config['ftpuser_prefix']);
		
      $ftpuser_prefix = $app->tools_sites->replacePrefix($global_config['ftpuser_prefix'], $this->dataRecord);

      if ($this->dataRecord['username'] != ""){
         /* REMOVE the restriction */
         $app->tpl->setVar("username", str_replace($ftpuser_prefix , '', $this->dataRecord['username']));
         $app->tpl->setVar("username", $app->tools_sites->removePrefix($this->dataRecord['username'], $this->dataRecord['username_prefix'], $ftpuser_prefix));
      }
      if($_SESSION["s"]["user"]["typ"] == 'admin' || $app->auth->has_clients($_SESSION['s']['user']['userid'])) {
         $app->tpl->setVar("username_prefix", $global_config['ftpuser_prefix']);
      }
      else {

      if($this->dataRecord['username'] == "") {
         $app->tpl->setVar("username_prefix", $ftpuser_prefix);
      } else {
         $app->tpl->setVar("username_prefix", $app->tools_sites->getPrefix($this->dataRecord['username_prefix'], $ftpuser_prefix, $global_config['ftpuser_prefix']));
      }

      parent::onShowEnd();
   }
	

   function onSubmit() {
      global $app, $conf;
		

      // Get the record of the parent domain
      $parent_domain = $app->db->queryOneRecord("select * FROM web_domain WHERE domain_id = ".intval(@$this->dataRecord["parent_domain_id"]));
		
      if(isset($this->dataRecord["parent_domain_id"])) {
         $parent_domain = $app->db->queryOneRecord("select * FROM web_domain WHERE domain_id = ? AND ".$app->tform->getAuthSQL('r'), @$this->dataRecord["parent_domain_id"]);
         if(!$parent_domain || $parent_domain['domain_id'] != @$this->dataRecord['parent_domain_id']) $app->tform->errorMessage .= $app->tform->lng("no_domain_perm");
      } else {
         $tmp = $app->tform->getDataRecord($this->id);
         $parent_domain = $app->db->queryOneRecord("select * FROM web_domain WHERE domain_id = ? AND ".$app->tform->getAuthSQL('r'), $tmp["parent_domain_id"]);
         if(!$parent_domain) $app->tform->errorMessage .= $app->tform->lng("no_domain_perm");
         unset($tmp);
      }

      // Set a few fixed values
      $this->dataRecord["server_id"] = $parent_domain["server_id"];
		

      //die(print_r($this->dataRecord));

      if(isset($this->dataRecord['username']) && trim($this->dataRecord['username']) == '') $app->tform->errorMessage .= $app->tform->lng('username_error_empty').'<br />';
      if(isset($this->dataRecord['username']) && empty($this->dataRecord['parent_domain_id'])) $app->tform->errorMessage .= $app->tform->lng('parent_domain_id_error_empty').'<br />';
      if(isset($this->dataRecord['dir']) && stristr($this->dataRecord['dir'], '..')) $app->tform->errorMessage .= $app->tform->lng('dir_dot_error').'<br />';
      if(isset($this->dataRecord['dir']) && stristr($this->dataRecord['dir'], './')) $app->tform->errorMessage .= $app->tform->lng('dir_slashdot_error').'<br />';

      parent::onSubmit();
   }
	

   function onBeforeInsert() {
      global $app, $conf, $interfaceConf;
		
      $app->uses('getconf');

      $app->uses('getconf,tools_sites');
      $global_config = $app->getconf->get_global_config('sites');
      $ftpuser_prefix = ($global_config['ftpuser_prefix'] == '')?'':str_replace('[CLIENTNAME]', $this->getClientName(), $global_config['ftpuser_prefix']);
		
      $ftpuser_prefix = $app->tools_sites->replacePrefix($global_config['ftpuser_prefix'], $this->dataRecord);

      $this->dataRecord['username_prefix'] = $ftpuser_prefix;

      if ($app->tform->errorMessage == '') {
         $this->dataRecord['username'] = $ftpuser_prefix . $this->dataRecord['username'];
      }
		

      parent::onBeforeInsert();
   }

      function onAfterInsert() {
   function onAfterInsert() {
      global $app, $conf;
		
      $web = $app->db->queryOneRecord("SELECT * FROM web_domain WHERE domain_id = ".intval($this->dataRecord["parent_domain_id"]));
      $server_id = $web["server_id"];

      $web = $app->db->queryOneRecord("SELECT * FROM web_domain WHERE domain_id = ?", $this->dataRecord["parent_domain_id"]);
      $server_id = $app->functions->intval($web["server_id"]);
      $dir = $web["document_root"];
      $uid = $web["system_user"];
      $gid = $web["system_group"];
      
      // Check system user and group
      if($app->functions->is_allowed_user($uid) == false || $app->functions->is_allowed_group($gid) == false) {
         $app->error('Invalid system user or group');
      }

      // The FTP user shall be owned by the same group then the website
      $sys_groupid = $web['sys_groupid'];
		
      $sql = "UPDATE ftp_user SET server_id = $server_id, dir = '$dir', uid = '$uid', gid = '$gid', sys_groupid = '$sys_groupid' WHERE ftp_user_id = ".$this->id;
      $app->db->query($sql);
		
		
      $sys_groupid = $app->functions->intval($web['sys_groupid']);

      $sql = "UPDATE ftp_user SET server_id = ?, dir = ?, uid = ?, gid = ?, sys_groupid = ? WHERE ftp_user_id = ?";
      $app->db->query($sql, $server_id, $dir, $uid, $gid, $sys_groupid, $this->id);
   }

   function onBeforeUpdate() {
      global $app, $conf, $interfaceConf;

		
      /*
       * If the names should be restricted -> do it!
       */
		
      $app->uses('getconf');

      $app->uses('getconf,tools_sites');
      $global_config = $app->getconf->get_global_config('sites');
      $ftpuser_prefix = ($global_config['ftpuser_prefix'] == '')?'':str_replace('[CLIENTNAME]', $this->getClientName(), $global_config['ftpuser_prefix']);
		
      $ftpuser_prefix = $app->tools_sites->replacePrefix($global_config['ftpuser_prefix'], $this->dataRecord);

      $old_record = $app->tform->getDataRecord($this->id);
      $ftpuser_prefix = $app->tools_sites->getPrefix($old_record['username_prefix'], $ftpuser_prefix);
      $this->dataRecord['username_prefix'] = $ftpuser_prefix;

      /* restrict the names */
      if ($app->tform->errorMessage == '') {
         $this->dataRecord['username'] = $ftpuser_prefix . $this->dataRecord['username'];
      }
   }
	

   function onAfterUpdate() {
      global $app, $conf;
		
		
   }
	
   function getClientName() {
      global $app, $conf;
	
      if($_SESSION["s"]["user"]["typ"] != 'admin') {
         // Get the group-id of the user
         $client_group_id = $_SESSION["s"]["user"]["default_group"];
      } else {
         // Get the group-id from the data itself
         $client_group_id = $this->dataRecord['client_group_id'];

      //* When the site of the FTP user has been changed
      if(isset($this->dataRecord['parent_domain_id']) && $this->oldDataRecord['parent_domain_id'] != $this->dataRecord['parent_domain_id']) {
         $web = $app->db->queryOneRecord("SELECT * FROM web_domain WHERE domain_id = ?", $this->dataRecord["parent_domain_id"]);
         $server_id = $app->functions->intval($web["server_id"]);
         $dir = $web["document_root"];
         $uid = $web["system_user"];
         $gid = $web["system_group"];

         // The FTP user shall be owned by the same group then the website
         $sys_groupid = $app->functions->intval($web['sys_groupid']);

         $sql = "UPDATE ftp_user SET server_id = ?, dir = ?, uid = ?, gid = ?, sys_groupid = ? WHERE ftp_user_id = ?";
         $app->db->query($sql, $server_id, $dir, $uid, $gid, $sys_groupid, $this->id);
      }
      /* get the name of the client */
      $tmp = $app->db->queryOneRecord("SELECT name FROM sys_group WHERE groupid = " . $client_group_id);
      $clientName = $tmp['name'];
      if ($clientName == "") $clientName = 'default';
      $clientName = convertClientName($clientName);
	

      //* 2. check to ensure that the FTP user path is not changed to a path outside of the docroot by a normal user
      if(isset($this->dataRecord['dir']) && $this->dataRecord['dir'] != $this->oldDataRecord['dir'] && !$app->auth->is_admin()) {
         $vd = new validate_ftpuser;
         $error_message = $vd->ftp_dir('dir', $this->dataRecord['dir'], '');
         //* This check should normally never be triggered
         //* Set the path to a safe path (web doc root).
         if($error_message != '') {
            $ftp_data = $app->db->queryOneRecord("SELECT parent_domain_id FROM ftp_user WHERE ftp_user_id = ?", $app->tform->primary_id);
            $web = $app->db->queryOneRecord("SELECT * FROM web_domain WHERE domain_id = ?", $ftp_data["parent_domain_id"]);
            $dir = $web["document_root"];
            $sql = "UPDATE ftp_user SET dir = ? WHERE ftp_user_id = ?";
            $app->db->query($sql, $dir, $this->id);
            $app->log("Error in FTP path settings of FTP user ".$this->dataRecord['username'], 1);
         }

      }

   }
	

}

$page = new page_action;
$page->onLoad();

?>
?>