Cleaning up code to match coding guidelines

Marius Cramer

2013-11-14 b1a6a5a3991cec5cd08873b01376e45d0b247f18

 interface/web/mail/mail_alias_edit.php

@@ -38,8 +38,8 @@
* End Form configuration
******************************************/

require_once('../../lib/config.inc.php');
require_once('../../lib/app.inc.php');
require_once '../../lib/config.inc.php';
require_once '../../lib/app.inc.php';

//* Check permissions for module
$app->auth->check_module_permissions('mail');
@@ -49,31 +49,31 @@
$app->load('tform_actions');

class page_action extends tform_actions {
	

   function onShowNew() {
      global $app, $conf;
		

      // we will check only users, not admins
      if($_SESSION["s"]["user"]["typ"] == 'user') {
         if(!$app->tform->checkClientLimit('limit_mailalias',"type = 'alias'")) {
         if(!$app->tform->checkClientLimit('limit_mailalias', "type = 'alias'")) {
            $app->error($app->tform->wordbook["limit_mailalias_txt"]);
         }
         if(!$app->tform->checkResellerLimit('limit_mailalias',"type = 'alias'")) {
         if(!$app->tform->checkResellerLimit('limit_mailalias', "type = 'alias'")) {
            $app->error('Reseller: '.$app->tform->wordbook["limit_mailalias_txt"]);
         }
      }
		

      parent::onShowNew();
   }
	

   function onShowEnd() {
      global $app, $conf;
		

      $email = $this->dataRecord["source"];
      $email_parts = explode("@",$email);
      $app->tpl->setVar("email_local_part",$email_parts[0]);
        $email_parts[1] = $app->functions->idn_decode($email_parts[1]);
		
      $email_parts = explode("@", $email);
      $app->tpl->setVar("email_local_part", $email_parts[0]);
      $email_parts[1] = $app->functions->idn_decode($email_parts[1]);

      // Getting Domains of the user
      // $sql = "SELECT domain FROM mail_domain WHERE ".$app->tform->getAuthSQL('r').' ORDER BY domain';
      $sql = "SELECT domain FROM mail_domain WHERE domain NOT IN (SELECT SUBSTR(source,2) FROM mail_forwarding WHERE type = 'aliasdomain') AND ".$app->tform->getAuthSQL('r')." ORDER BY domain";
@@ -81,29 +81,29 @@
      $domain_select = '';
      if(is_array($domains)) {
         foreach( $domains as $domain) {
                $domain['domain'] = $app->functions->idn_decode($domain['domain']);
            $domain['domain'] = $app->functions->idn_decode($domain['domain']);
            $selected = ($domain["domain"] == @$email_parts[1])?'SELECTED':'';
            $domain_select .= "<option value='$domain[domain]' $selected>$domain[domain]</option>\r\n";
         }
      }
      $app->tpl->setVar("email_domain",$domain_select);
		
      $app->tpl->setVar("email_domain", $domain_select);

      parent::onShowEnd();
   }
	

   function onSubmit() {
      global $app, $conf;
		

      // Check if Domain belongs to user
      $domain = $app->db->queryOneRecord("SELECT server_id, domain FROM mail_domain WHERE domain = '".$app->db->quote($app->functions->idn_encode($_POST["email_domain"]))."' AND ".$app->tform->getAuthSQL('r'));
      if($domain["domain"] != $app->functions->idn_encode($_POST["email_domain"])) $app->tform->errorMessage .= $app->tform->wordbook["no_domain_perm"];
		

      //* Check if destination email belongs to user
      if(isset($_POST["destination"])) {
         $email = $app->db->queryOneRecord("SELECT email FROM mail_user WHERE email = '".$app->db->quote($app->functions->idn_encode($_POST["destination"]))."' AND ".$app->tform->getAuthSQL('r'));
         if($email["email"] != $app->functions->idn_encode($_POST["destination"])) $app->tform->errorMessage .= $app->tform->lng("no_destination_perm");
      }
		

      // Check the client limits, if user is not the admin
      if($_SESSION["s"]["user"]["typ"] != 'admin') { // if user is not admin
         // Get the limits of the client
@@ -119,21 +119,21 @@
            unset($tmp);
         }
      } // end if user is not admin
		
		 		


      // compose the email field
      $this->dataRecord["source"] = $_POST["email_local_part"]."@".$app->functions->idn_encode($_POST["email_domain"]);
      // Set the server id of the mailbox = server ID of mail domain.
      $this->dataRecord["server_id"] = $domain["server_id"];
		

      unset($this->dataRecord["email_local_part"]);
      unset($this->dataRecord["email_domain"]);
		

      //* Check if there is no active mailbox with this address
      $tmp = $app->db->queryOneRecord("SELECT count(mailuser_id) as number FROM mail_user WHERE postfix = 'y' AND email = '".$app->db->quote($this->dataRecord["source"])."'");
      if($tmp['number'] > 0) $app->tform->errorMessage .= $app->tform->lng("duplicate_mailbox_txt")."<br>";
      unset($tmp);
		

      //* Check if email alias exists
      if($this->id > 0) {
         $tmp = $app->db->queryOneRecord("SELECT count(forwarding_id) as number FROM mail_forwarding WHERE source = '".$app->db->quote($this->dataRecord["source"])."' AND destination = '".$app->db->quote($this->dataRecord["destination"])."' AND forwarding_id != ".$this->id);
@@ -142,22 +142,22 @@
      }
      if($tmp['number'] > 0) $app->tform->errorMessage .= $app->tform->lng("duplicate_email_alias_txt")."<br>";
      unset($tmp);
		

      parent::onSubmit();
   }
	

   function onAfterInsert() {
      global $app;
		

      $domain = $app->db->queryOneRecord("SELECT sys_groupid FROM mail_domain WHERE domain = '".$app->db->quote($app->functions->idn_encode($_POST["email_domain"]))."' AND ".$app->tform->getAuthSQL('r'));
      $app->db->query("update mail_forwarding SET sys_groupid = ".$domain['sys_groupid']." WHERE forwarding_id = ".$this->id);
		

   }
	
	


}

$page = new page_action;
$page->onLoad();

?>
?>