James Moger
2014-04-17 26cc4ed9fad9796756d34ae0fd3350bd3c139c7a
[findbugs] Fix incorrect key lookup in commit cache
1 files modified
6 ■■■■■ changed files
src/main/java/com/gitblit/utils/CommitCache.java 6 ●●●●● patch | view | raw | blame | history
src/main/java/com/gitblit/utils/CommitCache.java
@@ -225,7 +225,8 @@
        List<RepositoryCommit> commits = new ArrayList<RepositoryCommit>();
        for (RevCommit commit : JGitUtils.getRevLog(repository, branch, sinceDate)) {
            RepositoryCommit commitModel = new RepositoryCommit(repositoryName, branch, commit);
            commitModel.setRefs(allRefs.get(commitModel.getName()));
            List<RefModel> commitRefs = allRefs.get(commitModel.getId());
            commitModel.setRefs(commitRefs);
            commits.add(commitModel);
        }
        return commits;
@@ -245,7 +246,8 @@
        List<RepositoryCommit> commits = new ArrayList<RepositoryCommit>();
        for (RevCommit commit : JGitUtils.getRevLog(repository, sinceCommit.getName(), branch)) {
            RepositoryCommit commitModel = new RepositoryCommit(repositoryName, branch, commit);
            commitModel.setRefs(allRefs.get(commitModel.getName()));
            List<RefModel> commitRefs = allRefs.get(commitModel.getId());
            commitModel.setRefs(commitRefs);
            commits.add(commitModel);
        }
        return commits;