Aleksander Machniak
2012-11-15 3a54cc50134806cc8e53abf0efa6faf416182990
Fix rcube_utils::explode_quoted_string() with explode(), added tests
2 files modified
15 ■■■■■ changed files
program/include/rcube_utils.php 2 ●●● patch | view | raw | blame | history
tests/Framework/Utils.php 13 ●●●●● patch | view | raw | blame | history
program/include/rcube_utils.php
@@ -761,7 +761,7 @@
            }
        }
        $result[] = substr($string, $p);
        $result[] = (string) substr($string, $p);
        return $result;
    }
tests/Framework/Utils.php
@@ -193,4 +193,17 @@
        $mod = rcube_utils::mod_css_styles("background:\\0075\\0072\\006c( javascript:alert('xss') )", 'rcmbody');
        $this->assertEquals("/* evil! */", $mod, "Don't allow encoding quirks (2)");
    }
    /**
     * Check rcube_utils::explode_quoted_string() compat. with explode()
     */
    function test_explode_quoted_string_compat()
    {
        $data = array('', 'a,b,c', 'a', ',', ',a');
        foreach ($data as $text) {
            $result = rcube_utils::explode_quoted_string(',', $text);
            $this->assertSame(explode(',', $text), $result);
        }
    }
}