Be more strict in style attribute filtering

thomascube

2011-12-09 98c2d69acf3001379dc008dc52b77b618c291140

Be more strict in style attribute filtering

 program/lib/washtml.php

@@ -168,7 +168,7 @@
                || ($src = $this->config['cid_map'][$this->config['base_url'].$match[2]])) {
              $value .= ' url('.htmlspecialchars($src, ENT_QUOTES) . ')';
            }
            else if (preg_match('/^(http|https|ftp):.*$/i', $match[2], $url)) {
            else if (preg_match('!^(https?:)?//[a-z0-9/._+-]+$!i', $match[2], $url)) {
              if ($this->config['allow_remote'])
                $value .= ' url('.htmlspecialchars($url[0], ENT_QUOTES).')';
              else

 tests/src/BID-26800.txt

@@ -10,13 +10,14 @@
<h1>2 test</h1>
<p>&lt;div&gt; block</p>
<div style="font-style:italic">valid css</div>
<div style="color:red; background:url('//somedomain.com/somepath/somefile.png')">
<div style="{ left:expression( alert(&#039;expression!&#039;) ) }">
<div style="{ background:url( alert(&#039;URL!&#039;) ) }">

<h1>3 test</h1>
<p>Inject comment text</p>
<div style="{ left:exp/*  */ression( alert(&#039;xss3&#039;) ) }">
<div style="{ background:u/* */rl( alert(&#039;xssurl3&#039;) ) }">
<div style=" background:u/* */rl( alert(&#039;xssurl3&#039;) ) ">

<h1>4 test</h1>
<p>Using reverse solid to directe the codepoint</p>