- Fix issue where draft auto-save wasn't executed after some inactivity tim...

alecpl

2012-04-22 da5cadcc122736f76acbfe1b583b453f83763345

- Fix issue where draft auto-save wasn't executed after some inactivity time
- Code improvement - unified (set|clear)Timeout() usage

 program/js/app.js

@@ -272,7 +272,7 @@
        // show printing dialog
        else if (this.env.action == 'print' && this.env.uid)
          if (bw.safari)
            window.setTimeout('window.print()', 10);
            setTimeout('window.print()', 10);
          else
            window.print();

@@ -771,7 +771,7 @@
      case 'always-load':
        if (this.env.uid && this.env.sender) {
          this.add_contact(urlencode(this.env.sender));
          window.setTimeout(function(){ ref.command('load-images'); }, 300);
          setTimeout(function(){ ref.command('load-images'); }, 300);
          break;
        }

@@ -789,7 +789,7 @@
            qstring += '&_safe=1';
          this.attachment_win = window.open(this.env.comm_path+'&_action=get&'+qstring+'&_frame=1', 'rcubemailattachment');
          if (this.attachment_win) {
            window.setTimeout(function(){ ref.attachment_win.focus(); }, 10);
            setTimeout(function(){ ref.attachment_win.focus(); }, 10);
            break;
          }
        }
@@ -912,19 +912,25 @@
        break;

      case 'savedraft':
        var form = this.gui_objects.messageform, msgid;

        // Reset the auto-save timer
        self.clearTimeout(this.save_timer);
        clearTimeout(this.save_timer);

        if (!this.gui_objects.messageform)
        // saving Drafts is disabled
        if (!form)
          break;

        // if saving Drafts is disabled in main.inc.php
        // or if compose form did not change
        if (!this.env.drafts_mailbox || this.cmp_hash == this.compose_field_hash())
        // compose form did not change
        if (this.cmp_hash == this.compose_field_hash()) {
          this.auto_save_start();
          break;
        }

        var form = this.gui_objects.messageform,
          msgid = this.set_busy(true, 'savingmessage');
        // re-set keep-alive timeout
        this.start_keepalive();

        msgid = this.set_busy(true, 'savingmessage');

        form.target = "savetarget";
        form._draft.value = '1';
@@ -940,7 +946,7 @@
          break;

        // Reset the auto-save timer
        self.clearTimeout(this.save_timer);
        clearTimeout(this.save_timer);

        // all checks passed, send message
        var lang = this.spellcheck_lang(),
@@ -959,7 +965,7 @@

      case 'send-attachment':
        // Reset the auto-save timer
        self.clearTimeout(this.save_timer);
        clearTimeout(this.save_timer);

        this.upload_file(props || this.gui_objects.uploadform);
        break;
@@ -1006,7 +1012,7 @@
        if (uid = this.get_single_uid()) {
          ref.printwin = window.open(this.env.comm_path+'&_action=print&_uid='+uid+'&_mbox='+urlencode(this.env.mailbox)+(this.env.safemode ? '&_safe=1' : ''));
          if (this.printwin) {
            window.setTimeout(function(){ ref.printwin.focus(); }, 20);
            setTimeout(function(){ ref.printwin.focus(); }, 20);
            if (this.env.action != 'show')
              this.mark_message('read', uid);
          }
@@ -1017,7 +1023,7 @@
        if (uid = this.get_single_uid()) {
          ref.sourcewin = window.open(this.env.comm_path+'&_action=viewsource&_uid='+uid+'&_mbox='+urlencode(this.env.mailbox));
          if (this.sourcewin)
            window.setTimeout(function(){ ref.sourcewin.focus(); }, 20);
            setTimeout(function(){ ref.sourcewin.focus(); }, 20);
          }
        break;

@@ -1162,7 +1168,7 @@

    // set timer for requests
    if (a && this.env.request_timeout)
      this.request_timer = window.setTimeout(function(){ ref.request_timed_out(); }, this.env.request_timeout * 1000);
      this.request_timer = setTimeout(function(){ ref.request_timed_out(); }, this.env.request_timeout * 1000);

    return id;
  };
@@ -1214,7 +1220,7 @@
    if (this.is_framed())
      parent.rcmail.reload(delay);
    else if (delay)
      window.setTimeout(function(){ rcmail.reload(); }, delay);
      setTimeout(function(){ rcmail.reload(); }, delay);
    else if (window.location)
      location.href = this.env.comm_path + (this.env.action ? '&_action='+this.env.action : '');
  };
@@ -1347,7 +1353,7 @@
    this.env.last_folder_target = null;

    if (this.folder_auto_timer) {
      window.clearTimeout(this.folder_auto_timer);
      clearTimeout(this.folder_auto_timer);
      this.folder_auto_timer = null;
      this.folder_auto_expand = null;
    }
@@ -1400,15 +1406,15 @@
            // if the folder is collapsed, expand it after 1sec and restart the drag & drop process.
            if (div.hasClass('collapsed')) {
              if (this.folder_auto_timer)
                window.clearTimeout(this.folder_auto_timer);
                clearTimeout(this.folder_auto_timer);

              this.folder_auto_expand = this.env.mailboxes[k].id;
              this.folder_auto_timer = window.setTimeout(function() {
              this.folder_auto_timer = setTimeout(function() {
                rcmail.command('collapse-folder', rcmail.folder_auto_expand);
                rcmail.drag_start(null);
              }, 1000);
            } else if (this.folder_auto_timer) {
              window.clearTimeout(this.folder_auto_timer);
              clearTimeout(this.folder_auto_timer);
              this.folder_auto_timer = null;
              this.folder_auto_expand = null;
            }
@@ -1560,7 +1566,7 @@

    // start timer for message preview (wait for double click)
    if (selected && this.env.contentframe && !list.multi_selecting && !this.dummy_select)
      this.preview_timer = window.setTimeout(function(){ ref.msglist_get_preview(); }, 200);
      this.preview_timer = setTimeout(function(){ ref.msglist_get_preview(); }, 200);
    else if (this.env.contentframe)
      this.show_contentframe(false);
  };
@@ -1577,7 +1583,7 @@
          clearTimeout(this.preview_timer);
        if (this.preview_read_timer)
          clearTimeout(this.preview_read_timer);
        this.preview_timer = window.setTimeout(function(){ ref.msglist_get_preview(); }, 200);
        this.preview_timer = setTimeout(function(){ ref.msglist_get_preview(); }, 200);
      }
    }
  };
@@ -1963,7 +1969,7 @@

      // mark as read and change mbox unread counter
      if (action == 'preview' && this.message_list && this.message_list.rows[id] && this.message_list.rows[id].unread && this.env.preview_pane_mark_read >= 0) {
        this.preview_read_timer = window.setTimeout(function() {
        this.preview_read_timer = setTimeout(function() {
          ref.set_message(id, 'unread', false);
          ref.update_thread_root(id, 'read');
          if (ref.env.unread_counts[ref.env.mailbox]) {
@@ -3152,7 +3158,7 @@
      tinyMCE.execCommand('mceAddControl', false, props.id);

      if (this.env.default_font)
        window.setTimeout(function() {
        setTimeout(function() {
          $(tinyMCE.get(props.id).getBody()).css('font-family', rcmail.env.default_font);
        }, 500);
    }
@@ -3251,7 +3257,7 @@
  this.auto_save_start = function()
  {
    if (this.env.draft_autosave)
      this.save_timer = self.setTimeout(function(){ ref.command("savedraft"); }, this.env.draft_autosave * 1000);
      this.save_timer = setTimeout(function(){ ref.command("savedraft"); }, this.env.draft_autosave * 1000);

    // Unlock interface now that saving is complete
    this.busy = false;
@@ -3536,7 +3542,7 @@

  this.upload_progress_start = function(action, name)
  {
    window.setTimeout(function() { rcmail.http_request(action, {_progress: name}); },
    setTimeout(function() { rcmail.http_request(action, {_progress: name}); },
      this.env.upload_progress_time * 1000);
  };

@@ -3641,7 +3647,7 @@
  {
    this.display_message(msg, type);
    // before redirect we need to wait some time for Chrome (#1486177)
    window.setTimeout(function(){ ref.list_mailbox(); }, 500);
    setTimeout(function(){ ref.list_mailbox(); }, 500);
  };


@@ -3699,11 +3705,11 @@
      case 37:  // left
      case 39:  // right
        if (mod != SHIFT_KEY)
          return;
          return;
    }

    // start timer
    this.ksearch_timer = window.setTimeout(function(){ ref.ksearch_get_results(props); }, 200);
    this.ksearch_timer = setTimeout(function(){ ref.ksearch_get_results(props); }, 200);
    this.ksearch_input = obj;

    return true;
@@ -4011,7 +4017,7 @@
      source = this.env.source ? this.env.address_sources[this.env.source] : null;

    if (id = list.get_single_selection())
      this.preview_timer = window.setTimeout(function(){ ref.load_contact(id, 'show'); }, 200);
      this.preview_timer = setTimeout(function(){ ref.load_contact(id, 'show'); }, 200);
    else if (this.env.contentframe)
      this.show_contentframe(false);

@@ -5553,7 +5559,7 @@
      }
      // add element and set timeout
      this.messages[key].elements.push(id);
      window.setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
      setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
      return id;
    }

@@ -5573,7 +5579,7 @@
    this.triggerEvent('message', { message:msg, type:type, timeout:timeout, object:obj });

    if (timeout > 0)
      window.setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
      setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
    return id;
  };