From 53b312fdc03e797d751d73e79a58e2b2bb3f9e87 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Thu, 10 Apr 2014 19:00:05 -0400
Subject: [PATCH] Simplify show user output
---
src/main/java/com/gitblit/transport/ssh/gitblit/UsersDispatcher.java | 67 +++++++++++++++++++++++++--------
1 files changed, 51 insertions(+), 16 deletions(-)
diff --git a/src/main/java/com/gitblit/transport/ssh/gitblit/UsersDispatcher.java b/src/main/java/com/gitblit/transport/ssh/gitblit/UsersDispatcher.java
index d892d9a..52aedbb 100644
--- a/src/main/java/com/gitblit/transport/ssh/gitblit/UsersDispatcher.java
+++ b/src/main/java/com/gitblit/transport/ssh/gitblit/UsersDispatcher.java
@@ -25,8 +25,8 @@
import com.gitblit.manager.IGitblit;
import com.gitblit.models.RegistrantAccessPermission;
import com.gitblit.models.RepositoryModel;
-import com.gitblit.models.TeamModel;
import com.gitblit.models.UserModel;
+import com.gitblit.transport.ssh.SshKey;
import com.gitblit.transport.ssh.commands.CommandMetaData;
import com.gitblit.transport.ssh.commands.DispatchCommand;
import com.gitblit.transport.ssh.commands.ListFilterCommand;
@@ -272,28 +272,41 @@
UserModel u = getUser(true);
// fields
- String [] fheaders = new String [] { "Field", "Value" };
- Object [][] fdata = new Object[5][];
- fdata[0] = new Object [] { "Email", u.emailAddress };
- fdata[1] = new Object [] { "Type", u.accountType };
- fdata[2] = new Object [] { "Can Admin", u.canAdmin() ? "Y":"" };
- fdata[3] = new Object [] { "Can Fork", u.canFork() ? "Y":"" };
- fdata[4] = new Object [] { "Can Create", u.canCreate() ? "Y":"" };
- String fields = FlipTable.of(fheaders, fdata, Borders.COLS);
+ StringBuilder fb = new StringBuilder();
+ fb.append("Email : ").append(u.emailAddress == null ? "": u.emailAddress).append('\n');
+ fb.append("Type : ").append(u.accountType).append('\n');
+ fb.append("Can Admin : ").append(u.canAdmin() ? "Y":"").append('\n');
+ fb.append("Can Fork : ").append(u.canFork() ? "Y":"").append('\n');
+ fb.append("Can Create : ").append(u.canCreate() ? "Y":"").append('\n');
+ String fields = fb.toString();
// teams
String teams;
if (u.teams.size() == 0) {
teams = FlipTable.EMPTY;
} else {
- String [] theaders = new String [] { "Team", "Type" };
- Object [][] tdata = new Object[u.teams.size()][];
+ teams = Joiner.on(", ").join(u.teams);
+ }
+
+ // owned repositories
+ String ownedTable;
+ List<RepositoryModel> owned = new ArrayList<RepositoryModel>();
+ for (RepositoryModel repository : getContext().getGitblit().getRepositoryModels(u)) {
+ if (repository.isOwner(u.username)) {
+ owned.add(repository);
+ }
+ }
+ if (owned.isEmpty()) {
+ ownedTable = FlipTable.EMPTY;
+ } else {
+ String [] theaders = new String [] { "Repository", "Description" };
+ Object [][] tdata = new Object[owned.size()][];
int i = 0;
- for (TeamModel t : u.teams) {
- tdata[i] = new Object [] { t.name, t.accountType };
+ for (RepositoryModel r : owned) {
+ tdata[i] = new Object [] { r.name, r.description };
i++;
}
- teams = FlipTable.of(theaders, tdata, Borders.COLS);
+ ownedTable = FlipTable.of(theaders, tdata, Borders.COLS);
}
// permissions
@@ -311,25 +324,47 @@
permissions = FlipTable.of(pheaders, pdata, Borders.COLS);
}
+ // keys
+ String keyTable;
+ List<SshKey> keys = getContext().getGitblit().getPublicKeyManager().getKeys(u.username);
+ if (ArrayUtils.isEmpty(keys)) {
+ keyTable = FlipTable.EMPTY;
+ } else {
+ String[] headers = { "#", "Fingerprint", "Comment", "Type" };
+ int len = keys == null ? 0 : keys.size();
+ Object[][] data = new Object[len][];
+ for (int i = 0; i < len; i++) {
+ // show 1-based index numbers with the fingerprint
+ // this is useful for comparing with "ssh-add -l"
+ SshKey k = keys.get(i);
+ data[i] = new Object[] { (i + 1), k.getFingerprint(), k.getComment(), k.getAlgorithm() };
+ }
+ keyTable = FlipTable.of(headers, data, Borders.COLS);
+ }
+
// assemble user table
String userTitle = u.getDisplayName() + (u.username.equals(u.getDisplayName()) ? "" : (" (" + u.username + ")"));
if (u.disabled) {
userTitle += " [DISABLED]";
}
String [] headers = new String[] { userTitle };
- String[][] data = new String[6][];
+ String[][] data = new String[8][];
data[0] = new String [] { "FIELDS" };
data[1] = new String [] { fields };
data[2] = new String [] { "TEAMS" };
data[3] = new String [] { teams };
+ data[4] = new String [] { "OWNED REPOSITORIES" };
+ data[5] = new String [] { ownedTable };
data[4] = new String [] { "PERMISSIONS" };
data[5] = new String [] { permissions };
+ data[6] = new String [] { "SSH PUBLIC KEYS" };
+ data[7] = new String [] { keyTable };
stdout.println(FlipTable.of(headers, data));
}
}
@CommandMetaData(name = "list", aliases= { "ls" }, description = "List accounts")
- @UsageExamples( examples = {
+ @UsageExamples(examples = {
@UsageExample(syntax = "${cmd}", description = "List accounts as a table"),
@UsageExample(syntax = "${cmd} j.*", description = "List all accounts that start with 'j'"),
})
--
Gitblit v1.9.1