From 78dc06a87f82ed19e3eebe1f16dc6c1bdaf5fbc5 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Tue, 31 Jan 2012 09:35:30 -0500
Subject: [PATCH] Merge pull request #6 from lemval/master

---
 tests/com/gitblit/tests/RpcTests.java |  213 ++++++++++++++++++++++++++++++++++++++++++++++-------
 1 files changed, 185 insertions(+), 28 deletions(-)

diff --git a/tests/com/gitblit/tests/RpcTests.java b/tests/com/gitblit/tests/RpcTests.java
index 450b597..f85dd79 100644
--- a/tests/com/gitblit/tests/RpcTests.java
+++ b/tests/com/gitblit/tests/RpcTests.java
@@ -15,19 +15,34 @@
  */
 package com.gitblit.tests;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
 import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.atomic.AtomicBoolean;
 
-import junit.framework.TestCase;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
 
 import com.gitblit.Constants.AccessRestrictionType;
 import com.gitblit.GitBlitException.UnauthorizedException;
-import com.gitblit.IStoredSettings;
+import com.gitblit.Keys;
+import com.gitblit.RpcServlet;
 import com.gitblit.models.FederationModel;
 import com.gitblit.models.FederationProposal;
 import com.gitblit.models.FederationSet;
 import com.gitblit.models.RepositoryModel;
+import com.gitblit.models.ServerSettings;
+import com.gitblit.models.ServerStatus;
+import com.gitblit.models.TeamModel;
 import com.gitblit.models.UserModel;
 import com.gitblit.utils.RpcUtils;
 
@@ -37,30 +52,67 @@
  * @author James Moger
  * 
  */
-public class RpcTests extends TestCase {
+public class RpcTests {
 
-	String url = "https://localhost:8443";
-	String account = "admin";
-	String password = "admin";
+	String url = GitBlitSuite.url;
+	String account = GitBlitSuite.account;
+	String password = GitBlitSuite.password;
 
+	private static final AtomicBoolean started = new AtomicBoolean(false);
+
+	@BeforeClass
+	public static void startGitblit() throws Exception {
+		started.set(GitBlitSuite.startGitblit());
+	}
+
+	@AfterClass
+	public static void stopGitblit() throws Exception {
+		if (started.get()) {
+			GitBlitSuite.stopGitblit();
+		}
+	}
+
+	@Test
+	public void testGetProtocolVersion() throws IOException {
+		int protocol = RpcUtils.getProtocolVersion(url, null, null);
+		assertEquals(RpcServlet.PROTOCOL_VERSION, protocol);
+	}
+
+	@Test
 	public void testListRepositories() throws IOException {
 		Map<String, RepositoryModel> map = RpcUtils.getRepositories(url, null, null);
-		assertTrue("Repository list is null!", map != null);
+		assertNotNull("Repository list is null!", map);
 		assertTrue("Repository list is empty!", map.size() > 0);
 	}
 
+	@Test
 	public void testListUsers() throws IOException {
 		List<UserModel> list = null;
 		try {
 			list = RpcUtils.getUsers(url, null, null);
 		} catch (UnauthorizedException e) {
 		}
-		assertTrue("Server allows anyone to admin!", list == null);
+		assertNull("Server allows anyone to admin!", list);
 
 		list = RpcUtils.getUsers(url, "admin", "admin".toCharArray());
 		assertTrue("User list is empty!", list.size() > 0);
 	}
 
+	@Test
+	public void testListTeams() throws IOException {
+		List<TeamModel> list = null;
+		try {
+			list = RpcUtils.getTeams(url, null, null);
+		} catch (UnauthorizedException e) {
+		}
+		assertNull("Server allows anyone to admin!", list);
+
+		list = RpcUtils.getTeams(url, "admin", "admin".toCharArray());
+		assertTrue("Team list is empty!", list.size() > 0);
+		assertEquals("admins", list.get(0).name);
+	}
+
+	@Test
 	public void testUserAdministration() throws IOException {
 		UserModel user = new UserModel("garbage");
 		user.canAdmin = true;
@@ -71,7 +123,7 @@
 				RpcUtils.createUser(user, url, account, password.toCharArray()));
 
 		UserModel retrievedUser = findUser(user.username);
-		assertTrue("Failed to find " + user.username, retrievedUser != null);
+		assertNotNull("Failed to find " + user.username, retrievedUser);
 		assertTrue("Retrieved user can not administer Gitblit", retrievedUser.canAdmin);
 
 		// rename and toggle admin permission
@@ -82,7 +134,7 @@
 				RpcUtils.updateUser(originalName, user, url, account, password.toCharArray()));
 
 		retrievedUser = findUser(user.username);
-		assertTrue("Failed to find " + user.username, retrievedUser != null);
+		assertNotNull("Failed to find " + user.username, retrievedUser);
 		assertTrue("Retrieved user did not update", !retrievedUser.canAdmin);
 
 		// delete
@@ -90,7 +142,7 @@
 				RpcUtils.deleteUser(retrievedUser, url, account, password.toCharArray()));
 
 		retrievedUser = findUser(user.username);
-		assertTrue("Failed to delete " + user.username, retrievedUser == null);
+		assertNull("Failed to delete " + user.username, retrievedUser);
 	}
 
 	private UserModel findUser(String name) throws IOException {
@@ -105,6 +157,7 @@
 		return retrievedUser;
 	}
 
+	@Test
 	public void testRepositoryAdministration() throws IOException {
 		RepositoryModel model = new RepositoryModel();
 		model.name = "garbagerepo.git";
@@ -117,9 +170,8 @@
 				RpcUtils.createRepository(model, url, account, password.toCharArray()));
 
 		RepositoryModel retrievedRepository = findRepository(model.name);
-		assertTrue("Failed to find " + model.name, retrievedRepository != null);
-		assertTrue("Access retriction type is wrong",
-				AccessRestrictionType.VIEW.equals(retrievedRepository.accessRestriction));
+		assertNotNull("Failed to find " + model.name, retrievedRepository);
+		assertEquals(AccessRestrictionType.VIEW, retrievedRepository.accessRestriction);
 
 		// rename and change access restriciton
 		String originalName = model.name;
@@ -129,16 +181,18 @@
 				url, account, password.toCharArray()));
 
 		retrievedRepository = findRepository(model.name);
-		assertTrue("Failed to find " + model.name, retrievedRepository != null);
+		assertNotNull("Failed to find " + model.name, retrievedRepository);
 		assertTrue("Access retriction type is wrong",
 				AccessRestrictionType.PUSH.equals(retrievedRepository.accessRestriction));
 
 		// memberships
-		String testMember = "justadded";
+		UserModel testMember = new UserModel("justadded");
+		assertTrue(RpcUtils.createUser(testMember, url, account, password.toCharArray()));
+
 		List<String> members = RpcUtils.getRepositoryMembers(retrievedRepository, url, account,
 				password.toCharArray());
-		assertTrue("Membership roster is not empty!", members.size() == 0);
-		members.add(testMember);
+		assertEquals("Membership roster is not empty!", 0, members.size());
+		members.add(testMember.username);
 		assertTrue(
 				"Failed to set memberships!",
 				RpcUtils.setRepositoryMembers(retrievedRepository, members, url, account,
@@ -147,7 +201,7 @@
 				password.toCharArray());
 		boolean foundMember = false;
 		for (String member : members) {
-			if (member.equalsIgnoreCase(testMember)) {
+			if (member.equalsIgnoreCase(testMember.username)) {
 				foundMember = true;
 				break;
 			}
@@ -159,11 +213,11 @@
 				url, account, password.toCharArray()));
 
 		retrievedRepository = findRepository(model.name);
-		assertTrue("Failed to delete " + model.name, retrievedRepository == null);
+		assertNull("Failed to delete " + model.name, retrievedRepository);
 
 		for (UserModel u : RpcUtils.getUsers(url, account, password.toCharArray())) {
-			if (u.username.equals(testMember)) {
-				RpcUtils.deleteUser(u, url, account, password.toCharArray());
+			if (u.username.equals(testMember.username)) {
+				assertTrue(RpcUtils.deleteUser(u, url, account, password.toCharArray()));
 				break;
 			}
 		}
@@ -182,31 +236,134 @@
 		return retrievedRepository;
 	}
 
+	@Test
+	public void testTeamAdministration() throws IOException {
+		List<TeamModel> teams = RpcUtils.getTeams(url, account, password.toCharArray());
+		assertEquals(1, teams.size());
+		
+		// Create the A-Team
+		TeamModel aTeam = new TeamModel("A-Team");
+		aTeam.users.add("admin");
+		aTeam.repositories.add("helloworld.git");
+		assertTrue(RpcUtils.createTeam(aTeam, url, account, password.toCharArray()));
+
+		aTeam = null;
+		teams = RpcUtils.getTeams(url, account, password.toCharArray());
+		assertEquals(2, teams.size());
+		for (TeamModel team : teams) {
+			if (team.name.equals("A-Team")) {
+				aTeam = team;
+				break;
+			}
+		}
+		assertNotNull(aTeam);
+		assertTrue(aTeam.hasUser("admin"));
+		assertTrue(aTeam.hasRepository("helloworld.git"));
+
+		RepositoryModel helloworld = null;
+		Map<String, RepositoryModel> repositories = RpcUtils.getRepositories(url, account,
+				password.toCharArray());
+		for (RepositoryModel repository : repositories.values()) {
+			if (repository.name.equals("helloworld.git")) {
+				helloworld = repository;
+				break;
+			}
+		}
+		assertNotNull(helloworld);
+		
+		// Confirm that we have added the team
+		List<String> helloworldTeams = RpcUtils.getRepositoryTeams(helloworld, url, account,
+				password.toCharArray());
+		assertEquals(1, helloworldTeams.size());
+		assertTrue(helloworldTeams.contains(aTeam.name));
+
+		// set no teams
+		assertTrue(RpcUtils.setRepositoryTeams(helloworld, new ArrayList<String>(), url, account,
+				password.toCharArray()));
+		helloworldTeams = RpcUtils.getRepositoryTeams(helloworld, url, account,
+				password.toCharArray());
+		assertEquals(0, helloworldTeams.size());
+		
+		// delete the A-Team
+		assertTrue(RpcUtils.deleteTeam(aTeam, url, account, password.toCharArray()));
+
+		teams = RpcUtils.getTeams(url, account, password.toCharArray());
+		assertEquals(1, teams.size());
+	}
+
+	@Test
 	public void testFederationRegistrations() throws Exception {
 		List<FederationModel> registrations = RpcUtils.getFederationRegistrations(url, account,
 				password.toCharArray());
-		assertTrue("No federation registrations wre retrieved!", registrations.size() > 0);
+		assertTrue("No federation registrations were retrieved!", registrations.size() >= 0);
 	}
 
+	@Test
 	public void testFederationResultRegistrations() throws Exception {
 		List<FederationModel> registrations = RpcUtils.getFederationResultRegistrations(url,
 				account, password.toCharArray());
-		assertTrue("No federation result registrations were retrieved!", registrations.size() > 0);
+		assertTrue("No federation result registrations were retrieved!", registrations.size() >= 0);
 	}
 
+	@Test
 	public void testFederationProposals() throws Exception {
 		List<FederationProposal> proposals = RpcUtils.getFederationProposals(url, account,
 				password.toCharArray());
-		assertTrue("No federation proposals were retrieved!", proposals.size() > 0);
+		assertTrue("No federation proposals were retrieved!", proposals.size() >= 0);
 	}
 
+	@Test
 	public void testFederationSets() throws Exception {
 		List<FederationSet> sets = RpcUtils.getFederationSets(url, account, password.toCharArray());
-		assertTrue("No federation sets were retrieved!", sets.size() > 0);
+		assertTrue("No federation sets were retrieved!", sets.size() >= 0);
 	}
 
+	@Test
 	public void testSettings() throws Exception {
-		IStoredSettings settings = RpcUtils.getSettings(url, account, password.toCharArray());
-		assertTrue("No settings were retrieved!", settings.getAllKeys(null).size() > 0);
+		ServerSettings settings = RpcUtils.getSettings(url, account, password.toCharArray());
+		assertNotNull("No settings were retrieved!", settings);
+	}
+
+	@Test
+	public void testServerStatus() throws Exception {
+		ServerStatus status = RpcUtils.getStatus(url, account, password.toCharArray());
+		assertNotNull("No status was retrieved!", status);
+	}
+
+	@Test
+	public void testUpdateSettings() throws Exception {
+		Map<String, String> updated = new HashMap<String, String>();
+
+		// grab current setting
+		ServerSettings settings = RpcUtils.getSettings(url, account, password.toCharArray());
+		boolean showSizes = settings.get(Keys.web.showRepositorySizes).getBoolean(true);
+		showSizes = !showSizes;
+
+		// update setting
+		updated.put(Keys.web.showRepositorySizes, String.valueOf(showSizes));
+		boolean success = RpcUtils.updateSettings(updated, url, account, password.toCharArray());
+		assertTrue("Failed to update server settings", success);
+
+		// confirm setting change
+		settings = RpcUtils.getSettings(url, account, password.toCharArray());
+		boolean newValue = settings.get(Keys.web.showRepositorySizes).getBoolean(false);
+		assertEquals(newValue, showSizes);
+
+		// restore setting
+		newValue = !newValue;
+		updated.put(Keys.web.showRepositorySizes, String.valueOf(newValue));
+		success = RpcUtils.updateSettings(updated, url, account, password.toCharArray());
+		assertTrue("Failed to update server settings", success);
+		settings = RpcUtils.getSettings(url, account, password.toCharArray());
+		showSizes = settings.get(Keys.web.showRepositorySizes).getBoolean(true);
+		assertEquals(newValue, showSizes);
+	}
+
+	@Test
+	public void testBranches() throws Exception {
+		Map<String, Collection<String>> branches = RpcUtils.getBranches(url, account,
+				password.toCharArray());
+		assertNotNull(branches);
+		assertTrue(branches.size() > 0);
 	}
 }

--
Gitblit v1.9.1