From 7e8873a14ccc2cb25213489d7d7ba97f09673831 Mon Sep 17 00:00:00 2001 From: James Moger <james.moger@gitblit.com> Date: Wed, 07 Dec 2011 19:14:34 -0500 Subject: [PATCH] Unit testing overhaul. --- tests/com/gitblit/tests/JGitUtilsTest.java | 383 ++++++++++++++++++++++++++++++++++++++++-------------- 1 files changed, 283 insertions(+), 100 deletions(-) diff --git a/tests/com/gitblit/tests/JGitUtilsTest.java b/tests/com/gitblit/tests/JGitUtilsTest.java index 14d318f..e330c42 100644 --- a/tests/com/gitblit/tests/JGitUtilsTest.java +++ b/tests/com/gitblit/tests/JGitUtilsTest.java @@ -15,152 +15,249 @@ */ package com.gitblit.tests; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + import java.io.File; import java.io.FileOutputStream; +import java.text.SimpleDateFormat; +import java.util.Arrays; import java.util.Date; import java.util.List; +import java.util.Map; -import junit.framework.TestCase; - +import org.eclipse.jgit.diff.DiffEntry.ChangeType; import org.eclipse.jgit.lib.Constants; +import org.eclipse.jgit.lib.FileMode; +import org.eclipse.jgit.lib.ObjectId; +import org.eclipse.jgit.lib.PersonIdent; import org.eclipse.jgit.lib.Repository; -import org.eclipse.jgit.revwalk.RevBlob; +import org.eclipse.jgit.lib.RepositoryCache.FileKey; import org.eclipse.jgit.revwalk.RevCommit; -import org.eclipse.jgit.revwalk.RevObject; -import org.eclipse.jgit.revwalk.RevTree; +import org.eclipse.jgit.util.FS; +import org.eclipse.jgit.util.FileUtils; +import org.junit.Test; +import com.gitblit.Constants.SearchType; import com.gitblit.GitBlit; -import com.gitblit.models.Metric; +import com.gitblit.Keys; +import com.gitblit.models.GitNote; +import com.gitblit.models.PathModel; import com.gitblit.models.PathModel.PathChangeModel; import com.gitblit.models.RefModel; -import com.gitblit.models.TicketModel; -import com.gitblit.models.TicketModel.Comment; import com.gitblit.utils.JGitUtils; -import com.gitblit.utils.MetricUtils; +import com.gitblit.utils.StringUtils; -public class JGitUtilsTest extends TestCase { +public class JGitUtilsTest { + @Test + public void testDisplayName() throws Exception { + assertEquals("Napoleon Bonaparte", + JGitUtils.getDisplayName(new PersonIdent("Napoleon Bonaparte", ""))); + assertEquals("<someone@somewhere.com>", + JGitUtils.getDisplayName(new PersonIdent("", "someone@somewhere.com"))); + assertEquals("Napoleon Bonaparte <someone@somewhere.com>", + JGitUtils.getDisplayName(new PersonIdent("Napoleon Bonaparte", + "someone@somewhere.com"))); + } + + @Test public void testFindRepositories() { List<String> list = JGitUtils.getRepositoryList(null, true, true); - assertTrue(list.size() == 0); + assertEquals(0, list.size()); list.addAll(JGitUtils.getRepositoryList(new File("DoesNotExist"), true, true)); - assertTrue(list.size() == 0); + assertEquals(0, list.size()); list.addAll(JGitUtils.getRepositoryList(GitBlitSuite.REPOSITORIES, true, true)); assertTrue("No repositories found in " + GitBlitSuite.REPOSITORIES, list.size() > 0); } + @Test public void testOpenRepository() throws Exception { Repository repository = GitBlitSuite.getHelloworldRepository(); repository.close(); - assertTrue("Could not find repository!", repository != null); + assertNotNull("Could not find repository!", repository); } + @Test public void testFirstCommit() throws Exception { - assertTrue(JGitUtils.getFirstChange(null, null).equals(new Date(0))); - + assertEquals(new Date(0), JGitUtils.getFirstChange(null, null)); + Repository repository = GitBlitSuite.getHelloworldRepository(); RevCommit commit = JGitUtils.getFirstCommit(repository, null); Date firstChange = JGitUtils.getFirstChange(repository, null); repository.close(); - assertTrue("Could not get first commit!", commit != null); - assertTrue("Incorrect first commit!", - commit.getName().equals("f554664a346629dc2b839f7292d06bad2db4aece")); + assertNotNull("Could not get first commit!", commit); + assertEquals("Incorrect first commit!", "f554664a346629dc2b839f7292d06bad2db4aece", + commit.getName()); assertTrue(firstChange.equals(new Date(commit.getCommitTime() * 1000L))); } - + + @Test public void testLastCommit() throws Exception { - assertTrue(JGitUtils.getLastChange(null).equals(new Date(0))); - + assertEquals(new Date(0), JGitUtils.getLastChange(null, null)); + Repository repository = GitBlitSuite.getHelloworldRepository(); assertTrue(JGitUtils.getCommit(repository, null) != null); - Date date = JGitUtils.getLastChange(repository); + Date date = JGitUtils.getLastChange(repository, null); repository.close(); - assertTrue("Could not get last repository change date!", date != null); + assertNotNull("Could not get last repository change date!", date); } - - + @Test public void testCreateRepository() throws Exception { String[] repositories = { "NewTestRepository.git", "NewTestRepository" }; for (String repositoryName : repositories) { - boolean isBare = repositoryName.endsWith(".git"); Repository repository = JGitUtils.createRepository(GitBlitSuite.REPOSITORIES, - repositoryName, isBare); - File folder; - if (isBare) { - folder = new File(GitBlitSuite.REPOSITORIES, repositoryName); - } else { - folder = new File(GitBlitSuite.REPOSITORIES, repositoryName + "/.git"); - } - assertTrue(repository != null); + repositoryName); + File folder = FileKey.resolve(new File(GitBlitSuite.REPOSITORIES, repositoryName), + FS.DETECTED); + assertNotNull(repository); assertFalse(JGitUtils.hasCommits(repository)); - assertTrue(JGitUtils.getFirstCommit(repository, null) == null); - assertTrue(JGitUtils.getFirstChange(repository, null).getTime() == folder - .lastModified()); - assertTrue(JGitUtils.getLastChange(repository).getTime() == folder - .lastModified()); - assertTrue(JGitUtils.getCommit(repository, null) == null); + assertNull(JGitUtils.getFirstCommit(repository, null)); + assertEquals(folder.lastModified(), JGitUtils.getFirstChange(repository, null) + .getTime()); + assertEquals(folder.lastModified(), JGitUtils.getLastChange(repository, null).getTime()); + assertNull(JGitUtils.getCommit(repository, null)); repository.close(); assertTrue(GitBlit.self().deleteRepository(repositoryName)); } } + @Test public void testRefs() throws Exception { - Repository repository = GitBlitSuite.getTicgitRepository(); - for (RefModel model : JGitUtils.getLocalBranches(repository, -1)) { + Repository repository = GitBlitSuite.getJGitRepository(); + Map<ObjectId, List<RefModel>> map = JGitUtils.getAllRefs(repository); + repository.close(); + assertTrue(map.size() > 0); + for (Map.Entry<ObjectId, List<RefModel>> entry : map.entrySet()) { + List<RefModel> list = entry.getValue(); + for (RefModel ref : list) { + if (ref.displayName.equals("refs/tags/spearce-gpg-pub")) { + assertEquals("refs/tags/spearce-gpg-pub", ref.toString()); + assertEquals("8bbde7aacf771a9afb6992434f1ae413e010c6d8", ref.getObjectId() + .getName()); + assertEquals("spearce@spearce.org", ref.getAuthorIdent().getEmailAddress()); + assertTrue(ref.getShortMessage().startsWith("GPG key")); + assertTrue(ref.getFullMessage().startsWith("GPG key")); + assertEquals(Constants.OBJ_BLOB, ref.getReferencedObjectType()); + } else if (ref.displayName.equals("refs/tags/v0.12.1")) { + assertTrue(ref.isAnnotatedTag()); + } + } + } + } + + @Test + public void testBranches() throws Exception { + Repository repository = GitBlitSuite.getJGitRepository(); + assertTrue(JGitUtils.getLocalBranches(repository, true, 0).size() == 0); + for (RefModel model : JGitUtils.getLocalBranches(repository, true, -1)) { assertTrue(model.getName().startsWith(Constants.R_HEADS)); assertTrue(model.equals(model)); assertFalse(model.equals("")); - assertTrue(model.hashCode() == model.getCommitId().hashCode() + assertTrue(model.hashCode() == model.getReferencedObjectId().hashCode() + model.getName().hashCode()); - assertTrue(model.getShortLog().equals(model.commit.getShortMessage())); + assertTrue(model.getShortMessage().equals(model.getShortMessage())); } - for (RefModel model : JGitUtils.getRemoteBranches(repository, -1)) { + for (RefModel model : JGitUtils.getRemoteBranches(repository, true, -1)) { assertTrue(model.getName().startsWith(Constants.R_REMOTES)); assertTrue(model.equals(model)); assertFalse(model.equals("")); - assertTrue(model.hashCode() == model.getCommitId().hashCode() + assertTrue(model.hashCode() == model.getReferencedObjectId().hashCode() + model.getName().hashCode()); - assertTrue(model.getShortLog().equals(model.commit.getShortMessage())); + assertTrue(model.getShortMessage().equals(model.getShortMessage())); } - for (RefModel model : JGitUtils.getTags(repository, -1)) { - if (model.getObjectId().getName().equals("283035e4848054ff1803cb0e690270787dc92399")) { + assertTrue(JGitUtils.getRemoteBranches(repository, true, 8).size() == 8); + repository.close(); + } + + @Test + public void testTags() throws Exception { + Repository repository = GitBlitSuite.getJGitRepository(); + assertTrue(JGitUtils.getTags(repository, true, 5).size() == 5); + for (RefModel model : JGitUtils.getTags(repository, true, -1)) { + if (model.getObjectId().getName().equals("d28091fb2977077471138fe97da1440e0e8ae0da")) { assertTrue("Not an annotated tag!", model.isAnnotatedTag()); } assertTrue(model.getName().startsWith(Constants.R_TAGS)); assertTrue(model.equals(model)); assertFalse(model.equals("")); - assertTrue(model.hashCode() == model.getCommitId().hashCode() + assertTrue(model.hashCode() == model.getReferencedObjectId().hashCode() + model.getName().hashCode()); - assertTrue(model.getShortLog().equals(model.commit.getShortMessage())); + } + repository.close(); + + repository = GitBlitSuite.getBluezGnomeRepository(); + for (RefModel model : JGitUtils.getTags(repository, true, -1)) { + if (model.getObjectId().getName().equals("728643ec0c438c77e182898c2f2967dbfdc231c8")) { + assertFalse(model.isAnnotatedTag()); + assertTrue(model.getAuthorIdent().getEmailAddress().equals("marcel@holtmann.org")); + assertEquals("Update changelog and bump version number\n", model.getFullMessage()); + } } repository.close(); } - public void testRetrieveRevObject() throws Exception { - Repository repository = GitBlitSuite.getHelloworldRepository(); - RevCommit commit = JGitUtils.getCommit(repository, Constants.HEAD); - RevTree tree = commit.getTree(); - RevObject object = JGitUtils.getRevObject(repository, tree, "java.java"); + @Test + public void testCommitNotes() throws Exception { + Repository repository = GitBlitSuite.getJGitRepository(); + RevCommit commit = JGitUtils.getCommit(repository, + "690c268c793bfc218982130fbfc25870f292295e"); + List<GitNote> list = JGitUtils.getNotesOnCommit(repository, commit); repository.close(); - assertTrue("Object is null!", object != null); + assertTrue(list.size() > 0); + assertEquals("183474d554e6f68478a02d9d7888b67a9338cdff", list.get(0).notesRef + .getReferencedObjectId().getName()); } - public void testRetrieveStringContent() throws Exception { - Repository repository = GitBlitSuite.getHelloworldRepository(); - RevCommit commit = JGitUtils.getCommit(repository, Constants.HEAD); - RevTree tree = commit.getTree(); - RevBlob blob = (RevBlob) JGitUtils.getRevObject(repository, tree, "java.java"); - String content = JGitUtils.getRawContentAsString(repository, blob); - repository.close(); - assertTrue("Content is null!", content != null && content.length() > 0); + @Test + public void testCreateOrphanedBranch() throws Exception { + Repository repository = JGitUtils.createRepository(GitBlitSuite.REPOSITORIES, "orphantest"); + assertTrue(JGitUtils.createOrphanBranch(repository, + "x" + Long.toHexString(System.currentTimeMillis()).toUpperCase())); + FileUtils.delete(repository.getDirectory(), FileUtils.RECURSIVE); } + @Test + public void testStringContent() throws Exception { + Repository repository = GitBlitSuite.getHelloworldRepository(); + String contentA = JGitUtils.getStringContent(repository, null, "java.java"); + RevCommit commit = JGitUtils.getCommit(repository, Constants.HEAD); + String contentB = JGitUtils.getStringContent(repository, commit.getTree(), "java.java"); + String contentC = JGitUtils.getStringContent(repository, commit.getTree(), "missing.txt"); + + // manually construct a blob, calculate the hash, lookup the hash in git + StringBuilder sb = new StringBuilder(); + sb.append("blob ").append(contentA.length()).append('\0'); + sb.append(contentA); + String sha1 = StringUtils.getSHA1(sb.toString()); + String contentD = JGitUtils.getStringContent(repository, sha1); + repository.close(); + assertTrue("ContentA is null!", contentA != null && contentA.length() > 0); + assertTrue("ContentB is null!", contentB != null && contentB.length() > 0); + assertTrue(contentA.equals(contentB)); + assertNull(contentC); + assertTrue(contentA.equals(contentD)); + } + + @Test public void testFilesInCommit() throws Exception { Repository repository = GitBlitSuite.getHelloworldRepository(); RevCommit commit = JGitUtils.getCommit(repository, "1d0c2933a4ae69c362f76797d42d6bd182d05176"); List<PathChangeModel> paths = JGitUtils.getFilesInCommit(repository, commit); + + commit = JGitUtils.getCommit(repository, "af0e9b2891fda85afc119f04a69acf7348922830"); + List<PathChangeModel> deletions = JGitUtils.getFilesInCommit(repository, commit); + + commit = JGitUtils.getFirstCommit(repository, null); + List<PathChangeModel> additions = JGitUtils.getFilesInCommit(repository, commit); + + List<PathChangeModel> latestChanges = JGitUtils.getFilesInCommit(repository, null); + repository.close(); assertTrue("No changed paths found!", paths.size() == 1); for (PathChangeModel path : paths) { @@ -169,48 +266,134 @@ assertTrue("PathChangeModel equals itself failed!", path.equals(path)); assertFalse("PathChangeModel equals string failed!", path.equals("")); } + assertEquals(ChangeType.DELETE, deletions.get(0).changeType); + assertEquals(ChangeType.ADD, additions.get(0).changeType); + assertTrue(latestChanges.size() > 0); } - public void testZip() throws Exception { + @Test + public void testFilesInPath() throws Exception { + assertEquals(0, JGitUtils.getFilesInPath(null, null, null).size()); Repository repository = GitBlitSuite.getHelloworldRepository(); - File zipFile = new File(GitBlitSuite.REPOSITORIES, "helloworld.zip"); - FileOutputStream fos = new FileOutputStream(zipFile); - boolean success = JGitUtils.zip(repository, null, Constants.HEAD, fos); - assertTrue("Failed to generate zip file!", success); - assertTrue(zipFile.length() > 0); - fos.close(); - zipFile.delete(); + List<PathModel> files = JGitUtils.getFilesInPath(repository, null, null); repository.close(); + assertTrue(files.size() > 10); } - public void testMetrics() throws Exception { - Repository repository = GitBlitSuite.getHelloworldRepository(); - List<Metric> metrics = MetricUtils.getDateMetrics(repository, true); - repository.close(); - assertTrue("No metrics found!", metrics.size() > 0); - } - - public void testTicGit() throws Exception { + @Test + public void testDocuments() throws Exception { Repository repository = GitBlitSuite.getTicgitRepository(); - RefModel branch = JGitUtils.getTicketsBranch(repository); - assertTrue("Ticgit branch does not exist!", branch != null); - List<TicketModel> ticketsA = JGitUtils.getTickets(repository); - List<TicketModel> ticketsB = JGitUtils.getTickets(repository); + List<String> extensions = GitBlit.getStrings(Keys.web.markdownExtensions); + List<PathModel> markdownDocs = JGitUtils.getDocuments(repository, extensions); + List<PathModel> markdownDocs2 = JGitUtils.getDocuments(repository, + Arrays.asList(new String[] { ".mkd", ".md" })); + List<PathModel> allFiles = JGitUtils.getDocuments(repository, null); repository.close(); - assertTrue("No tickets found!", ticketsA.size() > 0); - for (int i = 0; i < ticketsA.size(); i++) { - TicketModel ticketA = ticketsA.get(i); - TicketModel ticketB = ticketsB.get(i); - assertTrue("Tickets are not equal!", ticketA.equals(ticketB)); - assertFalse(ticketA.equals("")); - assertTrue(ticketA.hashCode() == ticketA.id.hashCode()); - for (int j = 0; j < ticketA.comments.size(); j++) { - Comment commentA = ticketA.comments.get(j); - Comment commentB = ticketB.comments.get(j); - assertTrue("Comments are not equal!", commentA.equals(commentB)); - assertFalse(commentA.equals("")); - assertTrue(commentA.hashCode() == commentA.text.hashCode()); - } - } + assertTrue(markdownDocs.size() > 0); + assertTrue(markdownDocs2.size() > 0); + assertTrue(allFiles.size() > markdownDocs.size()); } + + @Test + public void testFileModes() throws Exception { + assertEquals("drwxr-xr-x", JGitUtils.getPermissionsFromMode(FileMode.TREE.getBits())); + assertEquals("-rw-r--r--", + JGitUtils.getPermissionsFromMode(FileMode.REGULAR_FILE.getBits())); + assertEquals("-rwxr-xr-x", + JGitUtils.getPermissionsFromMode(FileMode.EXECUTABLE_FILE.getBits())); + assertEquals("symlink", JGitUtils.getPermissionsFromMode(FileMode.SYMLINK.getBits())); + assertEquals("gitlink", JGitUtils.getPermissionsFromMode(FileMode.GITLINK.getBits())); + assertEquals("missing", JGitUtils.getPermissionsFromMode(FileMode.MISSING.getBits())); + } + + @Test + public void testRevlog() throws Exception { + assertTrue(JGitUtils.getRevLog(null, 0).size() == 0); + List<RevCommit> commits = JGitUtils.getRevLog(null, 10); + assertEquals(0, commits.size()); + + Repository repository = GitBlitSuite.getHelloworldRepository(); + // get most recent 10 commits + commits = JGitUtils.getRevLog(repository, 10); + assertEquals(10, commits.size()); + + // test paging and offset by getting the 10th most recent commit + RevCommit lastCommit = JGitUtils.getRevLog(repository, null, 9, 1).get(0); + assertEquals(lastCommit, commits.get(9)); + + // grab the two most recent commits to java.java + commits = JGitUtils.getRevLog(repository, null, "java.java", 0, 2); + assertEquals(2, commits.size()); + + // grab the commits since 2008-07-15 + commits = JGitUtils.getRevLog(repository, null, + new SimpleDateFormat("yyyy-MM-dd").parse("2008-07-15")); + assertEquals(12, commits.size()); + repository.close(); + } + + @Test + public void testSearchTypes() throws Exception { + assertEquals(SearchType.COMMIT, SearchType.forName("commit")); + assertEquals(SearchType.COMMITTER, SearchType.forName("committer")); + assertEquals(SearchType.AUTHOR, SearchType.forName("author")); + assertEquals(SearchType.COMMIT, SearchType.forName("unknown")); + + assertEquals("commit", SearchType.COMMIT.toString()); + assertEquals("committer", SearchType.COMMITTER.toString()); + assertEquals("author", SearchType.AUTHOR.toString()); + } + + @Test + public void testSearchRevlogs() throws Exception { + assertEquals(0, JGitUtils.searchRevlogs(null, null, "java", SearchType.COMMIT, 0, 0).size()); + List<RevCommit> results = JGitUtils.searchRevlogs(null, null, "java", SearchType.COMMIT, 0, + 3); + assertEquals(0, results.size()); + + // test commit message search + Repository repository = GitBlitSuite.getHelloworldRepository(); + results = JGitUtils.searchRevlogs(repository, null, "java", SearchType.COMMIT, 0, 3); + assertEquals(3, results.size()); + + // test author search + results = JGitUtils.searchRevlogs(repository, null, "timothy", SearchType.AUTHOR, 0, -1); + assertEquals(1, results.size()); + + // test committer search + results = JGitUtils.searchRevlogs(repository, null, "mike", SearchType.COMMITTER, 0, 10); + assertEquals(10, results.size()); + + // test paging and offset + RevCommit commit = JGitUtils.searchRevlogs(repository, null, "mike", SearchType.COMMITTER, + 9, 1).get(0); + assertEquals(results.get(9), commit); + + repository.close(); + } + + @Test + public void testZip() throws Exception { + assertFalse(JGitUtils.zip(null, null, null, null)); + Repository repository = GitBlitSuite.getHelloworldRepository(); + File zipFileA = new File(GitBlitSuite.REPOSITORIES, "helloworld.zip"); + FileOutputStream fosA = new FileOutputStream(zipFileA); + boolean successA = JGitUtils.zip(repository, null, Constants.HEAD, fosA); + fosA.close(); + + File zipFileB = new File(GitBlitSuite.REPOSITORIES, "helloworld-java.zip"); + FileOutputStream fosB = new FileOutputStream(zipFileB); + boolean successB = JGitUtils.zip(repository, "java.java", Constants.HEAD, fosB); + fosB.close(); + + repository.close(); + assertTrue("Failed to generate zip file!", successA); + assertTrue(zipFileA.length() > 0); + zipFileA.delete(); + + assertTrue("Failed to generate zip file!", successB); + assertTrue(zipFileB.length() > 0); + zipFileB.delete(); + } + } \ No newline at end of file -- Gitblit v1.9.1