From a7a0b8ea01dca14602fdb49047d987c36461e861 Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Tue, 26 Nov 2013 16:07:04 -0500
Subject: [PATCH] Refactor access to home page class

---
 src/main/java/com/gitblit/GitBlit.java |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/main/java/com/gitblit/GitBlit.java b/src/main/java/com/gitblit/GitBlit.java
index a0e8b0a..6d52e76 100644
--- a/src/main/java/com/gitblit/GitBlit.java
+++ b/src/main/java/com/gitblit/GitBlit.java
@@ -2006,7 +2006,6 @@
 			model.description = getConfig(config, "description", "");
 			model.originRepository = getConfig(config, "originRepository", null);
 			model.addOwners(ArrayUtils.fromString(getConfig(config, "owner", "")));
-			model.useDocs = getConfig(config, "useDocs", false);
 			model.useIncrementalPushTags = getConfig(config, "useIncrementalPushTags", false);
 			model.incrementalPushTagPrefix = getConfig(config, "incrementalPushTagPrefix", null);
 			model.allowForks = getConfig(config, "allowForks", true);
@@ -2566,7 +2565,6 @@
 		config.setString(Constants.CONFIG_GITBLIT, null, "description", repository.description);
 		config.setString(Constants.CONFIG_GITBLIT, null, "originRepository", repository.originRepository);
 		config.setString(Constants.CONFIG_GITBLIT, null, "owner", ArrayUtils.toString(repository.owners));
-		config.setBoolean(Constants.CONFIG_GITBLIT, null, "useDocs", repository.useDocs);
 		config.setBoolean(Constants.CONFIG_GITBLIT, null, "useIncrementalPushTags", repository.useIncrementalPushTags);
 		if (StringUtils.isEmpty(repository.incrementalPushTagPrefix) ||
 				repository.incrementalPushTagPrefix.equals(settings.getString(Keys.git.defaultIncrementalPushTagPrefix, "r"))) {
@@ -3556,8 +3554,6 @@
 		configureFanout();
 		configureGitDaemon();
 		configureCommitCache();
-
-		ContainerUtils.CVE_2007_0450.test();
 	}
 
 	protected void configureMailExecutor() {
@@ -3776,6 +3772,10 @@
 					}
 				}
 
+				// disable Git daemon on Express - we can't bind 9418 and we
+				// can't port-forward to the daemon
+				webxmlSettings.overrideSetting(Keys.git.daemonPort, 0);
+
 				// configure context using the web.xml
 				configureContext(webxmlSettings, base, true);
 			} else {
@@ -3819,6 +3819,10 @@
 				FileSettings settings = new FileSettings(localSettings.getAbsolutePath());
 				configureContext(settings, base, true);
 			}
+
+			// WAR or Express is likely to be running on a Tomcat.
+			// Test for the forward-slash/%2F issue and auto-adjust settings.
+			ContainerUtils.CVE_2007_0450.test(settings);
 		}
 
 		settingsModel = loadSettingModels();

--
Gitblit v1.9.1