From afe3f1fd5ba22bd8b5ae017db5f61982726b656c Mon Sep 17 00:00:00 2001
From: Alfred Schmid <A.Schmid@ff-muenchen.de>
Date: Wed, 19 Feb 2014 11:04:16 -0500
Subject: [PATCH] Fixed Tests, use local copy of users.conf. Initialize reset ldap before every test.
---
src/main/java/com/gitblit/auth/LdapAuthProvider.java | 35 +++++++++++++++++++++++++++++++----
1 files changed, 31 insertions(+), 4 deletions(-)
diff --git a/src/main/java/com/gitblit/auth/LdapAuthProvider.java b/src/main/java/com/gitblit/auth/LdapAuthProvider.java
index 6a2dd43..58fb821 100644
--- a/src/main/java/com/gitblit/auth/LdapAuthProvider.java
+++ b/src/main/java/com/gitblit/auth/LdapAuthProvider.java
@@ -23,6 +23,8 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
@@ -32,8 +34,10 @@
import com.gitblit.auth.AuthenticationProvider.UsernamePasswordAuthenticationProvider;
import com.gitblit.models.TeamModel;
import com.gitblit.models.UserModel;
+import com.gitblit.service.LdapSyncService;
import com.gitblit.utils.ArrayUtils;
import com.gitblit.utils.StringUtils;
+import com.gitblit.utils.TimeUtils;
import com.unboundid.ldap.sdk.Attribute;
import com.unboundid.ldap.sdk.DereferencePolicy;
import com.unboundid.ldap.sdk.ExtendedResult;
@@ -57,7 +61,7 @@
*/
public class LdapAuthProvider extends UsernamePasswordAuthenticationProvider {
- private AtomicLong lastLdapUserSync = new AtomicLong(0L);
+ private final AtomicLong lastLdapUserSync = new AtomicLong(0L);
public LdapAuthProvider() {
super("ldap");
@@ -77,6 +81,11 @@
@Override
public void setup() {
+ synchronizeLdapUsers();
+ configureLdapSyncService();
+ }
+
+ public void synchronizeWithLdapService() {
synchronizeLdapUsers();
}
@@ -295,9 +304,7 @@
}
// create a user cookie
- if (StringUtils.isEmpty(user.cookie) && !ArrayUtils.isEmpty(password)) {
- user.cookie = StringUtils.getSHA1(user.username + new String(password));
- }
+ setCookie(user, password);
if (!supportsTeamMembershipChanges()) {
getTeamsFromLdap(ldapConnection, simpleUsername, loggingInUser, user);
@@ -521,4 +528,24 @@
}
return sb.toString();
}
+
+ private void configureLdapSyncService() {
+ logger.info("Start configuring ldap sync service");
+ LdapSyncService ldapSyncService = new LdapSyncService(settings, this);
+ if (ldapSyncService.isReady()) {
+ int mins = TimeUtils.convertFrequencyToMinutes(settings.getString(Keys.realm.ldap.synchronizeUsers.ldapSyncPeriod, "5 mins"));
+ if (mins < 5) {
+ mins = 5;
+ }
+ int delay = 1;
+ ScheduledExecutorService scheduledExecutorService = Executors.newSingleThreadScheduledExecutor();
+ scheduledExecutorService.scheduleAtFixedRate(ldapSyncService, delay, mins, TimeUnit.MINUTES);
+ logger.info("Ldap sync service will update user and groups every {} minutes.", mins);
+ logger.info("Next scheduled ldap sync is in {} minutes", delay);
+ } else {
+ logger.info("Ldap sync service is disabled.");
+ }
+ logger.info("Finished configuring ldap sync service");
+ }
+
}
--
Gitblit v1.9.1