From b75734f0600c333d70a3659af82be54caf3cfd3e Mon Sep 17 00:00:00 2001
From: James Moger <james.moger@gitblit.com>
Date: Fri, 21 Oct 2011 17:34:12 -0400
Subject: [PATCH] Revised settings RPC to be Map<String, SettingModel>.
---
src/com/gitblit/utils/RpcUtils.java | 60 ++++++++++++++++++++++++++----------------------------------
1 files changed, 26 insertions(+), 34 deletions(-)
diff --git a/src/com/gitblit/utils/RpcUtils.java b/src/com/gitblit/utils/RpcUtils.java
index eb28c0f..440dabd 100644
--- a/src/com/gitblit/utils/RpcUtils.java
+++ b/src/com/gitblit/utils/RpcUtils.java
@@ -21,15 +21,15 @@
import java.util.Collection;
import java.util.List;
import java.util.Map;
-import java.util.Properties;
import com.gitblit.Constants;
import com.gitblit.Constants.RpcRequest;
-import com.gitblit.IStoredSettings;
import com.gitblit.models.FederationModel;
import com.gitblit.models.FederationProposal;
import com.gitblit.models.FederationSet;
import com.gitblit.models.RepositoryModel;
+import com.gitblit.models.ServerStatus;
+import com.gitblit.models.SettingModel;
import com.gitblit.models.UserModel;
import com.google.gson.reflect.TypeToken;
@@ -57,6 +57,9 @@
}.getType();
private static final Type SETS_TYPE = new TypeToken<Collection<FederationSet>>() {
+ }.getType();
+
+ private static final Type SETTINGS_TYPE = new TypeToken<Map<String, SettingModel>>() {
}.getType();
/**
@@ -338,15 +341,31 @@
* @param serverUrl
* @param account
* @param password
- * @return an IStoredSettings object
+ * @return an Map<String, SettingModel> object
* @throws IOException
*/
- public static IStoredSettings getSettings(String serverUrl, String account, char[] password)
- throws IOException {
+ public static Map<String, SettingModel> getSettings(String serverUrl, String account,
+ char[] password) throws IOException {
String url = asLink(serverUrl, RpcRequest.LIST_SETTINGS);
- Properties props = JsonUtils.retrieveJson(url, Properties.class, account, password);
- RpcSettings settings = new RpcSettings(props);
+ Map<String, SettingModel> settings = JsonUtils.retrieveJson(url, SETTINGS_TYPE, account,
+ password);
return settings;
+ }
+
+ /**
+ * Retrieves the server status object.
+ *
+ * @param serverUrl
+ * @param account
+ * @param password
+ * @return an ServerStatus object
+ * @throws IOException
+ */
+ public static ServerStatus getStatus(String serverUrl, String account, char[] password)
+ throws IOException {
+ String url = asLink(serverUrl, RpcRequest.LIST_SERVER_STATUS);
+ ServerStatus status = JsonUtils.retrieveJson(url, ServerStatus.class, account, password);
+ return status;
}
/**
@@ -368,32 +387,5 @@
String json = JsonUtils.toJsonString(object);
int resultCode = JsonUtils.sendJsonString(url, json, account, password);
return resultCode == 200;
- }
-
- /**
- * Settings implementation that wraps a retrieved properties instance. This
- * class is used for RPC communication.
- *
- * @author James Moger
- *
- */
- private static class RpcSettings extends IStoredSettings {
-
- private final Properties properties = new Properties();
-
- public RpcSettings(Properties props) {
- super(RpcSettings.class);
- properties.putAll(props);
- }
-
- @Override
- protected Properties read() {
- return properties;
- }
-
- @Override
- public String toString() {
- return "RpcSettings";
- }
}
}
--
Gitblit v1.9.1