From 1670b3e1d3a46fd8b9cb691c03017956452c155e Mon Sep 17 00:00:00 2001 From: Thomas Bruederli <thomas@roundcube.net> Date: Fri, 22 Nov 2013 04:36:57 -0500 Subject: [PATCH] More improvements to list focus styles: - display focused row also when selected - background-position-x doesn't work on Firefox, use full background-position properties --- skins/classic/mail.css | 20 ++++++---- skins/classic/addressbook.css | 8 ++-- skins/larry/styles.css | 19 +++++---- skins/larry/addressbook.css | 44 +++++++++++++++------ 4 files changed, 58 insertions(+), 33 deletions(-) diff --git a/skins/classic/addressbook.css b/skins/classic/addressbook.css index db039f1..2fcb171 100644 --- a/skins/classic/addressbook.css +++ b/skins/classic/addressbook.css @@ -233,13 +233,13 @@ /* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ #contacts-table tbody tr.focused > td:first-child { - border-left: 4px solid #ddd; - padding-left: 4px; + border-left: 2px solid #d4d4d4; + padding-left: 6px; } #contacts-table tbody tr.selected.focused > td:first-child { - border-left: 0; - padding-left: 8px; + border-left: 1px solid #ccc; + padding-left: 7px; } #contacts-table .contact.readonly td diff --git a/skins/classic/mail.css b/skins/classic/mail.css index 4475fd7..e5d55e0 100644 --- a/skins/classic/mail.css +++ b/skins/classic/mail.css @@ -958,20 +958,24 @@ color: #CC0000; } -/* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ -.messagelist tbody tr.focused > td:first-child { - border-left: 6px solid #ddd; - padding-left: 3px; -} - /* This padding-left minus the focused padding left should be half of the focused border-left */ .messagelist thead tr td:first-child, -.messagelist tbody tr td:first-child, -.messagelist tbody tr.selected.focused > td:first-child { +.messagelist tbody tr td:first-child { border-left: 0; padding-left: 6px; } +/* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ +.messagelist tbody tr.focused > td:first-child { + border-left: 4px solid #d4d4d4; + padding-left: 4px; +} + +.messagelist tbody tr.selected.focused > td:first-child { + border-left: 2px solid #ccc; + padding-left: 5px; +} + .messagelist tr.selected td { color: #FFFFFF; diff --git a/skins/larry/addressbook.css b/skins/larry/addressbook.css index 43e433b..54a14da 100644 --- a/skins/larry/addressbook.css +++ b/skins/larry/addressbook.css @@ -149,8 +149,29 @@ background: url(images/listicons.png) -2px -1180px no-repeat; } +/* This padding-left should be equal to the focused border-left + the focused padding-left */ +#contacts-table thead tr td:first-child, +#contacts-table tbody tr td:first-child { + border-left: 0; + padding-left: 36px; +} + +/* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ +#contacts-table tbody tr.focused > td:first-child { + border-left: 2px solid #b0ccd7; + padding-left: 34px; +} + +#contacts-table tbody tr.selected.focused > td:first-child { + border-left-color: #9ec2d0; +} + #contacts-table .contact td.name { background-position: 6px -1603px; +} + +#contacts-table .contact.focused td.name { + background-position: 4px -1603px; } #contacts-table .contact.selected td.name, @@ -159,31 +180,28 @@ font-weight: bold; } -/* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ -#contacts-table tbody tr.focused > td:first-child { - border-left: 2px solid #b0ccd7; - padding-left: 34px; - background-position-x: 4px; -} - -/* This padding-left should be equal to the focused border-left + the focused padding-left */ -#contacts-table thead tr td:first-child, -#contacts-table tbody tr td:first-child, -#contacts-table tbody tr.selected.focused > td:first-child { - border-left: 0; - padding-left: 36px; +#contacts-table .contact.selected.focused td.name { + background-position: 4px -1627px; } #contacts-table .group td.name { background-position: 6px -1555px; } +#contacts-table .group.focused td.name { + background-position: 4px -1555px; +} + #contacts-table .group.selected td.name, #contacts-table .group.unfocused td.name { background-position: 6px -1579px; font-weight: bold; } +#contacts-table .group.selected.focused td.name { + background-position: 4px -1579px; +} + #addresslist .boxtitle { padding-right: 95px; overflow: hidden; diff --git a/skins/larry/styles.css b/skins/larry/styles.css index b19d9c7..7f2c6c0 100644 --- a/skins/larry/styles.css +++ b/skins/larry/styles.css @@ -1378,20 +1378,23 @@ background-color: #fff; } -/* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ -.records-table tbody tr.focused > td:first-child { - border-left: 4px solid #b0ccd7; - padding-left: 2px; -} - /* This padding-left minus the focused padding left should be half of the focused border-left */ .records-table thead tr td:first-child, -.records-table tbody tr td:first-child, -.records-table tbody tr.selected.focused > td:first-child { +.records-table tbody tr td:first-child { border-left: 0; padding-left: 6px; } +/* because of border-collapse, we make the left border twice what we want it to be - half will be hidden to the left */ +.records-table tbody tr.focused > td:first-child { + border-left: 2px solid #b0ccd7; + padding-left: 4px; +} + +.records-table tbody tr.selected.focused > td:first-child { + border-left-color: #49b3d2; +} + .records-table tr.selected td { color: #fff !important; background: #019bc6; -- Gitblit v1.9.1