From 1e2468e4b9e9fb44055757a5460df1a6bf31313b Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Fri, 22 Mar 2013 05:24:32 -0400 Subject: [PATCH] Added two tests for HTML comments handling in rcube_washtml class --- tests/Framework/Washtml.php | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/Framework/Washtml.php b/tests/Framework/Washtml.php index 6f4aa97..cd44326 100644 --- a/tests/Framework/Washtml.php +++ b/tests/Framework/Washtml.php @@ -18,7 +18,6 @@ .'<a href="vbscript:alert(document.cookie)">Internet Explorer</a></p>'; $washer = new rcube_washtml; - $washed = $washer->wash($html); $this->assertNotRegExp('/data:text/', $washed, "Remove data:text/html links"); @@ -33,10 +32,27 @@ $html = "<p><a href=\"\nhttp://test.com\n\">Firefox</a>"; $washer = new rcube_washtml; - $washed = $washer->wash($html); $this->assertRegExp('|href="http://test.com">|', $washed, "Link href with newlines (#1488940)"); } + /** + * Test handling HTML comments + */ + function test_comments() + { + $washer = new rcube_washtml; + + $html = "<!--[if gte mso 10]><p>p1</p><!--><p>p2</p>"; + $washed = $washer->wash($html); + + $this->assertEquals('<!-- html ignored --><!-- body ignored --><p>p2</p>', $washed, "HTML conditional comments (#1489004)"); + + $html = "<!--TestCommentInvalid><p>test</p>"; + $washed = $washer->wash($html); + + $this->assertEquals('<!-- html ignored --><!-- body ignored --><p>test</p>', $washed, "HTML invalid comments (#1487759)"); + } + } -- Gitblit v1.9.1