From 3a04a3d710e917703e03de6315858f564ebab028 Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <alec@alec.pl>
Date: Mon, 14 Apr 2014 14:44:15 -0400
Subject: [PATCH] Fix regression where title attribute for long message subjects wasn't used on IE
---
program/js/list.js | 4 +++-
program/js/app.js | 15 ++++++---------
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/program/js/app.js b/program/js/app.js
index be937c0..57b2c3c 100644
--- a/program/js/app.js
+++ b/program/js/app.js
@@ -1912,7 +1912,7 @@
// add each submitted col
for (n in this.env.coltypes) {
c = this.env.coltypes[n];
- col = { className: String(c).toLowerCase() };
+ col = {className: String(c).toLowerCase(), events:{}};
if (c == 'flag') {
css_class = (flags.flagged ? 'flagged' : 'unflagged');
@@ -1940,11 +1940,8 @@
else if (c == 'threads')
html = expando;
else if (c == 'subject') {
- if (bw.ie) {
- col.onmouseover = function() { rcube_webmail.long_subject_title_ex(this, message.depth+1); };
- if (bw.ie8)
- tree = '<span></span>' + tree; // #1487821
- }
+ if (bw.ie)
+ col.events.mouseover = function() { rcube_webmail.long_subject_title_ex(this); };
html = tree + cols[c];
}
else if (c == 'priority') {
@@ -4059,7 +4056,7 @@
li.attr('id', name)
.addClass(att.classname)
.html(att.html)
- .on('mouseover', function() { rcube_webmail.long_subject_title_ex(this, 0); });
+ .on('mouseover', function() { rcube_webmail.long_subject_title_ex(this); });
// replace indicator's li
if (upload_id && (indicator = document.getElementById(upload_id))) {
@@ -7683,7 +7680,7 @@
}
};
-rcube_webmail.long_subject_title_ex = function(elem, indent)
+rcube_webmail.long_subject_title_ex = function(elem)
{
if (!elem.title) {
var $elem = $(elem),
@@ -7695,7 +7692,7 @@
w = tmp.width();
tmp.remove();
- if (w + indent * 15 > $elem.width())
+ if (w + $('span.branch', $elem).width() * 15 > $elem.width())
elem.title = txt;
}
};
diff --git a/program/js/list.js b/program/js/list.js
index 476edae..b54b4da 100644
--- a/program/js/list.js
+++ b/program/js/list.js
@@ -300,11 +300,13 @@
if (row.className) domrow.className = row.className;
if (row.style) $.extend(domrow.style, row.style);
- for (var domcell, col, i=0; row.cols && i < row.cols.length; i++) {
+ for (var e, domcell, col, i=0; row.cols && i < row.cols.length; i++) {
col = row.cols[i];
domcell = document.createElement(this.col_tagname());
if (col.className) domcell.className = col.className;
if (col.innerHTML) domcell.innerHTML = col.innerHTML;
+ for (e in col.events)
+ domcell['on' + e] = col.events[e];
domrow.appendChild(domcell);
}
--
Gitblit v1.9.1