From 533e8602c0be3aed7becc74002c58a7d1cf400c3 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Tue, 09 Jun 2009 04:08:00 -0400 Subject: [PATCH] Add cache-buster to scripts and linked files in skin templates --- program/include/rcube_template.php | 47 ++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 38 insertions(+), 9 deletions(-) diff --git a/program/include/rcube_template.php b/program/include/rcube_template.php index 6ceb9ce..3d0e739 100755 --- a/program/include/rcube_template.php +++ b/program/include/rcube_template.php @@ -201,7 +201,9 @@ */ public function command() { - $this->js_commands[] = func_get_args(); + $cmd = func_get_args(); + if (strpos($cmd[0], 'plugin.') === false) + $this->js_commands[] = $cmd; } @@ -332,6 +334,20 @@ private function parse($name = 'main', $exit = true) { $skin_path = $this->config['skin_path']; + $plugin = false; + + $temp = explode(".", $name, 2); + if (count($temp) > 1) { + $plugin = $temp[0]; + $name = $temp[1]; + $skin_dir = $plugin . '/skins/' . $this->config['skin']; + $skin_path = $this->app->plugins->dir . $skin_dir; + if (!is_dir($skin_path)) { // fallback to default skin + $skin_dir = $plugin . '/skins/default'; + $skin_path = $this->app->plugins->dir . $skin_dir; + } + } + $path = "$skin_path/templates/$name.html"; // read template file @@ -345,6 +361,12 @@ ), true, true); return false; } + + // replace all path references to plugins/... with the configured plugins dir + // and /this/ to the current plugin skin directory + if ($plugin) { + $templ = preg_replace(array('/\bplugins\//', '/(["\']?)\/this\//'), array($this->app->plugins->url, '\\1'.$this->app->plugins->url.$skin_dir.'/'), $templ); + } // parse for specialtags $output = $this->parse_conditions($templ); @@ -352,13 +374,13 @@ // add debug console if ($this->config['debug_level'] & 8) { - $this->add_footer('<div style="position:absolute;top:5px;left:5px;width:405px;padding:2px;background:white;opacity:0.8;filter:alpha(opacity=80);z-index:9000"> + $this->add_footer('<div id="console" style="position:absolute;top:5px;left:5px;width:405px;padding:2px;background:white;z-index:9000;"> <a href="#toggle" onclick="con=document.getElementById(\'dbgconsole\');con.style.display=(con.style.display==\'none\'?\'block\':\'none\');return false">console</a> <form action="/" name="debugform" style="display:inline"><textarea name="console" id="dbgconsole" rows="20" cols="40" wrap="off" style="display:none;width:400px;border:none;font-size:x-small" spellcheck="false"></textarea></form></div>' ); } $output = $this->parse_with_globals($output); - $this->write(trim($output), $skin_path); + $this->write(trim($output)); if ($exit) { exit; } @@ -413,6 +435,7 @@ */ private function parse_with_globals($input) { + $GLOBALS['__version'] = Q(RCMAIL_VERSION); $GLOBALS['__comm_path'] = Q($this->app->comm_path); return preg_replace('/\$(__[a-z0-9_\-]+)/e', '$GLOBALS["\\1"]', $input); } @@ -496,14 +519,16 @@ '/config:([a-z0-9_]+)(:([a-z0-9_]+))?/i', '/env:([a-z0-9_]+)/i', '/request:([a-z0-9_]+)/i', - '/cookie:([a-z0-9_]+)/i' + '/cookie:([a-z0-9_]+)/i', + '/browser:([a-z0-9_]+)/i' ), array( "\$_SESSION['\\1']", "\$this->app->config->get('\\1',get_boolean('\\3'))", "\$this->env['\\1']", "get_input_value('\\1', RCUBE_INPUT_GPC)", - "\$_COOKIE['\\1']" + "\$_COOKIE['\\1']", + "\$this->browser->{'\\1'}" ), $expression); } @@ -567,6 +592,7 @@ else { $incl = file_get_contents($path); } + $incl = $this->parse_conditions($incl); return $this->parse_xml($incl); } break; @@ -655,6 +681,9 @@ break; case 'cookie': $value = htmlspecialchars($_COOKIE[$name]); + break; + case 'browser': + $value = $this->browser->{$name}; break; } @@ -745,10 +774,10 @@ if ($attrib['alt']) { $attrib['alt'] = Q(rcube_label($attrib['alt'], $attrib['domain'])); } + // set title to alt attribute for IE browsers if ($this->browser->ie && $attrib['title'] && !$attrib['alt']) { $attrib['alt'] = $attrib['title']; - unset($attrib['title']); } // add empty alt attribute for XHTML compatibility @@ -776,9 +805,9 @@ else if (in_array($attrib['command'], $a_static_commands)) { $attrib['href'] = rcmail_url($attrib['command']); } - else if ($attrib['command'] == 'permaurl' && !empty($this->env['permaurl'])) { - $attrib['href'] = $this->env['permaurl']; - } + else if ($attrib['command'] == 'permaurl' && !empty($this->env['permaurl'])) { + $attrib['href'] = $this->env['permaurl']; + } } // overwrite attributes -- Gitblit v1.9.1