From 580ff9c55e81aae04add43c95071c57e346a19ce Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Mon, 25 Jan 2010 14:05:05 -0500 Subject: [PATCH] - set svn:keywords --- program/steps/mail/attachments.inc | 36 ++++++++++++++++++++++++++---------- 1 files changed, 26 insertions(+), 10 deletions(-) diff --git a/program/steps/mail/attachments.inc b/program/steps/mail/attachments.inc index 6d58edc..d0808d0 100644 --- a/program/steps/mail/attachments.inc +++ b/program/steps/mail/attachments.inc @@ -15,7 +15,7 @@ | Author: Thomas Bruederli <roundcube@gmail.com> | +-----------------------------------------------------------------------+ - $Id: compose.inc 2081 2008-11-23 12:38:44Z thomasb $ + $Id$ */ @@ -74,27 +74,29 @@ // clear all stored output properties (like scripts and env vars) $OUTPUT->reset(); +$uploadid = get_input_value('_uploadid', RCUBE_INPUT_GET); + if (is_array($_FILES['_attachments']['tmp_name'])) { foreach ($_FILES['_attachments']['tmp_name'] as $i => $filepath) { $attachment = array( 'path' => $filepath, 'name' => $_FILES['_attachments']['name'][$i], - 'mimetype' => rc_mime_content_type($tmpfname, $_FILES['_attachments']['type'][$i]) + 'mimetype' => rc_mime_content_type($filepath, $_FILES['_attachments']['name'][$i], $_FILES['_attachments']['type'][$i]) ); $attachment = $RCMAIL->plugins->exec_hook('upload_attachment', $attachment); - if ($attachment['status']) { + + if ($attachment['status'] && !$attachment['abort']) { $id = $attachment['id']; // store new attachment in session - unset($attachment['status']); + unset($attachment['status'], $attachment['abort']); $_SESSION['compose']['attachments'][$id] = $attachment; - if (is_file($icon = $CONFIG['skin_path'] . '/images/icons/remove-attachment.png')) { + if (($icon = $_SESSION['compose']['deleteicon']) && is_file($icon)) { $button = html::img(array( 'src' => $icon, - 'alt' => rcube_label('delete'), - 'style' => "padding-right:2px;vertical-align:middle", + 'alt' => rcube_label('delete') )); } else { @@ -109,27 +111,41 @@ $content .= Q($attachment['name']); - $OUTPUT->command('add2attachment_list', "rcmfile$id", $content); + $OUTPUT->command('add2attachment_list', "rcmfile$id", array( + 'html' => $content, + 'name' => $attachment['name'], + 'mimetype' => $attachment['mimetype'], + 'complete' => true), $uploadid); } else { // upload failed $err = $_FILES['_attachments']['error'][$i]; if ($err == UPLOAD_ERR_INI_SIZE || $err == UPLOAD_ERR_FORM_SIZE) { $msg = rcube_label(array('name' => 'filesizeerror', 'vars' => array('size' => show_bytes(parse_bytes(ini_get('upload_max_filesize')))))); } + else if ($attachment['error']) { + $msg = $attachment['error']; + } else { $msg = rcube_label('fileuploaderror'); } $OUTPUT->command('display_message', $msg, 'error'); + $OUTPUT->command('remove_from_attachment_list', $uploadid); } } } else if ($_SERVER['REQUEST_METHOD'] == 'POST') { - $OUTPUT->command('display_message', rcube_label('fileuploaderror'), 'error'); + // if filesize exceeds post_max_size then $_FILES array is empty, + // show filesizeerror instead of fileuploaderror + if ($maxsize = ini_get('post_max_size')) + $msg = rcube_label(array('name' => 'filesizeerror', 'vars' => array('size' => show_bytes(parse_bytes($maxsize))))); + else + $msg = rcube_label('fileuploaderror'); + $OUTPUT->command('display_message', $msg, 'error'); + $OUTPUT->command('remove_from_attachment_list', $uploadid); } // send html page with JS calls as response -$OUTPUT->command('show_attachment_form', false); $OUTPUT->command('auto_save_start', false); $OUTPUT->send('iframe'); -- Gitblit v1.9.1