From 5b04ddd6bc9e0af5f73694371cd3988b1d5be7e8 Mon Sep 17 00:00:00 2001
From: thomascube <thomas@roundcube.net>
Date: Fri, 04 May 2012 06:06:37 -0400
Subject: [PATCH] Fix multi-threaded autocompletion when number of threads > number of sources
---
program/js/app.js | 665 ++++++++++++++++++++++++++++++-------------------------
1 files changed, 364 insertions(+), 301 deletions(-)
diff --git a/program/js/app.js b/program/js/app.js
index 120e545..487d718 100644
--- a/program/js/app.js
+++ b/program/js/app.js
@@ -54,9 +54,10 @@
// set jQuery ajax options
$.ajaxSetup({
- cache:false,
- error:function(request, status, err){ ref.http_error(request, status, err); },
- beforeSend:function(xmlhttp){ xmlhttp.setRequestHeader('X-Roundcube-Request', ref.env.request_token); }
+ cache: false,
+ timeout: this.env.request_timeout * 1000,
+ error: function(request, status, err){ ref.http_error(request, status, err); },
+ beforeSend: function(xmlhttp){ xmlhttp.setRequestHeader('X-Roundcube-Request', ref.env.request_token); }
});
// set environment variable(s)
@@ -224,15 +225,14 @@
this.env.message_commands = ['show', 'reply', 'reply-all', 'reply-list', 'forward',
'moveto', 'copy', 'delete', 'open', 'mark', 'edit', 'viewsource', 'download',
- 'print', 'load-attachment', 'load-headers', 'forward-attachment'];
+ 'print', 'load-attachment', 'show-headers', 'hide-headers', 'forward-attachment'];
if (this.env.action == 'show' || this.env.action == 'preview') {
this.enable_command(this.env.message_commands, this.env.uid);
this.enable_command('reply-list', this.env.list_post);
if (this.env.action == 'show') {
- this.http_request('pagenav', '_uid='+this.env.uid+'&_mbox='+urlencode(this.env.mailbox)
- + (this.env.search_request ? '&_search='+this.env.search_request : ''),
+ this.http_request('pagenav', {_uid: this.env.uid, _mbox: this.env.mailbox, _search: this.env.search_request},
this.display_message('', 'loading'));
}
@@ -273,7 +273,7 @@
// show printing dialog
else if (this.env.action == 'print' && this.env.uid)
if (bw.safari)
- window.setTimeout('window.print()', 10);
+ setTimeout('window.print()', 10);
else
window.print();
@@ -281,7 +281,7 @@
if (this.gui_objects.mailboxlist) {
this.env.unread_counts = {};
this.gui_objects.folderlist = this.gui_objects.mailboxlist;
- this.http_request('getunread', '');
+ this.http_request('getunread');
}
// init address book widget
@@ -300,11 +300,13 @@
// ask user to send MDN
if (this.env.mdn_request && this.env.uid) {
- var mdnurl = '_uid='+this.env.uid+'&_mbox='+urlencode(this.env.mailbox);
- if (confirm(this.get_label('mdnrequest')))
- this.http_post('sendmdn', mdnurl);
- else
- this.http_post('mark', mdnurl+'&_flag=mdnsent');
+ var postact = 'sendmdn',
+ postdata = {_uid: this.env.uid, _mbox: this.env.mailbox};
+ if (!confirm(this.get_label('mdnrequest'))) {
+ postdata._flag = 'mdnsent';
+ postact = 'mark';
+ }
+ this.http_post(postact, postdata);
}
break;
@@ -569,17 +571,14 @@
break;
case 'list':
- this.reset_qsearch();
+ if (props && props != '')
+ this.reset_qsearch();
if (this.task == 'mail') {
this.list_mailbox(props);
this.set_button_titles();
}
else if (this.task == 'addressbook')
this.list_contacts(props);
- break;
-
- case 'load-headers':
- this.load_headers(obj);
break;
case 'sort':
@@ -769,7 +768,7 @@
case 'always-load':
if (this.env.uid && this.env.sender) {
this.add_contact(urlencode(this.env.sender));
- window.setTimeout(function(){ ref.command('load-images'); }, 300);
+ setTimeout(function(){ ref.command('load-images'); }, 300);
break;
}
@@ -787,7 +786,7 @@
qstring += '&_safe=1';
this.attachment_win = window.open(this.env.comm_path+'&_action=get&'+qstring+'&_frame=1', 'rcubemailattachment');
if (this.attachment_win) {
- window.setTimeout(function(){ ref.attachment_win.focus(); }, 10);
+ setTimeout(function(){ ref.attachment_win.focus(); }, 10);
break;
}
}
@@ -857,6 +856,9 @@
url += '&_mbox='+urlencode(this.env.mailbox);
if (props)
url += '&_to='+urlencode(props);
+ // also send search request so we can go back to search result after message is sent
+ if (this.env.search_request)
+ url += '&_search='+this.env.search_request;
}
// modify url if we're in addressbook
else if (this.task == 'addressbook') {
@@ -907,19 +909,25 @@
break;
case 'savedraft':
+ var form = this.gui_objects.messageform, msgid;
+
// Reset the auto-save timer
- self.clearTimeout(this.save_timer);
+ clearTimeout(this.save_timer);
- if (!this.gui_objects.messageform)
+ // saving Drafts is disabled
+ if (!form)
break;
- // if saving Drafts is disabled in main.inc.php
- // or if compose form did not change
- if (!this.env.drafts_mailbox || this.cmp_hash == this.compose_field_hash())
+ // compose form did not change
+ if (this.cmp_hash == this.compose_field_hash()) {
+ this.auto_save_start();
break;
+ }
- var form = this.gui_objects.messageform,
- msgid = this.set_busy(true, 'savingmessage');
+ // re-set keep-alive timeout
+ this.start_keepalive();
+
+ msgid = this.set_busy(true, 'savingmessage');
form.target = "savetarget";
form._draft.value = '1';
@@ -935,7 +943,7 @@
break;
// Reset the auto-save timer
- self.clearTimeout(this.save_timer);
+ clearTimeout(this.save_timer);
// all checks passed, send message
var lang = this.spellcheck_lang(),
@@ -948,13 +956,11 @@
form.action = this.add_url(form.action, '_lang', lang);
form.submit();
- // clear timeout (sending could take longer)
- clearTimeout(this.request_timer);
break;
case 'send-attachment':
// Reset the auto-save timer
- self.clearTimeout(this.save_timer);
+ clearTimeout(this.save_timer);
this.upload_file(props || this.gui_objects.uploadform);
break;
@@ -1001,7 +1007,7 @@
if (uid = this.get_single_uid()) {
ref.printwin = window.open(this.env.comm_path+'&_action=print&_uid='+uid+'&_mbox='+urlencode(this.env.mailbox)+(this.env.safemode ? '&_safe=1' : ''));
if (this.printwin) {
- window.setTimeout(function(){ ref.printwin.focus(); }, 20);
+ setTimeout(function(){ ref.printwin.focus(); }, 20);
if (this.env.action != 'show')
this.mark_message('read', uid);
}
@@ -1012,7 +1018,7 @@
if (uid = this.get_single_uid()) {
ref.sourcewin = window.open(this.env.comm_path+'&_action=viewsource&_uid='+uid+'&_mbox='+urlencode(this.env.mailbox));
if (this.sourcewin)
- window.setTimeout(function(){ ref.sourcewin.focus(); }, 20);
+ setTimeout(function(){ ref.sourcewin.focus(); }, 20);
}
break;
@@ -1098,7 +1104,7 @@
default:
var func = command.replace(/-/g, '_');
if (this[func] && typeof this[func] === 'function') {
- ret = this[func](props);
+ ret = this[func](props, obj);
}
break;
}
@@ -1151,14 +1157,6 @@
if (this.gui_objects.editform)
this.lock_form(this.gui_objects.editform, a);
- // clear pending timer
- if (this.request_timer)
- clearTimeout(this.request_timer);
-
- // set timer for requests
- if (a && this.env.request_timeout)
- this.request_timer = window.setTimeout(function(){ ref.request_timed_out(); }, this.env.request_timeout * 1000);
-
return id;
};
@@ -1197,19 +1195,12 @@
return url.replace(/_task=[a-z]+/, '_task='+task);
};
- // called when a request timed out
- this.request_timed_out = function()
- {
- this.set_busy(false);
- this.display_message('Request timed out!', 'error');
- };
-
this.reload = function(delay)
{
if (this.is_framed())
parent.rcmail.reload(delay);
else if (delay)
- window.setTimeout(function(){ rcmail.reload(); }, delay);
+ setTimeout(function(){ rcmail.reload(); }, delay);
else if (window.location)
location.href = this.env.comm_path + (this.env.action ? '&_action='+this.env.action : '');
};
@@ -1231,8 +1222,8 @@
return url.replace(/(\?.*)$/, urldata);
}
- else
- return url + '?' + name + '=' + value;
+
+ return url + '?' + name + '=' + value;
};
this.is_framed = function()
@@ -1342,7 +1333,7 @@
this.env.last_folder_target = null;
if (this.folder_auto_timer) {
- window.clearTimeout(this.folder_auto_timer);
+ clearTimeout(this.folder_auto_timer);
this.folder_auto_timer = null;
this.folder_auto_expand = null;
}
@@ -1395,15 +1386,15 @@
// if the folder is collapsed, expand it after 1sec and restart the drag & drop process.
if (div.hasClass('collapsed')) {
if (this.folder_auto_timer)
- window.clearTimeout(this.folder_auto_timer);
+ clearTimeout(this.folder_auto_timer);
this.folder_auto_expand = this.env.mailboxes[k].id;
- this.folder_auto_timer = window.setTimeout(function() {
+ this.folder_auto_timer = setTimeout(function() {
rcmail.command('collapse-folder', rcmail.folder_auto_expand);
rcmail.drag_start(null);
}, 1000);
} else if (this.folder_auto_timer) {
- window.clearTimeout(this.folder_auto_timer);
+ clearTimeout(this.folder_auto_timer);
this.folder_auto_timer = null;
this.folder_auto_expand = null;
}
@@ -1555,7 +1546,7 @@
// start timer for message preview (wait for double click)
if (selected && this.env.contentframe && !list.multi_selecting && !this.dummy_select)
- this.preview_timer = window.setTimeout(function(){ ref.msglist_get_preview(); }, 200);
+ this.preview_timer = setTimeout(function(){ ref.msglist_get_preview(); }, 200);
else if (this.env.contentframe)
this.show_contentframe(false);
};
@@ -1572,7 +1563,7 @@
clearTimeout(this.preview_timer);
if (this.preview_read_timer)
clearTimeout(this.preview_read_timer);
- this.preview_timer = window.setTimeout(function(){ ref.msglist_get_preview(); }, 200);
+ this.preview_timer = setTimeout(function(){ ref.msglist_get_preview(); }, 200);
}
}
};
@@ -1846,8 +1837,11 @@
else if (c == 'threads')
html = expando;
else if (c == 'subject') {
- if (bw.ie)
+ if (bw.ie) {
col.onmouseover = function() { rcube_webmail.long_subject_title_ie(this, message.depth+1); };
+ if (bw.ie8)
+ tree = '<span></span>' + tree; // #1487821
+ }
html = tree + cols[c];
}
else if (c == 'priority') {
@@ -1887,7 +1881,7 @@
this.set_list_options = function(cols, sort_col, sort_order, threads)
{
- var update, add_url = '';
+ var update, post_data = {};
if (sort_col === undefined)
sort_col = this.env.sort_col;
@@ -1901,7 +1895,7 @@
if (this.env.threading != threads) {
update = 1;
- add_url += '&_threads=' + threads;
+ post_data._threads = threads;
}
if (cols && cols.length) {
@@ -1921,12 +1915,12 @@
if (newcols.join() != oldcols.join()) {
update = 1;
- add_url += '&_cols=' + newcols.join(',');
+ post_data._cols = newcols.join(',');
}
}
if (update)
- this.list_mailbox('', '', sort_col+'_'+sort_order, add_url);
+ this.list_mailbox('', '', sort_col+'_'+sort_order, post_data);
};
// when user doble-clicks on a row
@@ -1958,7 +1952,7 @@
// mark as read and change mbox unread counter
if (action == 'preview' && this.message_list && this.message_list.rows[id] && this.message_list.rows[id].unread && this.env.preview_pane_mark_read >= 0) {
- this.preview_read_timer = window.setTimeout(function() {
+ this.preview_read_timer = setTimeout(function() {
ref.set_message(id, 'unread', false);
ref.update_thread_root(id, 'read');
if (ref.env.unread_counts[ref.env.mailbox]) {
@@ -1966,7 +1960,7 @@
ref.set_unread_count(ref.env.mailbox, ref.env.unread_counts[ref.env.mailbox], ref.env.mailbox == 'INBOX');
}
if (ref.env.preview_pane_mark_read > 0)
- ref.http_post('mark', '_uid='+id+'&_flag=read&_quiet=1');
+ ref.http_post('mark', {_uid: id, _flag: 'read', _quiet: 1});
}, this.env.preview_pane_mark_read * 1000);
}
}
@@ -2029,23 +2023,23 @@
};
// list messages of a specific mailbox
- this.list_mailbox = function(mbox, page, sort, add_url)
+ this.list_mailbox = function(mbox, page, sort, url)
{
- var url = '', target = window;
+ var target = window;
+
+ if (typeof url != 'object')
+ url = {};
if (!mbox)
mbox = this.env.mailbox ? this.env.mailbox : 'INBOX';
- if (add_url)
- url += add_url;
-
// add sort to url if set
if (sort)
- url += '&_sort=' + sort;
+ url._sort = sort;
// also send search request to get the right messages
if (this.env.search_request)
- url += '&_search='+this.env.search_request;
+ url._search = this.env.search_request;
// set page=1 if changeing to another mailbox
if (this.env.mailbox != mbox) {
@@ -2058,7 +2052,7 @@
this.clear_message_list();
if (mbox != this.env.mailbox || (mbox == this.env.mailbox && !page && !sort))
- url += '&_refresh=1';
+ url._refresh = 1;
this.select_folder(mbox, '', true);
this.unmark_folder(mbox, 'recent', '', true);
@@ -2072,13 +2066,16 @@
if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) {
target = window.frames[this.env.contentframe];
- url += '&_framed=1';
+ url._framed = 1;
}
// load message list to target frame/window
if (mbox) {
this.set_busy(true, 'loading');
- this.location_href(this.env.comm_path+'&_mbox='+urlencode(mbox)+(page ? '&_page='+page : '')+url, target);
+ url._mbox = mbox;
+ if (page)
+ url._page = page;
+ this.location_href(url, target);
}
};
@@ -2093,15 +2090,20 @@
};
// send remote request to load message list
- this.list_mailbox_remote = function(mbox, page, add_url)
+ this.list_mailbox_remote = function(mbox, page, post_data)
{
// clear message list first
this.message_list.clear();
- // send request to server
- var url = '_mbox='+urlencode(mbox)+(page ? '&_page='+page : ''),
- lock = this.set_busy(true, 'loading');
- this.http_request('list', url+add_url, lock);
+ var lock = this.set_busy(true, 'loading');
+
+ if (typeof post_data != 'object')
+ post_data = {};
+ post_data._mbox = mbox;
+ if (page)
+ post_data._page = page;
+
+ this.http_request('list', post_data, lock);
};
// removes messages that doesn't exists from list selection array
@@ -2126,8 +2128,8 @@
while (new_row) {
if (new_row.nodeType == 1 && (r = this.message_list.rows[new_row.uid]) && r.unread_children) {
- this.message_list.expand_all(r);
- this.set_unread_children(r.uid);
+ this.message_list.expand_all(r);
+ this.set_unread_children(r.uid);
}
new_row = new_row.nextSibling;
}
@@ -2312,38 +2314,38 @@
row = row.obj.nextSibling;
while (row) {
if (row.nodeType == 1 && (r = rows[row.uid])) {
- if (!r.depth || r.depth <= depth)
- break;
+ if (!r.depth || r.depth <= depth)
+ break;
- r.depth--; // move left
+ r.depth--; // move left
// reset width and clear the content of a tab, icons will be added later
- $('#rcmtab'+r.uid).width(r.depth * 15).html('');
+ $('#rcmtab'+r.uid).width(r.depth * 15).html('');
if (!r.depth) { // a new root
- count++; // increase roots count
- r.parent_uid = 0;
- if (r.has_children) {
- // replace 'leaf' with 'collapsed'
- $('#rcmrow'+r.uid+' '+'.leaf:first')
+ count++; // increase roots count
+ r.parent_uid = 0;
+ if (r.has_children) {
+ // replace 'leaf' with 'collapsed'
+ $('#rcmrow'+r.uid+' '+'.leaf:first')
.attr('id', 'rcmexpando' + r.uid)
- .attr('class', (r.obj.style.display != 'none' ? 'expanded' : 'collapsed'))
- .bind('mousedown', {uid:r.uid, p:this},
- function(e) { return e.data.p.expand_message_row(e, e.data.uid); });
+ .attr('class', (r.obj.style.display != 'none' ? 'expanded' : 'collapsed'))
+ .bind('mousedown', {uid:r.uid, p:this},
+ function(e) { return e.data.p.expand_message_row(e, e.data.uid); });
- r.unread_children = 0;
- roots.push(r);
- }
- // show if it was hidden
- if (r.obj.style.display == 'none')
- $(r.obj).show();
- }
- else {
- if (r.depth == depth)
- r.parent_uid = parent;
- if (r.unread && roots.length)
- roots[roots.length-1].unread_children++;
- }
- }
- row = row.nextSibling;
+ r.unread_children = 0;
+ roots.push(r);
+ }
+ // show if it was hidden
+ if (r.obj.style.display == 'none')
+ $(r.obj).show();
+ }
+ else {
+ if (r.depth == depth)
+ r.parent_uid = parent;
+ if (r.unread && roots.length)
+ roots[roots.length-1].unread_children++;
+ }
+ }
+ row = row.nextSibling;
}
// update unread_children for roots
@@ -2362,13 +2364,13 @@
while (row) {
if (row.nodeType == 1 && (r = rows[row.uid])) {
- if (!r.depth && cnt)
- cnt--;
+ if (!r.depth && cnt)
+ cnt--;
if (!cnt)
- this.message_list.remove_row(row.uid);
- }
- row = row.nextSibling;
+ this.message_list.remove_row(row.uid);
+ }
+ row = row.nextSibling;
}
};
@@ -2494,23 +2496,23 @@
if (!mbox || mbox == this.env.mailbox || (!this.env.uid && (!this.message_list || !this.message_list.get_selection().length)))
return;
- var a_uids = [],
+ var a_uids = [], n, selection,
lock = this.display_message(this.get_label('copyingmessage'), 'loading'),
- add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : '');
+ post_data = {_mbox: this.env.mailbox, _target_mbox: mbox, _from: (this.env.action ? this.env.action : '')};
if (this.env.uid)
a_uids[0] = this.env.uid;
else {
- var selection = this.message_list.get_selection();
- for (var n in selection) {
+ selection = this.message_list.get_selection();
+ for (n in selection) {
a_uids.push(selection[n]);
}
}
- add_url += '&_uid='+this.uids_to_list(a_uids);
+ post_data._uid = this.uids_to_list(a_uids);
// send request to server
- this.http_post('copy', '_mbox='+urlencode(this.env.mailbox)+add_url, lock);
+ this.http_post('copy', post_data, lock);
};
// move selected messages to the specified mailbox
@@ -2524,19 +2526,18 @@
return;
var lock = false,
- add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : '');
+ add_post = {_target_mbox: mbox, _from: (this.env.action ? this.env.action : '')};
// show wait message
- if (this.env.action == 'show') {
+ if (this.env.action == 'show')
lock = this.set_busy(true, 'movingmessage');
- }
else
this.show_contentframe(false);
// Hide message command buttons until a message is selected
this.enable_command(this.env.message_commands, false);
- this._with_selected_messages('moveto', lock, add_url);
+ this._with_selected_messages('moveto', lock, add_post);
};
// delete selected messages from the current mailbox
@@ -2591,14 +2592,17 @@
return;
this.show_contentframe(false);
- this._with_selected_messages('delete', false, '&_from='+(this.env.action ? this.env.action : ''));
+ this._with_selected_messages('delete', false, {_from: this.env.action ? this.env.action : ''});
};
// Send a specifc moveto/delete request with UIDs of all selected messages
// @private
- this._with_selected_messages = function(action, lock, add_url)
+ this._with_selected_messages = function(action, lock, post_data)
{
- var a_uids = [], count = 0, msg;
+ var a_uids = [], count = 0, msg, lock;
+
+ if (typeof(post_data) != 'object')
+ post_data = {};
if (this.env.uid)
a_uids[0] = this.env.uid;
@@ -2630,18 +2634,19 @@
// also send search request to get the right messages
if (this.env.search_request)
- add_url += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
if (this.env.display_next && this.env.next_uid)
- add_url += '&_next_uid='+this.env.next_uid;
+ post_data._next_uid = this.env.next_uid;
if (count < 0)
- add_url += '&_count='+(count*-1);
- else if (count > 0)
- // remove threads from the end of the list
+ post_data._count = (count*-1);
+ // remove threads from the end of the list
+ else if (count > 0)
this.delete_excessive_thread_rows();
- add_url += '&_uid='+this.uids_to_list(a_uids);
+ post_data._uid = this.uids_to_list(a_uids);
+ post_data._mbox = this.env.mailbox;
if (!lock) {
msg = action == 'moveto' ? 'movingmessage' : 'deletingmessage';
@@ -2649,7 +2654,7 @@
}
// send request to server
- this.http_post(action, '_mbox='+urlencode(this.env.mailbox)+add_url, lock);
+ this.http_post(action, post_data, lock);
};
// set a specific flag to one or more messages
@@ -2708,7 +2713,7 @@
this.toggle_read_status = function(flag, a_uids)
{
var i, len = a_uids.length,
- url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag,
+ post_data = {_uid: this.uids_to_list(a_uids), _flag: flag},
lock = this.display_message(this.get_label('markingmessage'), 'loading');
// mark all message rows as read/unread
@@ -2717,9 +2722,9 @@
// also send search request to get the right messages
if (this.env.search_request)
- url += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
- this.http_post('mark', url, lock);
+ this.http_post('mark', post_data, lock);
for (i=0; i<len; i++)
this.update_thread_root(a_uids[i], flag);
@@ -2729,7 +2734,7 @@
this.toggle_flagged_status = function(flag, a_uids)
{
var i, len = a_uids.length,
- url = '_uid='+this.uids_to_list(a_uids)+'&_flag='+flag,
+ post_data = {_uid: this.uids_to_list(a_uids), _flag: flag},
lock = this.display_message(this.get_label('markingmessage'), 'loading');
// mark all message rows as flagged/unflagged
@@ -2738,9 +2743,9 @@
// also send search request to get the right messages
if (this.env.search_request)
- url += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
- this.http_post('mark', url, lock);
+ this.http_post('mark', post_data, lock);
};
// mark all message rows as deleted/undeleted
@@ -2778,7 +2783,7 @@
this.flag_as_undeleted = function(a_uids)
{
var i, len=a_uids.length,
- url = '_uid='+this.uids_to_list(a_uids)+'&_flag=undelete',
+ post_data = {_uid: this.uids_to_list(a_uids), _flag: 'undelete'},
lock = this.display_message(this.get_label('markingmessage'), 'loading');
for (i=0; i<len; i++)
@@ -2786,16 +2791,17 @@
// also send search request to get the right messages
if (this.env.search_request)
- url += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
- this.http_post('mark', url, lock);
+ this.http_post('mark', post_data, lock);
return true;
};
this.flag_as_deleted = function(a_uids)
{
- var add_url = '',
- r_uids = [],
+ var r_uids = [],
+ post_data = {_uid: this.uids_to_list(a_uids), _flag: 'delete'},
+ lock = this.display_message(this.get_label('markingmessage'), 'loading'),
rows = this.message_list ? this.message_list.rows : [],
count = 0;
@@ -2805,12 +2811,12 @@
if (rows[uid].unread)
r_uids[r_uids.length] = uid;
- if (this.env.skip_deleted) {
- count += this.update_thread(uid);
+ if (this.env.skip_deleted) {
+ count += this.update_thread(uid);
this.message_list.remove_row(uid, (this.env.display_next && i == this.message_list.selection.length-1));
- }
- else
- this.set_message(uid, 'deleted', true);
+ }
+ else
+ this.set_message(uid, 'deleted', true);
}
}
@@ -2819,29 +2825,27 @@
if(!this.env.display_next)
this.message_list.clear_selection();
if (count < 0)
- add_url += '&_count='+(count*-1);
+ post_data._count = (count*-1);
else if (count > 0)
// remove threads from the end of the list
this.delete_excessive_thread_rows();
}
- add_url = '&_from='+(this.env.action ? this.env.action : ''),
- lock = this.display_message(this.get_label('markingmessage'), 'loading');
+ if (this.env.action)
+ post_data._from = this.env.action;
// ??
if (r_uids.length)
- add_url += '&_ruid='+this.uids_to_list(r_uids);
+ post_data._ruid = this.uids_to_list(r_uids);
- if (this.env.skip_deleted) {
- if (this.env.display_next && this.env.next_uid)
- add_url += '&_next_uid='+this.env.next_uid;
- }
+ if (this.env.skip_deleted && this.env.display_next && this.env.next_uid)
+ post_data._next_uid = this.env.next_uid;
// also send search request to get the right messages
if (this.env.search_request)
- add_url += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
- this.http_post('mark', '_uid='+this.uids_to_list(a_uids)+'&_flag=delete'+add_url, lock);
+ this.http_post('mark', post_data, lock);
return true;
};
@@ -2888,24 +2892,23 @@
this.expunge_mailbox = function(mbox)
{
- var lock, url = '_mbox='+urlencode(mbox);
+ var lock, post_data = {_mbox: mbox};
// lock interface if it's the active mailbox
if (mbox == this.env.mailbox) {
lock = this.set_busy(true, 'loading');
- url += '&_reload=1';
+ post_data._reload = 1;
if (this.env.search_request)
- url += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
}
// send request to server
- this.http_post('expunge', url, lock);
+ this.http_post('expunge', post_data, lock);
};
this.purge_mailbox = function(mbox)
{
- var lock = false,
- url = '_mbox='+urlencode(mbox);
+ var lock, post_data = {_mbox: mbox};
if (!confirm(this.get_label('purgefolderconfirm')))
return false;
@@ -2913,11 +2916,11 @@
// lock interface if it's the active mailbox
if (mbox == this.env.mailbox) {
lock = this.set_busy(true, 'loading');
- url += '&_reload=1';
+ post_data._reload = 1;
}
// send request to server
- this.http_post('purge', url, lock);
+ this.http_post('purge', post_data, lock);
};
// test if purge command is allowed
@@ -3013,7 +3016,7 @@
obj[bw.ie || bw.safari || bw.chrome ? 'keydown' : 'keypress'](function(e) { return ref.ksearch_keydown(e, this, props); })
.attr('autocomplete', 'off');
};
-
+
this.compose_recipient_select = function(list)
{
this.enable_command('add-recipient', list.selection.length > 0);
@@ -3022,7 +3025,7 @@
this.compose_add_recipient = function(field)
{
var recipients = [], input = $('#_'+field);
-
+
if (this.contact_list && this.contact_list.selection.length) {
for (var id, n=0; n < this.contact_list.selection.length; n++) {
id = this.contact_list.selection[n];
@@ -3033,7 +3036,7 @@
if (id.charAt(0) == 'E' && this.env.contactdata[id].indexOf('@') < 0 && input.length) {
var gid = id.substr(1);
this.group2expand[gid] = { name:this.env.contactdata[id], input:input.get(0) };
- this.http_request('group-expand', '_source='+urlencode(this.env.source)+'&_gid='+urlencode(gid), false);
+ this.http_request('group-expand', {_source: this.env.source, _gid: gid}, false);
}
}
}
@@ -3138,7 +3141,7 @@
tinyMCE.execCommand('mceAddControl', false, props.id);
if (this.env.default_font)
- window.setTimeout(function() {
+ setTimeout(function() {
$(tinyMCE.get(props.id).getBody()).css('font-family', rcmail.env.default_font);
}, 500);
}
@@ -3237,7 +3240,7 @@
this.auto_save_start = function()
{
if (this.env.draft_autosave)
- this.save_timer = self.setTimeout(function(){ ref.command("savedraft"); }, this.env.draft_autosave * 1000);
+ this.save_timer = setTimeout(function(){ ref.command("savedraft"); }, this.env.draft_autosave * 1000);
// Unlock interface now that saving is complete
this.busy = false;
@@ -3246,20 +3249,11 @@
this.compose_field_hash = function(save)
{
// check input fields
- var ed, str = '',
- value_to = $("[name='_to']").val(),
- value_cc = $("[name='_cc']").val(),
- value_bcc = $("[name='_bcc']").val(),
- value_subject = $("[name='_subject']").val();
+ var ed, i, val, str = '', hash_fields = ['to', 'cc', 'bcc', 'subject'];
- if (value_to)
- str += value_to+':';
- if (value_cc)
- str += value_cc+':';
- if (value_bcc)
- str += value_bcc+':';
- if (value_subject)
- str += value_subject+':';
+ for (i=0; i<hash_fields.length; i++)
+ if (val = $('[name="_' + hash_fields[i] + '"]').val())
+ str += val + ':';
if (window.tinyMCE && (ed = tinyMCE.get(this.env.composebody)))
str += ed.getContent();
@@ -3522,7 +3516,7 @@
this.upload_progress_start = function(action, name)
{
- window.setTimeout(function() { rcmail.http_request(action, {_progress: name}); },
+ setTimeout(function() { rcmail.http_request(action, {_progress: name}); },
this.env.upload_progress_time * 1000);
};
@@ -3543,7 +3537,7 @@
this.add_contact = function(value)
{
if (value)
- this.http_post('addcontact', '_address='+value);
+ this.http_post('addcontact', {_address: value});
return true;
};
@@ -3552,18 +3546,23 @@
this.qsearch = function(value)
{
if (value != '') {
- var n, lock = this.set_busy(true, 'searching');
+ var r, lock = this.set_busy(true, 'searching'),
+ url = this.search_params(value);
if (this.message_list)
this.clear_message_list();
else if (this.contact_list)
this.list_contacts_clear();
+ if (this.env.source)
+ url._source = this.env.source;
+ if (this.env.group)
+ url._gid = this.env.group;
+
// reset vars
this.env.current_page = 1;
- r = this.http_request('search', this.search_params(value)
- + (this.env.source ? '&_source='+urlencode(this.env.source) : '')
- + (this.env.group ? '&_gid='+urlencode(this.env.group) : ''), lock);
+
+ r = this.http_request('search', url, lock);
this.env.qsearch = {lock: lock, request: r};
}
@@ -3572,7 +3571,7 @@
// build URL params for search
this.search_params = function(search, filter)
{
- var n, url = [], mods_arr = [],
+ var n, url = {}, mods_arr = [],
mods = this.env.search_mods,
mbox = this.env.mailbox;
@@ -3583,10 +3582,10 @@
search = this.gui_objects.qsearchbox.value;
if (filter)
- url.push('_filter=' + urlencode(filter));
+ url._filter = filter;
if (search) {
- url.push('_q='+urlencode(search));
+ url._q = search;
if (mods && this.message_list)
mods = mods[mbox] ? mods[mbox] : mods['*'];
@@ -3594,14 +3593,14 @@
if (mods) {
for (n in mods)
mods_arr.push(n);
- url.push('_headers='+mods_arr.join(','));
+ url._headers = mods_arr.join(',');
}
}
if (mbox)
- url.push('_mbox='+urlencode(mbox));
+ url._mbox = mbox;
- return url.join('&');
+ return url;
};
// reset quick-search form
@@ -3622,7 +3621,7 @@
{
this.display_message(msg, type);
// before redirect we need to wait some time for Chrome (#1486177)
- window.setTimeout(function(){ ref.list_mailbox(); }, 500);
+ setTimeout(function(){ ref.list_mailbox(); }, 500);
};
@@ -3680,11 +3679,11 @@
case 37: // left
case 39: // right
if (mod != SHIFT_KEY)
- return;
+ return;
}
// start timer
- this.ksearch_timer = window.setTimeout(function(){ ref.ksearch_get_results(props); }, 200);
+ this.ksearch_timer = setTimeout(function(){ ref.ksearch_get_results(props); }, 200);
this.ksearch_input = obj;
return true;
@@ -3729,7 +3728,7 @@
if (typeof this.env.contacts[id] === 'object' && this.env.contacts[id].id) {
insert += this.env.contacts[id].name + this.env.recipients_delimiter;
this.group2expand[this.env.contacts[id].id] = $.extend({ input: this.ksearch_input }, this.env.contacts[id]);
- this.http_request('mail/group-expand', '_source='+urlencode(this.env.contacts[id].source)+'&_gid='+urlencode(this.env.contacts[id].id), false);
+ this.http_request('mail/group-expand', {_source: this.env.contacts[id].source, _gid: this.env.contacts[id].id}, false);
}
else if (typeof this.env.contacts[id] === 'string') {
insert = this.env.contacts[id] + this.env.recipients_delimiter;
@@ -3803,6 +3802,7 @@
return;
var i, lock, source, xhr, reqid = new Date().getTime(),
+ post_data = {_search: q, _id: reqid},
threads = props && props.threads ? props.threads : 1,
sources = props && props.sources ? props.sources : [],
action = props && props.action ? props.action : 'mail/autocomplete';
@@ -3812,12 +3812,12 @@
for (i=0; i<threads; i++) {
source = this.ksearch_data.sources.shift();
- if (threads > 1 && source === null)
+ if (threads > 1 && source === undefined)
break;
+ post_data._source = source ? source : '';
lock = this.display_message(this.get_label('searching'), 'loading');
- xhr = this.http_post(action, '_search='+urlencode(q)+'&_id='+reqid
- + (source ? '&_source='+urlencode(source) : ''), lock);
+ xhr = this.http_post(action, post_data, lock);
this.ksearch_data.locks.push(lock);
this.ksearch_data.requests.push(xhr);
@@ -3895,11 +3895,11 @@
if (data.id == reqid) {
data.num--;
if (maxlen > 0 && data.sources.length) {
- var lock, xhr, source = data.sources.shift();
+ var lock, xhr, source = data.sources.shift(), post_data;
if (source) {
+ post_data = {_search: value, _id: reqid, _source: source};
lock = this.display_message(this.get_label('searching'), 'loading');
- xhr = this.http_post(data.action, '_search='+urlencode(value)+'&_id='+reqid
- +'&_source='+urlencode(source), lock);
+ xhr = this.http_post(data.action, post_data, lock);
this.ksearch_data.locks.push(lock);
this.ksearch_data.requests.push(xhr);
@@ -3991,7 +3991,7 @@
source = this.env.source ? this.env.address_sources[this.env.source] : null;
if (id = list.get_single_selection())
- this.preview_timer = window.setTimeout(function(){ ref.load_contact(id, 'show'); }, 200);
+ this.preview_timer = setTimeout(function(){ ref.load_contact(id, 'show'); }, 200);
else if (this.env.contentframe)
this.show_contentframe(false);
@@ -4012,6 +4012,10 @@
}
}
+ // if a group is currently selected, and there is at least one contact selected
+ // thend we can enable the group-remove-selected command
+ this.enable_command('group-remove-selected', typeof this.env.group != 'undefined' && list.selection.length > 0);
+
this.enable_command('compose', this.env.group || list.selection.length > 0);
this.enable_command('edit', id && writable);
this.enable_command('delete', list.selection.length && writable);
@@ -4021,7 +4025,7 @@
this.list_contacts = function(src, group, page)
{
- var folder, add_url = '',
+ var folder, url = {},
target = window;
if (!src)
@@ -4055,20 +4059,22 @@
if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) {
target = window.frames[this.env.contentframe];
- add_url = '&_framed=1';
+ url._framed = 1;
}
if (group)
- add_url += '&_gid='+group;
+ url._gid = group;
if (page)
- add_url += '&_page='+page;
+ url._page = page;
+ if (src)
+ url._source = src;
// also send search request to get the correct listing
if (this.env.search_request)
- add_url += '&_search='+this.env.search_request;
+ url._search = this.env.search_request;
this.set_busy(true, 'loading');
- this.location_href(this.env.comm_path + (src ? '&_source='+urlencode(src) : '') + add_url, target);
+ this.location_href(url, target);
};
// send remote request to load contacts list
@@ -4078,18 +4084,21 @@
this.list_contacts_clear();
// send request to server
- var url = (src ? '_source='+urlencode(src) : '') + (page ? (src?'&':'') + '_page='+page : ''),
- lock = this.set_busy(true, 'loading');
+ var url = {}, lock = this.set_busy(true, 'loading');
+
+ if (src)
+ url._source = src;
+ if (page)
+ url._page = page;
+ if (group)
+ url._gid = group;
this.env.source = src;
this.env.group = group;
- if (group)
- url += '&_gid='+group;
-
// also send search request to get the right messages
if (this.env.search_request)
- url += '&_search='+this.env.search_request;
+ url._search = this.env.search_request;
this.http_request(this.env.task == 'mail' ? 'list-contacts' : 'list', url, lock);
};
@@ -4105,10 +4114,10 @@
// load contact record
this.load_contact = function(cid, action, framed)
{
- var add_url = '', target = window;
+ var url = {}, target = window;
if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) {
- add_url = '&_framed=1';
+ url._framed = 1;
target = window.frames[this.env.contentframe];
this.show_contentframe(true);
@@ -4124,12 +4133,15 @@
if (action && (cid || action=='add') && !this.drag_active) {
if (this.env.group)
- add_url += '&_gid='+urlencode(this.env.group);
+ url._gid = this.env.group;
- this.location_href(this.env.comm_path+'&_action='+action
- +'&_source='+urlencode(this.env.source)
- +'&_cid='+urlencode(cid) + add_url, target, true);
+ url._action = action;
+ url._source = this.env.source;
+ url._cid = cid;
+
+ this.location_href(url, target, true);
}
+
return true;
};
@@ -4137,11 +4149,11 @@
this.group_member_change = function(what, cid, source, gid)
{
what = what == 'add' ? 'add' : 'del';
- var lock = this.display_message(this.get_label(what == 'add' ? 'addingmember' : 'removingmember'), 'loading');
+ var label = this.get_label(what == 'add' ? 'addingmember' : 'removingmember'),
+ lock = this.display_message(label, 'loading'),
+ post_data = {_cid: cid, _source: source, _gid: gid};
- this.http_post('group-'+what+'members', '_cid='+urlencode(cid)
- + '&_source='+urlencode(source)
- + '&_gid='+urlencode(gid), lock);
+ this.http_post('group-'+what+'members', post_data, lock);
};
// copy a contact to the specified target (group or directory)
@@ -4153,19 +4165,18 @@
if (to.type == 'group' && to.source == this.env.source)
this.group_member_change('add', cid, to.source, to.id);
else if (to.type == 'group' && !this.env.address_sources[to.source].readonly) {
- var lock = this.display_message(this.get_label('copyingcontact'), 'loading');
- this.http_post('copy', '_cid='+urlencode(cid)
- + '&_source='+urlencode(this.env.source)
- + '&_to='+urlencode(to.source)
- + '&_togid='+urlencode(to.id)
- + (this.env.group ? '&_gid='+urlencode(this.env.group) : ''), lock);
+ var lock = this.display_message(this.get_label('copyingcontact'), 'loading'),
+ post_data = {_cid: cid, _source: this.env.source, _to: to.source, _togid: to.id,
+ _gid: (this.env.group ? this.env.group : '')};
+
+ this.http_post('copy', post_data, lock);
}
else if (to.id != this.env.source && cid && this.env.address_sources[to.id] && !this.env.address_sources[to.id].readonly) {
- var lock = this.display_message(this.get_label('copyingcontact'), 'loading');
- this.http_post('copy', '_cid='+urlencode(cid)
- + '&_source='+urlencode(this.env.source)
- + '&_to='+urlencode(to.id)
- + (this.env.group ? '&_gid='+urlencode(this.env.group) : ''), lock);
+ var lock = this.display_message(this.get_label('copyingcontact'), 'loading'),
+ post_data = {_cid: cid, _source: this.env.source, _to: to.id,
+ _gid: (this.env.group ? this.env.group : '')};
+
+ this.http_post('copy', post_data, lock);
}
};
@@ -4178,7 +4189,9 @@
if (!(selection.length || this.env.cid) || (!undelete && !confirm(this.get_label('deletecontactconfirm'))))
return;
- var id, n, a_cids = [], qs = '';
+ var id, n, a_cids = [],
+ post_data = {_source: this.env.source, _from: (this.env.action ? this.env.action : '')},
+ lock = this.display_message(this.get_label('contactdeleting'), 'loading');
if (this.env.cid)
a_cids.push(this.env.cid);
@@ -4194,18 +4207,17 @@
this.show_contentframe(false);
}
+ post_data._cid = a_cids.join(',');
+
if (this.env.group)
- qs += '&_gid='+urlencode(this.env.group);
+ post_data._gid = this.env.group;
// also send search request to get the right records from the next page
if (this.env.search_request)
- qs += '&_search='+this.env.search_request;
+ post_data._search = this.env.search_request;
// send request to server
- this.http_post('delete', '_cid='+urlencode(a_cids.join(','))
- +'&_source='+urlencode(this.env.source)
- +'&_from='+(this.env.action ? this.env.action : '')+qs,
- this.display_message(this.get_label('contactdeleting'), 'loading'));
+ this.http_post('delete', post_data, lock)
return true;
};
@@ -4334,7 +4346,7 @@
{
if (this.env.group && confirm(this.get_label('deletegroupconfirm'))) {
var lock = this.set_busy(true, 'groupdeleting');
- this.http_post('group-delete', '_source='+urlencode(this.env.source)+'&_gid='+urlencode(this.env.group), lock);
+ this.http_post('group-delete', {_source: this.env.source, _gid: this.env.group}, lock);
}
};
@@ -4371,6 +4383,25 @@
this.name_input.select().focus();
};
+ //remove selected contacts from current active group
+ this.group_remove_selected = function()
+ {
+ ref.http_post('group-delmembers', {_cid: this.contact_list.selection,
+ _source: this.env.source, _gid: this.env.group});
+ };
+
+ //callback after deleting contact(s) from current group
+ this.remove_group_contacts = function(props)
+ {
+ if('undefined' != typeof this.env.group && (this.env.group === props.gid)){
+ var n, selection = this.contact_list.get_selection();
+ for (n=0; n<selection.length; n++) {
+ id = selection[n];
+ this.contact_list.remove_row(id, (n == selection.length-1));
+ }
+ }
+ }
+
// handler for keyboard events on the input field
this.add_input_keydown = function(e)
{
@@ -4385,11 +4416,11 @@
var lock = this.set_busy(true, 'loading');
if (itype == 'contactsearch')
- this.http_post('search-create', '_search='+urlencode(this.env.search_request)+'&_name='+urlencode(newname), lock);
+ this.http_post('search-create', {_search: this.env.search_request, _name: newname}, lock);
else if (this.env.group_renaming)
- this.http_post('group-rename', '_source='+urlencode(this.env.source)+'&_gid='+urlencode(this.env.group)+'&_name='+urlencode(newname), lock);
+ this.http_post('group-rename', {_source: this.env.source, _gid: this.env.group, _name: newname}, lock);
else
- this.http_post('group-create', '_source='+urlencode(this.env.source)+'&_name='+urlencode(newname), lock);
+ this.http_post('group-create', {_source: this.env.source, _name: newname}, lock);
}
return false;
}
@@ -4515,10 +4546,13 @@
this.init_edit_field = function(col, elem)
{
+ var label = this.env.coltypes[col].label;
+
if (!elem)
elem = $('.ff_' + col);
- elem.placeholder(ref.env.coltypes[col].label);
+ if (label)
+ elem.placeholder(label);
};
this.insert_edit_field = function(col, section, menu)
@@ -4533,8 +4567,15 @@
var lastelem = $('.ff_'+col),
appendcontainer = $('#contactsection'+section+' .contactcontroller'+col);
- if (!appendcontainer.length)
- appendcontainer = $('<fieldset>').addClass('contactfieldgroup contactcontroller'+col).insertAfter($('#contactsection'+section+' .contactfieldgroup').last());
+ if (!appendcontainer.length) {
+ var sect = $('#contactsection'+section),
+ lastgroup = $('.contactfieldgroup', sect).last();
+ appendcontainer = $('<fieldset>').addClass('contactfieldgroup contactcontroller'+col);
+ if (lastgroup.length)
+ appendcontainer.insertAfter(lastgroup);
+ else
+ sect.prepend(appendcontainer);
+ }
if (appendcontainer.length && appendcontainer.get(0).nodeName == 'FIELDSET') {
var input, colprop = this.env.coltypes[col],
@@ -4558,6 +4599,14 @@
if (colprop.type == 'date' && $.datepicker)
input.datepicker();
+ }
+ else if (colprop.type == 'textarea') {
+ input = $('<textarea>')
+ .addClass('ff_'+col)
+ .attr({ name: '_'+col+name_suffix, cols:colprop.size, rows:colprop.rows })
+ .appendTo(cell);
+
+ this.init_edit_field(col, input);
}
else if (colprop.type == 'composite') {
var childcol, cp, first, templ, cols = [], suffices = [];
@@ -4687,15 +4736,15 @@
// load advanced search page
this.advanced_search = function()
{
- var add_url = '&_form=1', target = window;
+ var url = {_form: 1, _action: 'search'}, target = window;
if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) {
- add_url += '&_framed=1';
+ url._framed = 1;
target = window.frames[this.env.contentframe];
this.contact_list.clear_selection();
}
- this.location_href(this.env.comm_path+'&_action=search'+add_url, target, true);
+ this.location_href(url, target, true);
return true;
};
@@ -4768,7 +4817,7 @@
{
if (this.env.search_request) {
var lock = this.set_busy(true, 'savedsearchdeleting');
- this.http_post('search-delete', '_sid='+urlencode(this.env.search_id), lock);
+ this.http_post('search-delete', {_sid: this.env.search_id}, lock);
}
};
@@ -4802,7 +4851,7 @@
// reset vars
this.env.current_page = 1;
- this.http_request('search', '_sid='+urlencode(id), lock);
+ this.http_request('search', {_sid: id}, lock);
};
@@ -4813,14 +4862,15 @@
// preferences section select and load options frame
this.section_select = function(list)
{
- var id = list.get_single_selection(), add_url = '', target = window;
+ var id = list.get_single_selection(), target = window,
+ url = {_action: 'edit-prefs', _section: id};
if (id) {
if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) {
- add_url = '&_framed=1';
+ url._framed = 1;
target = window.frames[this.env.contentframe];
}
- this.location_href(this.env.comm_path+'&_action=edit-prefs&_section='+id+add_url, target, true);
+ this.location_href(url, target, true);
}
return true;
@@ -4841,17 +4891,18 @@
if (action == 'edit-identity' && (!id || id == this.env.iid))
return false;
- var add_url = '', target = window;
+ var target = window,
+ url = {_action: action, _iid: id};
if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) {
- add_url = '&_framed=1';
+ url._framed = 1;
target = window.frames[this.env.contentframe];
document.getElementById(this.env.contentframe).style.visibility = 'inherit';
}
if (action && (id || action == 'add-identity')) {
this.set_busy(true);
- this.location_href(this.env.comm_path+'&_action='+action+'&_iid='+id+add_url, target);
+ this.location_href(url, target);
}
return true;
@@ -4976,7 +5027,7 @@
newname = this.env.dstfolder === '' ? basename : this.env.dstfolder+this.env.delimiter+basename;
if (newname != this.env.mailbox) {
- this.http_post('rename-folder', '_folder_oldname='+urlencode(this.env.mailbox)+'&_folder_newname='+urlencode(newname), this.set_busy(true, 'foldermoving'));
+ this.http_post('rename-folder', {_folder_oldname: this.env.mailbox, _folder_newname: newname}, this.set_busy(true, 'foldermoving'));
this.subscription_list.draglayer.hide();
}
}
@@ -4998,7 +5049,7 @@
if (folder && confirm(this.get_label('deletefolderconfirm'))) {
var lock = this.set_busy(true, 'folderdeleting');
- this.http_post('delete-folder', '_mbox='+urlencode(folder), lock);
+ this.http_post('delete-folder', {_mbox: folder}, lock);
}
};
@@ -5196,7 +5247,7 @@
{
if (folder) {
var lock = this.display_message(this.get_label('foldersubscribing'), 'loading');
- this.http_post('subscribe', '_mbox='+urlencode(folder), lock);
+ this.http_post('subscribe', {_mbox: folder}, lock);
}
};
@@ -5204,7 +5255,7 @@
{
if (folder) {
var lock = this.display_message(this.get_label('folderunsubscribing'), 'loading');
- this.http_post('unsubscribe', '_mbox='+urlencode(folder), lock);
+ this.http_post('unsubscribe', {_mbox: folder}, lock);
}
};
@@ -5233,12 +5284,10 @@
url += '&_framed=1';
}
- if (String(target.location.href).indexOf(url) >= 0 && !force) {
+ if (String(target.location.href).indexOf(url) >= 0 && !force)
this.show_contentframe(true);
- }
- else {
+ else
this.location_href(this.env.comm_path+url, target, true);
- }
};
// disables subscription checkbox (for protected folder)
@@ -5252,7 +5301,7 @@
this.folder_size = function(folder)
{
var lock = this.set_busy(true, 'loading');
- this.http_post('folder-size', '_mbox='+urlencode(folder), lock);
+ this.http_post('folder-size', {_mbox: folder}, lock);
};
this.folder_size_update = function(size)
@@ -5327,7 +5376,7 @@
obj = document.getElementById(button.id);
// get default/passive setting of the button
- if (obj && button.type=='image' && !button.status) {
+ if (obj && button.type == 'image' && !button.status) {
button.pas = obj._original_src ? obj._original_src : obj.src;
// respect PNG fix on IE browsers
if (obj.runtimeStyle && obj.runtimeStyle.filter && obj.runtimeStyle.filter.match(/src=['"]([^'"]+)['"]/))
@@ -5337,7 +5386,7 @@
button.pas = String(obj.className);
// set image according to button state
- if (obj && button.type=='image' && button[state]) {
+ if (obj && button.type == 'image' && button[state]) {
button.status = state;
obj.src = button[state];
}
@@ -5484,7 +5533,7 @@
}
// add element and set timeout
this.messages[key].elements.push(id);
- window.setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
+ setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
return id;
}
@@ -5504,7 +5553,7 @@
this.triggerEvent('message', { message:msg, type:type, timeout:timeout, object:obj });
if (timeout > 0)
- window.setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
+ setTimeout(function() { ref.hide_message(id, type == 'loading'); }, timeout);
return id;
};
@@ -5784,31 +5833,31 @@
};
// display all-headers row and fetch raw message headers
- this.load_headers = function(elem)
+ this.show_headers = function(props, elem)
{
if (!this.gui_objects.all_headers_row || !this.gui_objects.all_headers_box || !this.env.uid)
return;
$(elem).removeClass('show-headers').addClass('hide-headers');
$(this.gui_objects.all_headers_row).show();
- elem.onclick = function() { rcmail.hide_headers(elem); };
+ elem.onclick = function() { rcmail.command('hide-headers', '', elem); };
// fetch headers only once
if (!this.gui_objects.all_headers_box.innerHTML) {
var lock = this.display_message(this.get_label('loading'), 'loading');
- this.http_post('headers', '_uid='+this.env.uid, lock);
+ this.http_post('headers', {_uid: this.env.uid}, lock);
}
};
// hide all-headers row
- this.hide_headers = function(elem)
+ this.hide_headers = function(props, elem)
{
if (!this.gui_objects.all_headers_row || !this.gui_objects.all_headers_box)
return;
$(elem).removeClass('hide-headers').addClass('show-headers');
$(this.gui_objects.all_headers_row).hide();
- elem.onclick = function() { rcmail.load_headers(elem); };
+ elem.onclick = function() { rcmail.command('show-headers', '', elem); };
};
@@ -5860,7 +5909,7 @@
else
query._action = this.env.action;
- var base = this.env.comm_path;
+ var base = this.env.comm_path, k, param = {};
// overwrite task name
if (query._action.match(/([a-z]+)\/([a-z0-9-_.]+)/)) {
@@ -5869,8 +5918,7 @@
}
// remove undefined values
- var param = {};
- for (var k in query) {
+ for (k in query) {
if (query[k] !== undefined && query[k] !== null)
param[k] = query[k];
}
@@ -5898,6 +5946,9 @@
{
if (frame)
this.lock_frame();
+
+ if (typeof url == 'object')
+ url = this.env.comm_path + '&' + $.param(url);
// simulate real link click to force IE to send referer header
if (bw.ie && target == window)
@@ -5930,7 +5981,7 @@
return $.ajax({
type: 'GET', url: url, data: { _unlock:(lock?lock:0) }, dataType: 'json',
success: function(data){ ref.http_response(data); },
- error: function(o, status, err) { rcmail.http_error(o, status, err, lock); }
+ error: function(o, status, err) { ref.http_error(o, status, err, lock, action); }
});
};
@@ -5962,7 +6013,7 @@
return $.ajax({
type: 'POST', url: url, data: postdata, dataType: 'json',
success: function(data){ ref.http_response(data); },
- error: function(o, status, err) { rcmail.http_error(o, status, err, lock); }
+ error: function(o, status, err) { ref.http_error(o, status, err, lock, action); }
});
};
@@ -6094,7 +6145,7 @@
};
// handle HTTP request errors
- this.http_error = function(request, status, err, lock)
+ this.http_error = function(request, status, err, lock, action)
{
var errmsg = request.statusText;
@@ -6103,6 +6154,16 @@
if (request.status && errmsg)
this.display_message(this.get_label('servererror') + ' (' + errmsg + ')', 'error');
+ else if (status == 'timeout')
+ this.display_message(this.get_label('requesttimedout'), 'error');
+ else if (request.status == 0 && status != 'abort')
+ this.display_message(this.get_label('servererror') + ' (No connection)', 'error');
+
+ // re-send keep-alive requests after 30 seconds
+ if (action == 'keep-alive')
+ setTimeout(function(){ ref.keep_alive(); }, 30000);
+ else if (action == 'check-recent')
+ setTimeout(function(){ ref.check_for_recent(false); }, 30000);
};
// post the given form to a hidden iframe
@@ -6156,12 +6217,15 @@
// starts interval for keep-alive/check-recent signal
this.start_keepalive = function()
{
+ if (!this.env.keep_alive || this.env.framed)
+ return;
+
if (this._int)
clearInterval(this._int);
- if (this.env.keep_alive && !this.env.framed && this.task == 'mail' && this.gui_objects.mailboxlist)
+ if (this.task == 'mail' && this.gui_objects.mailboxlist)
this._int = setInterval(function(){ ref.check_for_recent(false); }, this.env.keep_alive * 1000);
- else if (this.env.keep_alive && !this.env.framed && this.task != 'login' && this.env.action != 'print')
+ else if (this.task != 'login' && this.env.action != 'print')
this._int = setInterval(function(){ ref.keep_alive(); }, this.env.keep_alive * 1000);
};
@@ -6178,23 +6242,23 @@
if (this.busy)
return;
- var lock, addurl = '_mbox=' + urlencode(this.env.mailbox);
+ var lock, url = {_mbox: this.env.mailbox};
if (refresh) {
lock = this.set_busy(true, 'checkingmail');
- addurl += '&_refresh=1';
+ url._refresh = 1;
// reset check-recent interval
this.start_keepalive();
}
if (this.gui_objects.messagelist)
- addurl += '&_list=1';
+ url._list = 1;
if (this.gui_objects.quotadisplay)
- addurl += '&_quota=1';
+ url._quota = 1;
if (this.env.search_request)
- addurl += '&_search=' + this.env.search_request;
+ url._search = this.env.search_request;
- this.http_request('check-recent', addurl, lock);
+ this.http_request('check-recent', url, lock);
};
@@ -6222,7 +6286,7 @@
return obj.selectionEnd;
else if (document.selection && document.selection.createRange) {
var range = document.selection.createRange();
- if (range.parentElement()!=obj)
+ if (range.parentElement() != obj)
return 0;
var gm = range.duplicate();
@@ -6340,4 +6404,3 @@
rcube_webmail.prototype.addEventListener = rcube_event_engine.prototype.addEventListener;
rcube_webmail.prototype.removeEventListener = rcube_event_engine.prototype.removeEventListener;
rcube_webmail.prototype.triggerEvent = rcube_event_engine.prototype.triggerEvent;
-
--
Gitblit v1.9.1