From 5f660cd7c4662c30921b76b04a7b9d92e82182df Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Thu, 02 Oct 2008 04:39:49 -0400 Subject: [PATCH] - Minimize "inline" javascript use (#1485433) --- skins/default/templates/settings.html | 16 +++------------- 1 files changed, 3 insertions(+), 13 deletions(-) diff --git a/skins/default/templates/settings.html b/skins/default/templates/settings.html index 0bc0f18..f30d093 100644 --- a/skins/default/templates/settings.html +++ b/skins/default/templates/settings.html @@ -4,17 +4,9 @@ <title><roundcube:object name="pagetitle" /></title> <roundcube:include file="/includes/links.html" /> <link rel="stylesheet" type="text/css" href="/settings.css" /> -<script type="text/javascript"> -function show_adv(box) -{ - var rows = document.getElementsByTagName('TR'); - for(var i=0; i<rows.length; i++) - if(rows[i].className && rows[i].className.match(/advanced/)) - rows[i].style.display = box.checked ? (bw.ie ? 'block' : 'table-row') : 'none'; -} -</script> +<script type="text/javascript" src="/functions.js"></script> </head> -<body> +<body onload="rcube_init_settings_tabs()"> <roundcube:include file="/includes/taskbar.html" /> <roundcube:include file="/includes/header.html" /> @@ -34,10 +26,8 @@ <div class="advswitch"> <label for="advswitch"><roundcube:label name="advancedoptions"><label> -<input type="checkbox" id="advswitch" name="_advanced" value="0" onclick="show_adv(this)" /> +<input type="checkbox" id="advswitch" name="_advanced" value="0" onclick="rcube_show_advanced(this.checked)" /> </div> - -<roundcube:include file="/includes/settingscripts.html" /> </body> </html> -- Gitblit v1.9.1