From 7a5c48e7f70b8bc938fcae3ffd2be0fdbeaab145 Mon Sep 17 00:00:00 2001
From: thomascube <thomas@roundcube.net>
Date: Wed, 13 Dec 2006 02:17:24 -0500
Subject: [PATCH] Changed 'junk' label in French localization
---
program/include/rcube_smtp.inc | 61 ++++++++++++++++++------------
1 files changed, 36 insertions(+), 25 deletions(-)
diff --git a/program/include/rcube_smtp.inc b/program/include/rcube_smtp.inc
index 56a4e98..6953e26 100644
--- a/program/include/rcube_smtp.inc
+++ b/program/include/rcube_smtp.inc
@@ -49,9 +49,9 @@
* @return bool Returns TRUE on success, or FALSE on error
* @access public
*/
-function smtp_mail($from, $recipients, $headers, &$body)
+function smtp_mail($from, $recipients, &$headers, &$body, &$response)
{
- global $SMTP_CONN, $CONFIG, $SMTP_ERROR;
+ global $SMTP_CONN, $CONFIG;
$smtp_timeout = null;
$smtp_host = $CONFIG['smtp_server'];
$smtp_port = is_numeric($CONFIG['smtp_port']) ? $CONFIG['smtp_port'] : 25;
@@ -81,10 +81,11 @@
// try to connect to server and exit on failure
- if (PEAR::isError($SMTP_CONN->connect($smtp_timeout)))
+ $result = $SMTP_CONN->connect($smtp_timeout);
+ if (PEAR::isError($result))
{
$SMTP_CONN = null;
- $SMTP_ERROR .= "Connection failed\n";
+ $response[] = "Connection failed: ".$result->getMessage();
return FALSE;
}
@@ -92,21 +93,22 @@
if ($CONFIG['smtp_user'] && $CONFIG['smtp_pass'])
{
if (strstr($CONFIG['smtp_user'], '%u'))
- $smtp_user = str_replace('%u', $_SESSION['username'], $CONFIG['smtp_user']);
+ $smtp_user = str_replace('%u', $_SESSION['username'], $CONFIG['smtp_user']);
else
- $smtp_user = $CONFIG['smtp_user'];
+ $smtp_user = $CONFIG['smtp_user'];
- if (strstr($CONFIG['smtp_pass'], '%p'))
- $smtp_pass = str_replace('%p', decrypt_passwd($_SESSION['password']), $CONFIG['smtp_pass']);
+ if (strstr($CONFIG['smtp_pass'], '%p'))
+ $smtp_pass = str_replace('%p', decrypt_passwd($_SESSION['password']), $CONFIG['smtp_pass']);
else
- $smtp_pass = $CONFIG['smtp_pass'];
+ $smtp_pass = $CONFIG['smtp_pass'];
- $smtp_auth_type = empty($CONFIG['smtp_auth_type']) ? NULL : $CONFIG['smtp_auth_type'];
-
- if (PEAR::isError($SMTP_CONN->auth($smtp_user, $smtp_pass, $smtp_auth_type)))
+ $smtp_auth_type = empty($CONFIG['smtp_auth_type']) ? NULL : $CONFIG['smtp_auth_type'];
+ $result = $SMTP_CONN->auth($smtp_user, $smtp_pass, $smtp_auth_type);
+
+ if (PEAR::isError($result))
{
smtp_reset();
- $SMTP_ERROR .= "authentication failure\n";
+ $response[] .= "Authentication failure: ".$result->getMessage();
return FALSE;
}
}
@@ -130,7 +132,7 @@
else
{
smtp_reset();
- $SMTP_ERROR .= "Invalid message headers\n";
+ $response[] .= "Invalid message headers";
return FALSE;
}
@@ -138,7 +140,7 @@
if (!isset($from))
{
smtp_reset();
- $SMTP_ERROR .= "No From address has been provided\n";
+ $response[] .= "No From address has been provided";
return FALSE;
}
@@ -147,7 +149,7 @@
if (PEAR::isError($SMTP_CONN->mailFrom($from)))
{
smtp_reset();
- $SMTP_ERROR .= "Failed to set sender '$from'\n";
+ $response[] .= "Failed to set sender '$from'";
return FALSE;
}
@@ -167,21 +169,30 @@
if (PEAR::isError($SMTP_CONN->rcptTo($recipient)))
{
smtp_reset();
- $SMTP_ERROR .= "Failed to add recipient '$recipient'\n";
+ $response[] .= "Failed to add recipient '$recipient'";
return FALSE;
}
}
+ // Concatenate headers and body so it can be passed by reference to SMTP_CONN->data
+ // so preg_replace in SMTP_CONN->quotedata will store a reference instead of a copy.
+ // We are still forced to make another copy here for a couple ticks so we don't really
+ // get to save a copy in the method call.
+ $data = $text_headers . "\r\n" . $body;
+
+ // unset old vars to save data and so we can pass into SMTP_CONN->data by reference.
+ unset($text_headers, $body);
+
// Send the message's headers and the body as SMTP data.
- if (PEAR::isError($SMTP_CONN->data("$text_headers\r\n$body")))
+ if (PEAR::isError($SMTP_CONN->data($data)))
{
smtp_reset();
- $SMTP_ERROR .= "Failed to send data\n";
+ $response[] .= "Failed to send data";
return FALSE;
}
-
+ $response[] = join(': ', $SMTP_CONN->getResponse());
return TRUE;
}
@@ -316,9 +327,9 @@
reset($recipients);
while (list($k, $recipient) = each($recipients))
{
- $a = explode(" ", $recipient);
- while (list($k2, $word) = each($a))
- {
+ $a = explode(" ", $recipient);
+ while (list($k2, $word) = each($a))
+ {
if ((strpos($word, "@") > 0) && (strpos($word, "\"")===false))
{
$word = ereg_replace('^<|>$', '', trim($word));
@@ -338,13 +349,13 @@
if (($key % 2) == 1)
$quotes[$key] = str_replace($delimiter, "_!@!_", $quotes[$key]);
$string=implode("\"", $quotes);
-
+
$result=explode($delimiter, $string);
while (list($key, $val) = each($result))
$result[$key] = str_replace("_!@!_", $delimiter, $result[$key]);
return $result;
- }
+ }
?>
--
Gitblit v1.9.1