From 7dfb1fba5001299300736e6b5d95d9400575e3e7 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Thu, 18 Sep 2008 14:59:02 -0400 Subject: [PATCH] Set the right number of arguments for setcookie() --- program/steps/addressbook/func.inc | 70 ++++++++-------------------------- 1 files changed, 17 insertions(+), 53 deletions(-) diff --git a/program/steps/addressbook/func.inc b/program/steps/addressbook/func.inc index ea67ec2..98cf29f 100644 --- a/program/steps/addressbook/func.inc +++ b/program/steps/addressbook/func.inc @@ -20,16 +20,7 @@ */ // instantiate a contacts object according to the given source -if (($source = get_input_value('_source', RCUBE_INPUT_GPC)) && isset($CONFIG['ldap_public'][$source])) - $CONTACTS = new rcube_ldap($CONFIG['ldap_public'][$source]); -else if (strtolower($CONFIG['address_book_type']) == 'ldap') { - // Get the first LDAP address book. - $source = key((array)$CONFIG['ldap_public']); - $prop = current((array)$CONFIG['ldap_public']); - $CONTACTS = new rcube_ldap($prop); -} else { - $CONTACTS = new rcube_contacts($DB, $_SESSION['user_id']); -} // end else +$CONTACTS = $RCMAIL->get_address_book(($source = get_input_value('_source', RCUBE_INPUT_GPC))); $CONTACTS->set_pagesize($CONFIG['pagesize']); @@ -52,9 +43,11 @@ if (strtolower($CONFIG['address_book_type']) != 'ldap') { // We are using the DB address book, add it. $js_list = array("0" => array('id' => 0, 'readonly' => false)); -} // end if -foreach ((array)$CONFIG['ldap_public'] as $id => $prop) - $js_list[$id] = array('id' => $id, 'readonly' => !$prop['writable']); +} +if (is_array($CONFIG['ldap_public'])) { + foreach ($CONFIG['ldap_public'] as $id => $prop) + $js_list[$id] = array('id' => $id, 'readonly' => !$prop['writable']); +} $OUTPUT->set_env('address_sources', $js_list); @@ -65,31 +58,15 @@ if (!$attrib['id']) $attrib['id'] = 'rcmdirectorylist'; + $out = ''; $local_id = '0'; $current = get_input_value('_source', RCUBE_INPUT_GPC); - $line_templ = '<li id="%s" class="%s"><a href="%s"' . - ' onclick="return %s.command(\'list\',\'%s\',this)"' . - ' onmouseover="return %s.focus_folder(\'%s\')"' . - ' onmouseout="return %s.unfocus_folder(\'%s\')"' . - ' onmouseup="return %s.folder_mouse_up(\'%s\')">%s'. - "</a></li>\n"; + $line_templ = html::tag('li', array('id' => 'rcmli%s', 'class' => '%s'), + html::a(array('href' => '%s', 'onclick' => "return ".JS_OBJECT_NAME.".command('list','%s',this)"), '%s')); - // allow the following attributes to be added to the <ul> tag - $out = '<ul' . create_attrib_string($attrib, array('style', 'class', 'id')) . ">\n"; if (strtolower($CONFIG['address_book_type']) != 'ldap') { - $out .= sprintf($line_templ, - 'rcmli'.$local_id, - !$current ? 'selected' : '', - Q(rcmail_url('list', array('_source' => 0))), - JS_OBJECT_NAME, - $local_id, - JS_OBJECT_NAME, - $local_id, - JS_OBJECT_NAME, - $local_id, - JS_OBJECT_NAME, - $local_id, - rcube_label('personaladrbook')); + $out .= sprintf($line_templ, $local_id, (!$current ? 'selected' : ''), + Q(rcmail_url(null, array('_source' => $local_id))), $local_id, rcube_label('personaladrbook')); } // end if else { // DB address book not used, see if a source is set, if not use the @@ -99,30 +76,16 @@ } // end if } // end else - foreach ((array)$CONFIG['ldap_public'] as $id => $prop) - { + foreach ((array)$CONFIG['ldap_public'] as $id => $prop) { $js_id = JQ($id); $dom_id = preg_replace('/[^a-z0-9\-_]/i', '', $id); - $out .= sprintf($line_templ, - 'rcmli'.$dom_id, - $current == $id ? 'selected' : '', - Q(rcmail_url('list', array('_source' => $id))), - JS_OBJECT_NAME, - $js_id, - JS_OBJECT_NAME, - $js_id, - JS_OBJECT_NAME, - $js_id, - JS_OBJECT_NAME, - $js_id, - !empty($prop['name']) ? Q($prop['name']) : Q($id)); + $out .= sprintf($line_templ, $dom_id, ($current == $id ? 'selected' : ''), + Q(rcmail_url(null, array('_source' => $id))), $js_id, (!empty($prop['name']) ? Q($prop['name']) : Q($id))); } - $out .= '</ul>'; - $OUTPUT->add_gui_object('folderlist', $attrib['id']); - return $out; + return html::tag('ul', $attrib, $out, html::$common_attrib); } @@ -239,7 +202,8 @@ return $out; } - + +$OUTPUT->set_pagetitle(rcube_label('addressbook')); // register UI objects $OUTPUT->add_handlers(array( -- Gitblit v1.9.1