From 7ffc08ce87bdbc761eb9811f8be25a8c9c4e9976 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Tue, 27 May 2008 10:58:04 -0400 Subject: [PATCH] Remove cruft from upload response --- program/lib/imap.inc | 499 +++++++++++++++++++++++++++---------------------------- 1 files changed, 243 insertions(+), 256 deletions(-) diff --git a/program/lib/imap.inc b/program/lib/imap.inc index 49db2a9..4456a22 100644 --- a/program/lib/imap.inc +++ b/program/lib/imap.inc @@ -51,22 +51,28 @@ - Abort do-loop on socket errors (fgets returns false) - $ICL_SSL is not boolean anymore but contains the connection schema (ssl or tls) - Removed some debuggers (echo ...) + File altered by Aleksander Machniak <alec@alec.pl> + - RFC3501 [7.1] don't call CAPABILITY if was returned in server + optional resposne in iil_Connect() + - trim(chop()) replaced by trim() + ********************************************************/ /** * @todo Possibly clean up more CS. + * @todo Try to replace most double-quotes with single-quotes. * @todo Split this file into smaller files. * @todo Refactor code. * @todo Replace echo-debugging (make it adhere to config setting and log) */ // changed path to work within roundcube webmail -include_once("lib/icl_commons.inc"); +include_once 'lib/icl_commons.inc'; -if (!$IMAP_USE_HEADER_DATE) { - $IMAP_USE_INTERNAL_DATE = true; +if (!isset($IMAP_USE_HEADER_DATE) || !$IMAP_USE_HEADER_DATE) { + $IMAP_USE_INTERNAL_DATE = true; } /** @@ -160,18 +166,19 @@ } function iil_ReadLine($fp, $size) { - $line = ''; - if ($fp) { - do { - // FIXME: hardcode size? - $buffer = fgets($fp, 2048); - if ($buffer === false) { - break; - } - $line .= $buffer; - } while ($buffer[strlen($buffer)-1]!="\n"); - } - return $line; + $line = ''; + if (!$fp) { + return $line; + } + do { + // FIXME: hardcode size? + $buffer = fgets($fp, 2048); + if ($buffer === false) { + break; + } + $line .= $buffer; + } while ($buffer[strlen($buffer)-1] != "\n"); + return $line; } function iil_MultLine($fp, $line) { @@ -191,18 +198,21 @@ } function iil_ReadBytes($fp, $bytes) { - $data = ''; - $len = 0; - do { - $data.=fread($fp, $bytes-$len); - $len = strlen($data); - } while ($len<$bytes); - return $data; + $data = ''; + $len = 0; + do { + $data .= fread($fp, $bytes-$len); + if ($len == strlen($data)) { + break; //nothing was read -> exit to avoid apache lockups + } + $len = strlen($data); + } while ($len < $bytes); + return $data; } function iil_ReadReply($fp) { do { - $line = chop(trim(iil_ReadLine($fp, 1024))); + $line = trim(iil_ReadLine($fp, 1024)); } while ($line[0] == '*'); return $line; @@ -253,8 +263,8 @@ // initialize ipad, opad for ($i=0;$i<64;$i++) { - $ipad .=chr(0x36); - $opad .=chr(0x5C); + $ipad .= chr(0x36); + $opad .= chr(0x5C); } // pad $pass so it's 64 bytes $padLen = 64 - strlen($pass); @@ -264,7 +274,7 @@ // generate hash $hash = iil_xor($pass,$opad); - $hash .= pack("H*",md5(iil_xor($pass, $ipad) . base64_decode($encChallenge))); + $hash .= pack("H*", md5(iil_xor($pass, $ipad) . base64_decode($encChallenge))); $hash = md5($hash); // generate reply @@ -456,7 +466,7 @@ //check for SSL if ($ICL_SSL) { - $host = $ICL_SSL."://".$host; + $host = $ICL_SSL . '://' . $host; } //open socket connection @@ -468,44 +478,55 @@ } $iil_error .= "Socket connection established\r\n"; - $line = iil_ReadLine($conn->fp, 300); + $line = iil_ReadLine($conn->fp, 1024); + + // RFC3501 [7.1] optional CAPABILITY response + // commented out, because it's not working always as should +// if (preg_match('/\[CAPABILITY ([^]]+)\]/i', $line, $matches)) { +// $conn->capability = explode(' ', $matches[1]); +// } else { + fputs($conn->fp, "cp01 CAPABILITY\r\n"); + do { + $line = trim(iil_ReadLine($conn->fp, 100)); + + $conn->message .= "$line\n"; + + $a = explode(' ', $line); + if ($line[0] == '*') { + while (list($k, $w) = each($a)) { + if ($w != '*' && $w != 'CAPABILITY') + $conn->capability[] = $w; + } + } + } while ($a[0] != 'cp01'); +// } if (strcasecmp($auth_method, "check") == 0) { //check for supported auth methods //default to plain text auth - $auth_method = "plain"; + $auth_method = 'plain'; //check for CRAM-MD5 - fputs($conn->fp, "cp01 CAPABILITY\r\n"); - do { - $line = trim(chop(iil_ReadLine($conn->fp, 100))); - $conn->message.="$line\n"; - $a = explode(' ', $line); - if ($line[0]=="*") { - while ( list($k, $w) = each($a) ) { - if ($w!='*' && $w!='CAPABILITY') { - $conn->capability[] = $w; - } - if ((strcasecmp($w, "AUTH=CRAM_MD5") == 0)|| - (strcasecmp($w, "AUTH=CRAM-MD5") == 0)) { - $auth_method = "auth"; - } - } + foreach ($conn->capability as $c) + if (strcasecmp($c, 'AUTH=CRAM_MD5') == 0 || + strcasecmp($c, 'AUTH=CRAM-MD5') == 0) { + $auth_method = 'auth'; + break; } - } while ($a[0]!="cp01"); } - if (strcasecmp($auth_method, "auth") == 0) { + if (strcasecmp($auth_method, 'auth') == 0) { $conn->message .= "Trying CRAM-MD5\n"; + //do CRAM-MD5 authentication fputs($conn->fp, "a000 AUTHENTICATE CRAM-MD5\r\n"); - $line = trim(chop(iil_ReadLine($conn->fp, 1024))); + $line = trim(iil_ReadLine($conn->fp, 1024)); - $conn->message.="$line\n"; + $conn->message .= "$line\n"; - if ($line[0] == "+") { - $conn->message .= 'Got challenge: ' . htmlspecialchars($line)."\n"; + if ($line[0] == '+') { + $conn->message .= 'Got challenge: ' . htmlspecialchars($line) . "\n"; //got a challenge string, try CRAM-5 $result = iil_C_Authenticate($conn, $user, $password, substr($line,2)); @@ -760,7 +781,7 @@ $str = substr($str, $pos+1); } //explode, take good parts - $a=explode(' ',$str); + $a = explode(' ', $str); $month_str = $a[1]; $month = $IMAP_MONTHS[$month_str]; @@ -790,8 +811,8 @@ if ($field == 'INTERNALDATE') { $field = 'ARRIVAL'; } - $fields = array('ARRIVAL'=>1,'CC'=>1,'DATE'=>1,'FROM'=>1,'SIZE'=>1, - 'SUBJECT'=>1,'TO'=>1); + $fields = array('ARRIVAL' => 1,'CC' => 1,'DATE' => 1, + 'FROM' => 1, 'SIZE' => 1, 'SUBJECT' => 1, 'TO' => 1); if (!$fields[$field]) { return false; @@ -803,9 +824,10 @@ $add = " $add"; } - $fp = $conn->fp; - $command = 's '. $is_uid .'SORT ('.$field.') '.$encoding.' ALL'."$add\r\n"; - $line = $data = ''; + $fp = $conn->fp; + $command = 's ' . $is_uid . 'SORT (' . $field . ') '; + $command .= $encoding . ' ALL' . "$add\r\n"; + $line = $data = ''; if (!fputs($fp, $command)) { return false; @@ -942,7 +964,7 @@ }else if ($mode == 6) { $key = 'fhi' . ($c++); - $request = $key." FETCH $message_set (INTERNALDATE)\r\n"; + $request = $key . " FETCH $message_set (INTERNALDATE)\r\n"; if (!fputs($fp, $request)) { return false; } @@ -1014,23 +1036,21 @@ } //check number of elements... - list($start_mid,$end_mid) = explode(':', $message_set); + list($start_mid, $end_mid) = explode(':', $message_set); if (is_numeric($start_mid) && is_numeric($end_mid)) { //count how many we should have $should_have = $end_mid - $start_mid +1; //if we have less, try and fill in the "gaps" - if (count($result)<$should_have) { - for ($i=$start_mid;$i<=$end_mid;$i++) { + if (count($result) < $should_have) { + for ($i=$start_mid; $i<=$end_mid; $i++) { if (!isset($result[$i])) { $result[$i] = ''; } } } } - return $result; - } function iil_CompressMessageSet($message_set) { @@ -1048,18 +1068,19 @@ } //separate, then sort - $ids = explode(',',$message_set); + $ids = explode(',', $message_set); sort($ids); $result = array(); - $start = $prev = $ids[0]; + $start = $prev = $ids[0]; + foreach ($ids as $id) { $incr = $id - $prev; - if ($incr>1) { //found a gap - if ($start==$prev) { + if ($incr > 1) { //found a gap + if ($start == $prev) { $result[] = $prev; //push single id } else { - $result[] = $start.':'.$prev; //push sequence as start_id:end_id + $result[] = $start . ':' . $prev; //push sequence as start_id:end_id } $start = $id; //start of new sequence } @@ -1080,12 +1101,12 @@ if (!is_array($uids) || count($uids) == 0) { return array(); } - return iil_C_Search($conn, $mailbox, "UID ".implode(",", $uids)); + return iil_C_Search($conn, $mailbox, 'UID ' . implode(',', $uids)); } function iil_C_UIDToMID(&$conn, $mailbox, $uid) { $result = iil_C_UIDsToMIDs($conn, $mailbox, array($uid)); - if (count($result)==1) { + if (count($result) == 1) { return $result[0]; } return false; @@ -1119,12 +1140,12 @@ } //make sure number of messages were the same - if ($cache_good>0 && $data['n']!=$num) { + if ($cache_good > 0 && $data['n'] != $num) { $cache_good = -2; } //if everything's okay so far... - if ($cache_good>0) { + if ($cache_good > 0) { //check UIDs of highest mid with current and cached $temp = iil_C_Search($conn, $mailbox, 'UID ' . $data['d'][$num]); if (!$temp || !is_array($temp) || $temp[0] != $num) { @@ -1133,7 +1154,7 @@ } //if cached data's good, return it - if ($cache_good>0) { + if ($cache_good > 0) { return $data['d']; } @@ -1218,16 +1239,19 @@ $new_thhd = new iilThreadHeader; $new_thhd->id = $a[1]; do { - $line=chop(iil_ReadLine($fp, 1024),"\r\n"); + $line = chop(iil_ReadLine($fp, 1024), "\r\n"); if (iil_StartsWithI($line, 'Message-ID:') || (iil_StartsWithI($line,'In-Reply-To:')) || (iil_StartsWithI($line,'SUBJECT:'))) { - $pos = strpos($line, ":"); + + $pos = strpos($line, ':'); $field_name = substr($line, 0, $pos); - $field_val = substr($line, $pos+1); + $field_val = substr($line, $pos+1); + $new[strtoupper($field_name)] = trim($field_val); + } else if (ereg('^[[:space:]]', $line)) { - $new[strtoupper($field_name)].= trim($line); + $new[strtoupper($field_name)] .= trim($line); } } while ($line[0] != ')'); @@ -1301,8 +1325,8 @@ //$new = array('id'=>$id, 'MESSAGE-ID'=>$header['m'], // 'IN-REPLY-TO'=>$header['r'], 'SUBJECT'=>$header['s']); $id = $header->id; - $new = array('id'=>$id, 'MESSAGE-ID'=>$header->mid, - 'IN-REPLY-TO'=>$header->irt, 'SUBJECT'=>$header->sbj); + $new = array('id' => $id, 'MESSAGE-ID' => $header->mid, + 'IN-REPLY-TO' => $header->irt, 'SUBJECT' => $header->sbj); /* add to message-id -> mid lookup table */ $mid_to_id[$new['MESSAGE-ID']] = $id; @@ -1343,7 +1367,7 @@ } $sub_mids[$new['MESSAGE-ID']] = $root_id; $result[$root_id][] = $id; - }else if (!isset($roots[$sbj])||(!$has_re&&$root_in_root[$root_id])) { + }else if (!isset($roots[$sbj]) || (!$has_re && $root_in_root[$root_id])) { /* try to use In-Reply-To header to find root unless subject contains 'Re:' */ if ($has_re&&$new['IN-REPLY-TO']) { @@ -1386,7 +1410,7 @@ //now that we've gone through all the messages, //go back and try and link up the stray threads - if (count($strays)>0) { + if (count($strays) > 0) { foreach ($strays as $id=>$irt) { $root_id = $sub_mids[$irt]; if (!$root_id || $root_id==$id) { @@ -1452,8 +1476,8 @@ //sort by key, this basically sorts all threads ksort($itree); - $i=0; - $out=array(); + $i = 0; + $out = array(); foreach ($itree as $k=>$node) { $out[$i] = $itree[$k]; $i++; @@ -1488,9 +1512,9 @@ list($from_idx, $to_idx) = explode(':', $message_set); if (empty($message_set) || (isset($to_idx) - && (int)$from_idx > (int)$to_idx)) { + && (int)$from_idx > (int)$to_idx)) { return false; - } + } /* Do "SELECT" command */ if (!iil_C_Select($conn, $mailbox)) { @@ -1509,29 +1533,29 @@ $result[$id]->id = $id; } else { $needed_set.=($needed_set ? ',': '') . $id; - } + } } //echo "<!-- iil_C_FetchHeader\nMessage Set: $message_set\nNeeded Set:$needed_set\n//-->\n"; if ($needed_set) { - $message_set = iil_CompressMessageSet($needed_set); - } else { - return $result; - } + $message_set = iil_CompressMessageSet($needed_set); + } else { + return $result; + } } } /* FETCH date,from,subject headers */ - $key = 'fh' . ($c++); - $prefix = $uidfetch?' UID':''; + $key = 'fh' . ($c++); + $prefix = $uidfetch?' UID':''; $request = $key . $prefix; - $request .= " FETCH $message_set (BODY.PEEK[HEADER.FIELDS "; - $request .= "(DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC "; - $request .= "CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID "; - $request .= "REFERENCES DISPOSITION-NOTIFICATION-TO X-PRIORITY)])\r\n"; + $request .= " FETCH $message_set (BODY.PEEK[HEADER.FIELDS "; + $request .= "(DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC "; + $request .= "CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID "; + $request .= "REFERENCES DISPOSITION-NOTIFICATION-TO X-PRIORITY)])\r\n"; if (!fputs($fp, $request)) { - return false; - } + return false; + } do { $line = chop(iil_ReadLine($fp, 200)); $a = explode(' ', $line); @@ -1554,10 +1578,10 @@ do { $line = chop(iil_ReadLine($fp, 300), "\r\n"); if (ord($line[0])<=32) { - $lines[$i] .= (empty($lines[$i])?'':"\n").trim(chop($line)); + $lines[$i] .= (empty($lines[$i])?'':"\n").trim($line); } else { $i++; - $lines[$i] = trim(chop($line)); + $lines[$i] = trim($line); } /* The preg_match below works around communigate imap, which outputs " UID <number>)". @@ -1571,62 +1595,63 @@ */ if (preg_match("/^\s*UID [0-9]+\)$/", $line)) { break; - } - // patch from "Maksim Rubis" <siburny@hotmail.com> + } + // patch from "Maksim Rubis" <siburny@hotmail.com> } while (trim($line[0]) != ')' && strncmp($line, $key, strlen($key))); - if (strncmp($line, $key, strlen($key))) { - //process header, fill iilBasicHeader obj. - // initialize - if (is_array($headers)) { - reset($headers); - while (list($k, $bar) = each($headers)) { - $headers[$k] = ''; - } - } - - // create array with header field:data - while ( list($lines_key, $str) = each($lines) ) { - list($field, $string) = iil_SplitHeaderLine($str); - - $field = strtolower($field); - - switch ($field) { + if (strncmp($line, $key, strlen($key))) { + //process header, fill iilBasicHeader obj. + // initialize + if (is_array($headers)) { + reset($headers); + while (list($k, $bar) = each($headers)) { + $headers[$k] = ''; + } + } + + // create array with header field:data + while ( list($lines_key, $str) = each($lines) ) { + list($field, $string) = iil_SplitHeaderLine($str); + + $field = strtolower($field); + $string = ereg_replace("\n[[:space:]]*"," ",$string); + + switch ($field) { case 'date'; - $result[$id]->date = $string; + $result[$id]->date = $string; $result[$id]->timestamp = iil_StrToTime($string); break; case 'from': $result[$id]->from = $string; break; case 'to': - $result[$id]->to = str_replace("\n", " ", $string); + $result[$id]->to = $string; break; case 'subject': - $result[$id]->subject = str_replace("\n", '', $string); + $result[$id]->subject = $string; break; case 'reply-to': - $result[$id]->replyto = str_replace("\n", " ", $string); + $result[$id]->replyto = $string; break; case 'cc': - $result[$id]->cc = str_replace("\n", " ", $string); + $result[$id]->cc = $string; break; case 'bcc': - $result[$id]->bcc = str_replace("\n", " ", $string); + $result[$id]->bcc = $string; break; case 'content-transfer-encoding': - $result[$id]->encoding = str_replace("\n", " ", $string); + $result[$id]->encoding = $string; break; case 'content-type': - $ctype_parts = explode(";", $string); + $ctype_parts = explode(";", $string); $result[$id]->ctype = array_shift($ctype_parts); foreach ($ctype_parts as $ctype_add) { - if (preg_match('/charset="?([a-z0-9\-\.\_]+)"?/i', - $ctype_add, $regs)) { - $result[$id]->charset = $regs[1]; + if (preg_match('/charset="?([a-z0-9\-\.\_]+)"?/i', + $ctype_add, $regs)) { + $result[$id]->charset = $regs[1]; } - } - break; + } + break; case 'in-reply-to': $result[$id]->in_reply_to = ereg_replace("[\n<>]", '', $string); break; @@ -1636,7 +1661,7 @@ case 'return-receipt-to': case 'disposition-notification-to': case 'x-confirm-reading-to': - $result[$id]->mdn_to = str_replace("\n", " ", $string); + $result[$id]->mdn_to = $string; break; case 'message-id': $result[$id]->messageID = $string; @@ -1645,59 +1670,11 @@ if (preg_match('/^(\d+)/', $string, $matches)) $result[$id]->priority = intval($matches[1]); break; - } // end switch () - } // end while () - } else { - $a = explode(' ', $line); - } - - if (!isset($result[$id]->date)) { - $result[$id]->date = ''; - } - $result[$id]->date = trim($result[$id]->date); - - $before = true; - - if ($result[$id]->date == '') { - - $before = false; - - /* FETCH RECEIVED header */ - $key = 'fh' . ($c++); - $request = $key; - $request .= " UID FETCH $id (BODY.PEEK[HEADER.FIELDS "; - $request .= "(RECEIVED)])\r\n"; - - if (fputs($fp, $request)) { - $_received = ''; - while ($line = chop(iil_ReadLine($fp, 200))) { - $line = trim($line); - if (preg_match('/for <(.*)>;(.*)/', $line)) { - $_received .= trim($line); - break; - } - } - if ($_received != '') { - $_received = trim(str_replace(';', '', - substr($_received, strpos($_received, ';')) )); - - if ($_received != '') { - $result[$id]->date = $_received; - $result[$id]->timestamp = iil_StrToTime($_received); - //trigger_error("Date: {$result[$id]->timestamp}", E_USER_WARNING); - } - } - $result[$id]->date = trim($result[$id]->date); - } - /** - * This is hack to display something. - */ - if ($result[$id]->date == '') { - $result[$id]->date = date('r'); - $result[$id]->timestamp = time(); - } - } - trigger_error("set before? {$before}, ID {$id}: {$result[$id]->date} / {$result[$id]->timestamp}", E_USER_WARNING); + } // end switch () + } // end while () + } else { + $a = explode(' ', $line); + } } } while (strcmp($a[0], $key) != 0); @@ -1706,14 +1683,14 @@ Sample reply line: "* 3 FETCH (UID 2417 RFC822.SIZE 2730 FLAGS (\Seen \Deleted))" */ $command_key = 'fh' . ($c++); - - $request = $command_key . $prefix; - $request .= " FETCH $message_set (UID RFC822.SIZE FLAGS INTERNALDATE)\r\n"; + $request = $command_key . $prefix; + $request .= " FETCH $message_set (UID RFC822.SIZE FLAGS INTERNALDATE)\r\n"; + if (!fputs($fp, $request)) { return false; } do { - $line=chop(iil_ReadLine($fp, 200)); + $line = chop(iil_ReadLine($fp, 200)); //$a = explode(' ', $line); //if (($line[0]=="*") && ($a[2]=="FETCH")) { if ($line[0] == '*') { @@ -1747,8 +1724,12 @@ // process flags $flags_str = eregi_replace('[\\\"]', '', $flags_str); - $flags_a = explode(' ', $flags_str); - //echo "<!-- ID: $id FLAGS: ".implode(",", $flags_a)." //-->\n"; + $flags_a = explode(' ', $flags_str); + + /* + trigger_error("<!-- ID: $id FLAGS: ".implode(",", $flags_a)." //-->\n", + E_USER_WARNING); + */ if (is_array($flags_a)) { reset($flags_a); @@ -1779,18 +1760,19 @@ if ($time_zone_str[3] != '0') { $time_zone += 0.5; //handle half hour offset } - if ($time_zone_str[0] == '-') { - $time_zone = $time_zone * -1.0; //minus? + if ($time_zone_str[0] == '-') { + $time_zone = $time_zone * -1.0; //minus? } - $result[$id]->internaldate = $time_str; + $result[$id]->internaldate = $time_str; - if ($IMAP_USE_INTERNAL_DATE) { + if ($IMAP_USE_INTERNAL_DATE || empty($result[$id]->date)) { //calculate timestamp $timestamp = strtotime($time_str); //return's server's time $na_timestamp = $timestamp; $timestamp -= $time_zone * 3600; //compensate for tz, get GMT $result[$id]->timestamp = $timestamp; + $result[$id]->date = $time_str; } if ($conn->do_cache) { @@ -1813,8 +1795,8 @@ $fp = $conn->fp; $a = iil_C_FetchHeaders($conn, $mailbox, $id, $uidfetch); if (is_array($a)) { - return array_shift($a); - } + return array_shift($a); + } return false; } @@ -1835,7 +1817,7 @@ $stripArr = ($field=='subject') ? array('Re: ','Fwd: ','Fw: ','"') : array('"'); $c=count($a); - if ($c>0) { + if ($c > 0) { /* Strategy: First, we'll create an "index" array. @@ -1885,7 +1867,7 @@ function iil_C_Expunge(&$conn, $mailbox) { $fp = $conn->fp; if (iil_C_Select($conn, $mailbox)) { - $c=0; + $c = 0; fputs($fp, "exp1 EXPUNGE\r\n"); do { $line=chop(iil_ReadLine($fp, 100)); @@ -1924,7 +1906,7 @@ $flag = $flags[$flag]; if (iil_C_Select($conn, $mailbox)) { - $c=0; + $c = 0; fputs($fp, "flg STORE $messages " . $mod . "FLAGS (" . $flag . ")\r\n"); do { $line=chop(iil_ReadLine($fp, 100)); @@ -2039,20 +2021,20 @@ function iil_C_Search(&$conn, $folder, $criteria) { $fp = $conn->fp; if (iil_C_Select($conn, $folder)) { - $c=0; + $c = 0; $query = 'srch1 SEARCH ' . chop($criteria) . "\r\n"; fputs($fp, $query); do { - $line=trim(chop(iil_ReadLine($fp, 10000))); + $line=trim(iil_ReadLine($fp, 10000)); if (eregi("^\* SEARCH", $line)) { $str = trim(substr($line, 8)); $messages = explode(' ', $str); } - } while (!iil_StartsWith($line, "srch1")); + } while (!iil_StartsWith($line, 'srch1')); - $result_code=iil_ParseResult($line); - if ($result_code==0) { + $result_code = iil_ParseResult($line); + if ($result_code == 0) { return $messages; } $conn->error = 'iil_C_Search: ' . $line . "\n"; @@ -2064,16 +2046,15 @@ } function iil_C_Move(&$conn, $messages, $from, $to) { - $fp = $conn->fp; - - if (!$from || !$to) { - return -1; - } - - $r=iil_C_Copy($conn, $messages, $from,$to); - if ($r==0) { - return iil_C_Delete($conn, $from, $messages); - } + $fp = $conn->fp; + + if (!$from || !$to) { + return -1; + } + $r = iil_C_Copy($conn, $messages, $from,$to); + if ($r==0) { + return iil_C_Delete($conn, $from, $messages); + } return $r; } @@ -2284,7 +2265,8 @@ $query = 'sub1 SUBSCRIBE "' . $folder. '"' . "\r\n"; fputs($fp, $query); - $line = trim(chop(iil_ReadLine($fp, 10000))); + + $line = trim(iil_ReadLine($fp, 10000)); return iil_ParseResult($line); } @@ -2295,7 +2277,7 @@ $query = 'usub1 UNSUBSCRIBE "' . $folder . '"' . "\r\n"; fputs($fp, $query); - $line = trim(chop(iil_ReadLine($fp, 10000))); + $line = trim(iil_ReadLine($fp, 10000)); return iil_ParseResult($line); } @@ -2314,17 +2296,17 @@ $request = $key . " FETCH $id (BODY.PEEK[$part])\r\n"; if (!fputs($fp, $request)) return false; do { - $line=chop(iil_ReadLine($fp, 200)); - $a=explode(' ', $line); + $line = chop(iil_ReadLine($fp, 200)); + $a = explode(' ', $line); if (($line[0] == '*') && ($a[2] == 'FETCH') && ($line[strlen($line)-1] != ')')) { $line=iil_ReadLine($fp, 300); - while (chop($line)!=")") { - $result.=$line; + while (trim($line) != ')') { + $result .= $line; $line=iil_ReadLine($fp, 300); } } - } while (strcmp($a[0], $key)!=0); + } while (strcmp($a[0], $key) != 0); } return $result; @@ -2339,12 +2321,12 @@ */ $fp = $conn->fp; $result = false; - if (($part==0) || (empty($part))) { + if (($part == 0) || empty($part)) { $part = 'TEXT'; } if (iil_C_Select($conn, $mailbox)) { - $reply_key='* ' . $id; + $reply_key = '* ' . $id; // format request $key = 'ftch' . ($c++) . ' '; @@ -2362,17 +2344,22 @@ $len = strlen($line); if ($line[$len-1] == ')') { //one line response, get everything between first and last quotes - $from = strpos($line, '"') + 1; - $to = strrpos($line, '"'); - $len = $to - $from; - if ($mode == 1) { - $result = substr($line, $from, $len); - } else if ($mode == 2) { - echo substr($line, $from, $len); + if (substr($line, -4, 3) == 'NIL') { + // NIL response + $result = ''; + } else { + $from = strpos($line, '"') + 1; + $to = strrpos($line, '"'); + $len = $to - $from; + $result = substr($line, $from, $len); + } + + if ($mode == 2) { + echo $result; } else if ($mode == 3) { - echo base64_decode(substr($line, $from, $len)); + echo base64_decode($result); } - }else if ($line[$len-1] == '}') { + } else if ($line[$len-1] == '}') { //multi-line request, find sizes of content and receive that many bytes $from = strpos($line, '{') + 1; $to = strrpos($line, '}'); @@ -2389,11 +2376,11 @@ $line = substr($line, 0, $remaining); } $received += strlen($line); - if ($mode==1) { - $result .= chop($line)."\n"; - } else if ($mode==2) { - echo chop($line)."\n"; flush(); - } else if ($mode==3) { + if ($mode == 1) { + $result .= rtrim($line, "\t\r\n\0\x0B") . "\n"; + } else if ($mode == 2) { + echo rtrim($line, "\t\r\n\0\x0B") . "\n"; flush(); + } else if ($mode == 3) { echo base64_decode($line); flush(); } } @@ -2404,7 +2391,7 @@ } while (!iil_StartsWith($line, $key)); if ($result) { - $result = chop($result); + $result = rtrim($result, "\t\r\n\0\x0B"); return $result; // substr($result, 0, strlen($result)-1); } return false; @@ -2446,11 +2433,11 @@ $fp = $conn->fp; if (fputs($fp, 'r RENAME "' . $from . '" "' . $to . '"' . "\r\n")) { do { - $line=iil_ReadLine($fp, 300); - } while ($line[0]!="r"); + $line = iil_ReadLine($fp, 300); + } while ($line[0] != 'r'); return (iil_ParseResult($line) == 0); } - return false; + return false; } function iil_C_DeleteFolder(&$conn, $folder) { @@ -2458,7 +2445,7 @@ if (fputs($fp, 'd DELETE "' . $folder. '"' . "\r\n")) { do { $line=iil_ReadLine($fp, 300); - } while ($line[0]!="d"); + } while ($line[0] != 'd'); return (iil_ParseResult($line) == 0); } $conn->error = "Couldn't send command\n"; @@ -2466,21 +2453,23 @@ } function iil_C_Append(&$conn, $folder, &$message) { - if (!$folder) return false; + if (!$folder) { + return false; + } $fp = $conn->fp; $message = str_replace("\r", '', $message); $message = str_replace("\n", "\r\n", $message); $len = strlen($message); - if (!$len) return false; - + if (!$len) { + return false; + } $request = 'A APPEND "' . $folder .'" (\\Seen) {' . $len . "}\r\n"; if (fputs($fp, $request)) { $line=iil_ReadLine($fp, 100); $sent = fwrite($fp, $message."\r\n"); - flush(); do { $line=iil_ReadLine($fp, 1000); } while ($line[0] != 'A'); @@ -2522,11 +2511,11 @@ $request = 'A APPEND "' . $folder . '" (\\Seen) {' . $len . "}\r\n"; $bytes_sent = 0; if (fputs($fp, $request)) { - $line=iil_ReadLine($fp, 100); + $line = iil_ReadLine($fp, 100); //send file while (!feof($in_fp)) { - $buffer = fgets($in_fp, 4096); + $buffer = fgets($in_fp, 4096); $bytes_sent += strlen($buffer); fputs($fp, $buffer); } @@ -2536,7 +2525,7 @@ //read response do { - $line=iil_ReadLine($fp, 1000); + $line = iil_ReadLine($fp, 1000); } while ($line[0] != 'A'); $result = (iil_ParseResult($line) == 0); @@ -2580,7 +2569,7 @@ //truncate last ')' and return $result = substr($post, 0, strlen($post)-1); } - } while (!preg_match("/^$key/",$line)); + } while (!preg_match("/^$key/", $line)); } } return $result; @@ -2616,10 +2605,10 @@ //return false if not found, parse if found if (!empty($quota_line)) { - $quota_line = eregi_replace('[()]', '', $quota_line); - $parts = explode(' ', $quota_line); + $quota_line = eregi_replace('[()]', '', $quota_line); + $parts = explode(' ', $quota_line); $storage_part = array_search('STORAGE', $parts); - if ($storage_part>0) { + if ($storage_part > 0) { $result = array(); $used = $parts[$storage_part+1]; $total = $parts[$storage_part+2]; @@ -2630,7 +2619,6 @@ $result['free'] = 100 - $result['percent']; } } - return $result; } @@ -2642,5 +2630,4 @@ } return (iil_C_Expunge($conn, $folder) >= 0); } - ?> -- Gitblit v1.9.1