From 80fbdaa2d9c011174035a821435fcdde667f578f Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Fri, 14 Aug 2009 04:24:09 -0400 Subject: [PATCH] Changed imap_connect hook according to suggestions in #1485956 --- program/include/rcube_imap.php | 56 ++++++++++++++++++++++++++++++++++++++------------------ 1 files changed, 38 insertions(+), 18 deletions(-) diff --git a/program/include/rcube_imap.php b/program/include/rcube_imap.php index fba30de..78d4486 100644 --- a/program/include/rcube_imap.php +++ b/program/include/rcube_imap.php @@ -36,7 +36,7 @@ * * @package Mail * @author Thomas Bruederli <roundcube@gmail.com> - * @version 1.40 + * @version 1.5 * @link http://ilohamail.org */ class rcube_imap @@ -70,6 +70,8 @@ var $debug_level = 1; var $error_code = 0; var $options = array('imap' => 'check'); + + private $host, $user, $pass, $port, $ssl; /** @@ -101,19 +103,26 @@ // check for Open-SSL support in PHP build if ($use_ssl && extension_loaded('openssl')) $ICL_SSL = $use_ssl == 'imaps' ? 'ssl' : $use_ssl; - else if ($use_ssl) - { + else if ($use_ssl) { raise_error(array('code' => 403, 'type' => 'imap', 'file' => __FILE__, 'message' => 'Open SSL not available;'), TRUE, FALSE); $port = 143; - } + } $ICL_PORT = $port; $IMAP_USE_INTERNAL_DATE = false; + + $attempt = 0; + do { + $data = rcmail::get_instance()->plugins->exec_hook('imap_connect', array('host' => $host, 'user' => $user, 'attempt' => ++$attempt)); + if (!empty($data['pass'])) + $pass = $data['pass']; - $this->conn = iil_Connect($host, $user, $pass, $this->options); - $this->host = $host; - $this->user = $user; + $this->conn = iil_Connect($data['host'], $data['user'], $pass, $this->options); + } while(!$this->conn && $data['retry']); + + $this->host = $data['host']; + $this->user = $data['user']; $this->pass = $pass; $this->port = $port; $this->ssl = $use_ssl; @@ -1534,12 +1543,8 @@ if (!is_array($uids)) $uids = explode(',',$uids); - if ($flag=='UNDELETED') - $result = iil_C_Undelete($this->conn, $mailbox, join(',', $uids)); - else if ($flag=='UNSEEN') - $result = iil_C_Unseen($this->conn, $mailbox, join(',', $uids)); - else if ($flag=='UNFLAGGED') - $result = iil_C_UnFlag($this->conn, $mailbox, join(',', $uids), 'FLAGGED'); + if (strpos($flag, 'UN') === 0) + $result = iil_C_UnFlag($this->conn, $mailbox, join(',', $uids), substr($flag, 2)); else $result = iil_C_Flag($this->conn, $mailbox, join(',', $uids), $flag); @@ -1566,6 +1571,21 @@ $this->_set_messagecount($mailbox, 'ALL', $count*(-1)); return $result; + } + + + /** + * Remove message flag for one or several messages + * + * @param mixed Message UIDs as array or as comma-separated string + * @param string Flag to unset: SEEN, DELETED, RECENT, ANSWERED, DRAFT, MDNSENT + * @param string Folder name + * @return boolean True on success, False on failure + * @see set_flag + */ + function unset_flag($uids, $flag, $mbox_name=NULL) + { + return $this->set_flag($uids, 'UN'.$flag, $mbox_name); } @@ -2397,10 +2417,10 @@ $key, $index, $headers->uid, - (string)rc_substr($this->db->encode($this->decode_header($headers->subject, TRUE)), 0, 128), - (string)rc_substr($this->db->encode($this->decode_header($headers->from, TRUE)), 0, 128), - (string)rc_substr($this->db->encode($this->decode_header($headers->to, TRUE)), 0, 128), - (string)rc_substr($this->db->encode($this->decode_header($headers->cc, TRUE)), 0, 128), + (string)mb_substr($this->db->encode($this->decode_header($headers->subject, TRUE)), 0, 128), + (string)mb_substr($this->db->encode($this->decode_header($headers->from, TRUE)), 0, 128), + (string)mb_substr($this->db->encode($this->decode_header($headers->to, TRUE)), 0, 128), + (string)mb_substr($this->db->encode($this->decode_header($headers->cc, TRUE)), 0, 128), (int)$headers->size, serialize($this->db->encode(clone $headers)), is_object($struct) ? serialize($this->db->encode(clone $struct)) : NULL @@ -2788,7 +2808,7 @@ if (($p = array_search(strtolower($folder), $this->default_folders_lc)) !== false && !$a_defaults[$p]) $a_defaults[$p] = $folder; else - $folders[$folder] = rc_strtolower(rcube_charset_convert($folder, 'UTF7-IMAP')); + $folders[$folder] = mb_strtolower(rcube_charset_convert($folder, 'UTF7-IMAP')); } // sort folders and place defaults on the top -- Gitblit v1.9.1