From 81b573d98ae143bd11b37ff2027bfad78e2d460c Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Tue, 16 Sep 2008 04:49:28 -0400 Subject: [PATCH] - Reduced memory footprint when forwarding attachments (#1485345) - Fixed endless loop in iil_C_HandlePartBody() - rcube_message::get_part_content() speed up using 3rd argument of rcube_imap::get_message_part() --- program/include/rcube_message.php | 22 ++++++++++++++++++---- 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/program/include/rcube_message.php b/program/include/rcube_message.php index 48f9997..f2e4be3 100644 --- a/program/include/rcube_message.php +++ b/program/include/rcube_message.php @@ -117,12 +117,13 @@ * Get content of a specific part of this message * * @param string Part MIME-ID + * @param resource File pointer to save the message part * @return string Part content */ - public function get_part_content($mime_id) + public function get_part_content($mime_id, $fp=NULL) { if ($part = $this->mime_parts[$mime_id]) - return $this->imap->get_message_part($this->uid, $mime_id, $part); + return $this->imap->get_message_part($this->uid, $mime_id, $part, NULL, $fp); else return null; } @@ -230,6 +231,11 @@ $structure->type = 'content'; $this->parts[] = &$structure; } + // the same for pgp signed messages + else if ($message_ctype_primary == 'application' && $message_ctype_secondary == 'pgp' && !$recursive) { + $structure->type = 'content'; + $this->parts[] = &$structure; + } // message contains alternative parts else if ($message_ctype_primary == 'multipart' && ($message_ctype_secondary == 'alternative') && is_array($structure->parts)) { // get html/plaintext parts @@ -279,7 +285,7 @@ $this->parts[] = $print_part; } // show plaintext warning - else if ($html_part !== nullL && empty($this->parts)) { + else if ($html_part !== null && empty($this->parts)) { $c = new stdClass; $c->type = 'content'; $c->body = rcube_label('htmlmessage'); @@ -356,6 +362,10 @@ $mail_part->content_id = preg_replace(array('/^</', '/>$/'), '', $mail_part->headers['content-id']); $this->inline_parts[] = $mail_part; } + else if ($message_ctype_secondary == 'related' && $mail_part->headers['content-location']) { + $mail_part->content_location = $mail_part->headers['content-base'] . $mail_part->headers['content-location']; + $this->inline_parts[] = $mail_part; + } // is regular attachment else { if (!$mail_part->filename) @@ -370,7 +380,11 @@ $a_replaces = array(); foreach ($this->inline_parts as $inline_object) { - $a_replaces['cid:'.$inline_object->content_id] = $this->get_part_url($inline_object->mime_id); + $part_url = $this->get_part_url($inline_object->mime_id); + if ($inline_object->content_id) + $a_replaces['cid:'.$inline_object->content_id] = $part_url; + if ($inline_object->content_location) + $a_replaces[$inline_object->content_location] = $part_url; } // add replace array to each content part -- Gitblit v1.9.1