From 92649075eccdb6d13bde64b044416afd5294adc6 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Thu, 06 Aug 2015 04:03:31 -0400 Subject: [PATCH] CS fixes --- program/steps/mail/move_del.inc | 97 ++++++++++++++++++++++++------------------------ 1 files changed, 48 insertions(+), 49 deletions(-) diff --git a/program/steps/mail/move_del.inc b/program/steps/mail/move_del.inc index 3885787..7cd1c92 100644 --- a/program/steps/mail/move_del.inc +++ b/program/steps/mail/move_del.inc @@ -28,8 +28,7 @@ $old_count = $RCMAIL->storage->count(NULL, $threading ? 'THREADS' : 'ALL'); $old_pages = ceil($old_count / $RCMAIL->storage->get_pagesize()); $sources = array(); - -$trash = $RCMAIL->config->get('trash_mbox'); +$trash = $RCMAIL->config->get('trash_mbox'); // move messages if ($RCMAIL->action == 'move' && !empty($_POST['_uid']) && strlen($_POST['_target_mbox'])) { @@ -56,7 +55,6 @@ $OUTPUT->command('list_mailbox'); $RCMAIL->display_server_error('errormoving', null, $target == $trash ? 'delete' : ''); $OUTPUT->send(); - exit; } else { $OUTPUT->show_message('messagemoved', 'confirmation'); @@ -84,7 +82,6 @@ $OUTPUT->command('list_mailbox'); $RCMAIL->display_server_error('errordeleting'); $OUTPUT->send(); - exit; } else { $OUTPUT->show_message('messagedeleted', 'confirmation'); @@ -96,7 +93,6 @@ else { $OUTPUT->show_message('internalerror', 'error'); $OUTPUT->send(); - exit; } $search_request = rcube_utils::get_input_value('_search', rcube_utils::INPUT_GPC); @@ -107,70 +103,73 @@ } if ($_POST['_from'] == 'show') { - if ($next = rcube_utils::get_input_value('_next_uid', rcube_utils::INPUT_GPC)) - $OUTPUT->command('show_message', $next); - else - $OUTPUT->command('command', 'list'); -} -else { - $msg_count = $RCMAIL->storage->count(NULL, $threading ? 'THREADS' : 'ALL'); - $exists = $RCMAIL->storage->count($mbox, 'EXISTS', true); - $page_size = $RCMAIL->storage->get_pagesize(); - $page = $RCMAIL->storage->get_page(); - $pages = ceil($msg_count / $page_size); - $nextpage_count = $old_count - $page_size * $page; - $remaining = $msg_count - $page_size * ($page - 1); + if ($next = rcube_utils::get_input_value('_next_uid', rcube_utils::INPUT_GPC)) { + $OUTPUT->command('show_message', $next); + } + else { + $OUTPUT->command('command', 'list'); + } - // jump back one page (user removed the whole last page) - if ($page > 1 && $remaining == 0) { + $OUTPUT->send(); +} + +$mbox = $RCMAIL->storage->get_folder(); +$msg_count = $RCMAIL->storage->count(NULL, $threading ? 'THREADS' : 'ALL'); +$exists = $RCMAIL->storage->count($mbox, 'EXISTS', true); +$page_size = $RCMAIL->storage->get_pagesize(); +$page = $RCMAIL->storage->get_page(); +$pages = ceil($msg_count / $page_size); +$nextpage_count = $old_count - $page_size * $page; +$remaining = $msg_count - $page_size * ($page - 1); + +// jump back one page (user removed the whole last page) +if ($page > 1 && $remaining == 0) { $page -= 1; $RCMAIL->storage->set_page($page); $_SESSION['page'] = $page; $jump_back = true; - } +} - // update message count display - $OUTPUT->set_env('messagecount', $msg_count); - $OUTPUT->set_env('current_page', $page); - $OUTPUT->set_env('pagecount', $pages); - $OUTPUT->set_env('exists', $exists); +// update message count display +$OUTPUT->set_env('messagecount', $msg_count); +$OUTPUT->set_env('current_page', $page); +$OUTPUT->set_env('pagecount', $pages); +$OUTPUT->set_env('exists', $exists); - // update mailboxlist - $mbox = $RCMAIL->storage->get_folder(); - $unseen_count = $msg_count ? $RCMAIL->storage->count($mbox, 'UNSEEN') : 0; - $old_unseen = rcmail_get_unseen_count($mbox); +// update mailboxlist +$unseen_count = $msg_count ? $RCMAIL->storage->count($mbox, 'UNSEEN') : 0; +$old_unseen = rcmail_get_unseen_count($mbox); - if ($old_unseen != $unseen_count) { +if ($old_unseen != $unseen_count) { $OUTPUT->command('set_unread_count', $mbox, $unseen_count, ($mbox == 'INBOX')); rcmail_set_unseen_count($mbox, $unseen_count); - } +} - if ($RCMAIL->action == 'move' && strlen($target)) { +if ($RCMAIL->action == 'move' && strlen($target)) { rcmail_send_unread_count($target, true); - } +} - $OUTPUT->command('set_quota', $RCMAIL->quota_content(null, $multifolder ? $sources[0] : 'INBOX')); - $OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($msg_count), $mbox); +$OUTPUT->command('set_quota', $RCMAIL->quota_content(null, $multifolder ? $sources[0] : 'INBOX')); +$OUTPUT->command('set_rowcount', rcmail_get_messagecount_text($msg_count), $mbox); - if ($threading) { +if ($threading) { $count = rcube_utils::get_input_value('_count', rcube_utils::INPUT_POST); - } +} - // add new rows from next page (if any) - if ($addrows && $count && $uids != '*' && ($jump_back || $nextpage_count > 0)) { +// add new rows from next page (if any) +if ($addrows && $count && $uids != '*' && ($jump_back || $nextpage_count > 0)) { $a_headers = $RCMAIL->storage->list_messages($mbox, NULL, - rcmail_sort_column(), rcmail_sort_order(), $jump_back ? NULL : $count); + rcmail_sort_column(), rcmail_sort_order(), $jump_back ? NULL : $count); rcmail_js_message_list($a_headers, false); - } +} - // set trash folder state - if ($mbox === $trash) { - $OUTPUT->command('set_trash_count', $exists); - } - else if ($target !== null && $target === $trash) { - $OUTPUT->command('set_trash_count', $RCMAIL->storage->count($trash, 'EXISTS', true)); - } +// set trash folder state +if ($mbox === $trash) { + $OUTPUT->command('set_trash_count', $exists); +} +else if ($target !== null && $target === $trash) { + $OUTPUT->command('set_trash_count', $RCMAIL->storage->count($trash, 'EXISTS', true)); } // send response -- Gitblit v1.9.1