From a63f14ec4045e82f47b237663bcf09939a0eadc5 Mon Sep 17 00:00:00 2001 From: Aleksander Machniak <alec@alec.pl> Date: Sat, 29 Aug 2015 01:52:57 -0400 Subject: [PATCH] Emoticons-related code refactoring --- program/include/rcmail.php | 91 +++++++++++++++++++++++++-------------------- 1 files changed, 51 insertions(+), 40 deletions(-) diff --git a/program/include/rcmail.php b/program/include/rcmail.php index 10a9d64..db5fce6 100644 --- a/program/include/rcmail.php +++ b/program/include/rcmail.php @@ -1858,7 +1858,20 @@ */ public function html_editor($mode = '') { - $hook = $this->plugins->exec_hook('html_editor', array('mode' => $mode)); + $spellcheck = intval($this->config->get('enable_spellcheck')); + $spelldict = intval($this->config->get('spellcheck_dictionary')); + $disabled_plugins = array(); + $disabled_buttons = array(); + + if (!$spellcheck) { + $disabled_plugins[] = 'spellchecker'; + } + + $hook = $this->plugins->exec_hook('html_editor', array( + 'mode' => $mode, + 'disabled_plugins' => $disabled_plugins, + 'disabled_buttons' => $disabled_buttons, + )); if ($hook['abort']) { return; @@ -1885,8 +1898,10 @@ 'mode' => $mode, 'lang' => $lang, 'skin_path' => $this->output->get_skin_path(), - 'spellcheck' => intval($this->config->get('enable_spellcheck')), - 'spelldict' => intval($this->config->get('spellcheck_dictionary')) + 'spellcheck' => $spellcheck, // deprecated + 'spelldict' => $spelldict, + 'disabled_plugins' => $hook['disabled_plugins'], + 'disabled_buttons' => $hook['disabled_buttons'], ); $this->output->add_label('selectimage', 'addimage', 'selectmedia', 'addmedia'); @@ -1894,43 +1909,6 @@ $this->output->include_css('program/js/tinymce/roundcube/browser.css'); $this->output->include_script('tinymce/tinymce.min.js'); $this->output->include_script('editor.js'); - } - - /** - * Replaces TinyMCE's emoticon images with plain-text representation - * - * @param string $html HTML content - * - * @return string HTML content - */ - public static function replace_emoticons($html) - { - $emoticons = array( - '8-)' => 'smiley-cool', - ':-#' => 'smiley-foot-in-mouth', - ':-*' => 'smiley-kiss', - ':-X' => 'smiley-sealed', - ':-P' => 'smiley-tongue-out', - ':-@' => 'smiley-yell', - ":'(" => 'smiley-cry', - ':-(' => 'smiley-frown', - ':-D' => 'smiley-laughing', - ':-)' => 'smiley-smile', - ':-S' => 'smiley-undecided', - ':-$' => 'smiley-embarassed', - 'O:-)' => 'smiley-innocent', - ':-|' => 'smiley-money-mouth', - ':-O' => 'smiley-surprised', - ';-)' => 'smiley-wink', - ); - - foreach ($emoticons as $idx => $file) { - // <img title="Cry" src="http://.../program/js/tinymce/plugins/emoticons/img/smiley-cry.gif" border="0" alt="Cry" /> - $search[] = '/<img title="[a-z ]+" src="https?:\/\/[a-z0-9_.\/-]+\/tinymce\/plugins\/emoticons\/img\/'.$file.'.gif"[^>]+\/>/i'; - $replace[] = $idx; - } - - return preg_replace($search, $replace, $html); } /** @@ -2319,6 +2297,39 @@ return file_get_contents($name, false); } + /** + * Converts HTML content into plain text + * + * @param string $html HTML content + * @param array $options Conversion parameters (width, links, charset) + * + * @return string Plain text + */ + public function html2text($html, $options) + { + $default_options = array( + 'links' => true, + 'width' => 75, + 'body' => $html, + 'charset' => RCUBE_CHARSET, + ); + + $options = array_merge($default_options, $options); + + // Plugins may want to modify HTML in another/additional way + $options = $this->plugins->exec_hook('html2text', $options); + + // Convert to text + if (!$options['abort']) { + $converter = new rcube_html2text($options['body'], + false, $options['links'], $options['width'], $options['charset']); + + $options['body'] = rtrim($converter->get_text()); + } + + return $options['body']; + } + /************************************************************************ ********* Deprecated methods (to be removed) ********* -- Gitblit v1.9.1