From a96183883d95dc83a7d0951f5b834e44b062f9cf Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Thu, 04 Mar 2010 02:39:53 -0500 Subject: [PATCH] Changed signature separator when top-posting (#1486330) --- program/steps/mail/compose.inc | 39 +++++++++++++++++++++++++++++---------- 1 files changed, 29 insertions(+), 10 deletions(-) diff --git a/program/steps/mail/compose.inc b/program/steps/mail/compose.inc index 842f28c..52a396b 100644 --- a/program/steps/mail/compose.inc +++ b/program/steps/mail/compose.inc @@ -44,6 +44,8 @@ // process values like "mailto:foo@bar.com?subject=new+message&cc=another" if ($_SESSION['compose']['param']['to']) { + // #1486037: remove "mailto:" prefix + $_SESSION['compose']['param']['to'] = preg_replace('/^mailto:/i', '', $_SESSION['compose']['param']['to']); $mailto = explode('?', $_SESSION['compose']['param']['to']); if (count($mailto) > 1) { $_SESSION['compose']['param']['to'] = $mailto[0]; @@ -128,11 +130,14 @@ else $OUTPUT->set_env('show_sig', false); +// set line length for body wrapping +$LINE_LENGTH = $RCMAIL->config->get('line_length', 75); + if (!empty($msg_uid)) { // similar as in program/steps/mail/show.inc // re-set 'prefer_html' to have possibility to use html part for compose - $CONFIG['prefer_html'] = $CONFIG['htmleditor'] || $compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT; + $CONFIG['prefer_html'] = $CONFIG['prefer_html'] || $CONFIG['htmleditor'] || $compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT; $MESSAGE = new rcube_message($msg_uid); if (!empty($MESSAGE->headers->charset)) @@ -146,6 +151,8 @@ if (!empty($_SESSION['compose']['param']['all'])) $MESSAGE->reply_all = 1; + + $OUTPUT->set_env('compose_mode', 'reply'); } else if ($compose_mode == RCUBE_COMPOSE_DRAFT) { @@ -161,6 +168,7 @@ else if ($compose_mode == RCUBE_COMPOSE_FORWARD) { $_SESSION['compose']['forward_uid'] = $msg_uid; + $OUTPUT->set_env('compose_mode', 'forward'); } } @@ -395,7 +403,7 @@ function rcmail_compose_body($attrib) { - global $RCMAIL, $CONFIG, $OUTPUT, $MESSAGE, $compose_mode; + global $RCMAIL, $CONFIG, $OUTPUT, $MESSAGE, $compose_mode, $LINE_LENGTH; list($form_start, $form_end) = get_form_tags($attrib); unset($attrib['form']); @@ -424,10 +432,20 @@ } else if ($compose_mode) { - if (($isHtml || $compose_mode == RCUBE_COMPOSE_DRAFT) && $MESSAGE->has_html_part()) + $has_html_part = $MESSAGE->has_html_part(); + if (($isHtml || $compose_mode == RCUBE_COMPOSE_DRAFT) && $has_html_part) { $body = $MESSAGE->first_html_part(); $isHtml = true; + } + else if ($has_html_part) + { + // use html part if it has been used for message (pre)viewing + // decrease line length for quoting + $len = $compose_mode == RCUBE_COMPOSE_REPLY ? $LINE_LENGTH-2 : $LINE_LENGTH; + $txt = new html2text($MESSAGE->first_html_part(), false, true, $len); + $body = $txt->get_text(); + $isHtml = false; } else { @@ -505,7 +523,7 @@ JQ(Q(rcube_label('close'))), JQ(Q(rcube_label('revertto'))), JQ(Q(rcube_label('nospellerrors'))), - json_encode($spellcheck_langs), + json_serialize($spellcheck_langs), $lang, $attrib['id'], JS_OBJECT_NAME), 'foot'); @@ -522,7 +540,7 @@ function rcmail_create_reply_body($body, $bodyIsHtml) { - global $RCMAIL, $MESSAGE; + global $RCMAIL, $MESSAGE, $LINE_LENGTH; if (!$bodyIsHtml) { // try to remove the signature @@ -532,7 +550,7 @@ } // soft-wrap message first - $body = rcmail_wrap_quoted($body, 75); + $body = rcmail_wrap_quoted($body, $LINE_LENGTH); $body = rtrim($body, "\r\n"); @@ -554,7 +572,7 @@ // add title line(s) $prefix = rc_wordwrap(sprintf("On %s, %s wrote:\n", $MESSAGE->headers->date, - $MESSAGE->get_header('from')), 76); + $MESSAGE->get_header('from')), $LINE_LENGTH); $suffix = ''; @@ -615,7 +633,7 @@ $body = rcmail_wash_html($body, array('safe' => $MESSAGE->is_safe), $cid_map); $prefix = sprintf( - "<br><br>-------- Original Message --------" . + "<p></p><p>-------- Original Message --------</p>" . "<table border=\"0\" cellpadding=\"0\" cellspacing=\"0\"><tbody>" . "<tr><th align=\"right\" nowrap=\"nowrap\" valign=\"baseline\">Subject: </th><td>%s</td></tr>" . "<tr><th align=\"right\" nowrap=\"nowrap\" valign=\"baseline\">Date: </th><td>%s</td></tr>" . @@ -728,9 +746,10 @@ 'mimetype' => $part->ctype_primary . '/' . $part->ctype_secondary, 'content_id' => $part->content_id, 'data' => $data, - 'path' => $path + 'path' => $path, + 'size' => $path ? filesize($path) : strlen($data), ); - + $attachment = rcmail::get_instance()->plugins->exec_hook('save_attachment', $attachment); if ($attachment['status']) { -- Gitblit v1.9.1