From b0d56e93f542a348b0695705dcae3b07fa2fea09 Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Mon, 06 Jul 2009 13:44:35 -0400 Subject: [PATCH] - simple fix for malformed Content-Disposition (#1485965) --- program/include/rcube_message.php | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/program/include/rcube_message.php b/program/include/rcube_message.php index 513cb4c..9fe9858 100644 --- a/program/include/rcube_message.php +++ b/program/include/rcube_message.php @@ -84,6 +84,9 @@ else { $this->body = $this->imap->get_body($uid); } + + // notify plugins and let them analyze this structured message object + $this->app->plugins->exec_hook('message_load', array('object' => $this)); } @@ -166,17 +169,13 @@ */ function first_html_part() { - $html_part = null; - // check all message parts foreach ($this->mime_parts as $mime_id => $part) { $mimetype = strtolower($part->ctype_primary . '/' . $part->ctype_secondary); if ($mimetype == 'text/html') { - $html_part = $this->imap->get_message_part($this->uid, $mime_id, $part); + return $this->imap->get_message_part($this->uid, $mime_id, $part); } } - - return $html_part; } @@ -342,7 +341,7 @@ // part text/[plain|html] OR message/delivery-status else if (($primary_type == 'text' && ($secondary_type == 'plain' || $secondary_type == 'html') && $mail_part->disposition != 'attachment') || ($primary_type == 'message' && ($secondary_type == 'delivery-status' || $secondary_type == 'disposition-notification'))) { - + // add text part if we're not in alternative mode or if it matches the prefs if (!$this->parse_alternative || ($secondary_type == 'html' && $this->opt['prefer_html']) || @@ -367,7 +366,7 @@ else if ($primary_type == 'protocol') continue; - // part is Microsoft outlook TNEF (winmail.dat) + // part is Microsoft Outlook TNEF (winmail.dat) else if ($primary_type == 'application' && $secondary_type == 'ms-tnef') { foreach ((array)$this->imap->tnef_decode($mail_part, $structure->headers['uid']) as $tnef_part) { $this->mime_parts[$tnef_part->mime_id] = $tnef_part; @@ -375,9 +374,10 @@ } } - // part is file/attachment - else if ($mail_part->disposition == 'attachment' || $mail_part->disposition == 'inline' || + // part is a file/attachment + else if (preg_match('/^(inline|attach)/', $mail_part->disposition) || $mail_part->headers['content-id'] || (empty($mail_part->disposition) && $mail_part->filename)) { + // skip apple resource forks if ($message_ctype_secondary == 'appledouble' && $secondary_type == 'applefile') continue; @@ -393,7 +393,7 @@ $this->inline_parts[] = $mail_part; } } - // is regular attachment + // is a regular attachment else { if (!$mail_part->filename) $mail_part->filename = 'Part '.$mail_part->mime_id; -- Gitblit v1.9.1