From b4f7c665bbe31d4ddbdca8c9f89eedb1d6187582 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Tue, 26 May 2009 08:28:04 -0400 Subject: [PATCH] Tweak default skin with better icons (sprites) and move IE hacks to an external file included by conditional comments --- program/include/rcube_template.php | 49 ++++++++++++++++++++++++++++++++++++------------- 1 files changed, 36 insertions(+), 13 deletions(-) diff --git a/program/include/rcube_template.php b/program/include/rcube_template.php index 557509a..d8c2176 100755 --- a/program/include/rcube_template.php +++ b/program/include/rcube_template.php @@ -34,6 +34,7 @@ var $config; var $framed = false; var $pagetitle = ''; + var $message = null; var $env = array(); var $js_env = array(); var $js_commands = array(); @@ -71,7 +72,7 @@ $this->add_script($javascript, 'head_top'); $this->add_script($javascript_foot, 'foot'); $this->scripts_path = 'program/js/'; - $this->include_script('http://ajax.googleapis.com/ajax/libs/jquery/1.3/jquery.min.js'); + $this->include_script('jquery-1.3.min.js'); $this->include_script('common.js'); $this->include_script('app.js'); @@ -225,14 +226,18 @@ * @param string Message to display * @param string Message type [notice|confirm|error] * @param array Key-value pairs to be replaced in localized text + * @param boolean Override last set message * @uses self::command() */ - public function show_message($message, $type='notice', $vars=NULL) + public function show_message($message, $type='notice', $vars=null, $override=true) { - $this->command( - 'display_message', - rcube_label(array('name' => $message, 'vars' => $vars)), - $type); + if ($override || !$this->message) { + $this->message = $message; + $this->command( + 'display_message', + rcube_label(array('name' => $message, 'vars' => $vars)), + $type); + } } @@ -327,6 +332,20 @@ private function parse($name = 'main', $exit = true) { $skin_path = $this->config['skin_path']; + $plugin = false; + + $temp = explode(".", $name, 2); + if (count($temp) > 1) { + $plugin = $temp[0]; + $name = $temp[1]; + $skin_dir = $plugin . '/skins/' . $this->config['skin']; + $skin_path = $this->app->plugins->dir . $skin_dir; + if (!is_dir($skin_path)) { // fallback to default skin + $skin_dir = $plugin . '/skins/default'; + $skin_path = $this->app->plugins->dir . $skin_dir; + } + } + $path = "$skin_path/templates/$name.html"; // read template file @@ -339,6 +358,12 @@ 'message' => 'Error loading template for '.$name ), true, true); return false; + } + + // replace all path references to plugins/... with the configured plugins dir + // and /this/ to the current plugin skin directory + if ($plugin) { + $templ = preg_replace(array('/\bplugins\//', '/(["\']?)\/this\//'), array($this->app->plugins->url, '\\1'.$this->app->plugins->url.$skin_dir.'/'), $templ); } // parse for specialtags @@ -353,7 +378,7 @@ ); } $output = $this->parse_with_globals($output); - $this->write(trim($output), $skin_path); + $this->write(trim($output)); if ($exit) { exit; } @@ -562,6 +587,7 @@ else { $incl = file_get_contents($path); } + $incl = $this->parse_conditions($incl); return $this->parse_xml($incl); } break; @@ -732,13 +758,13 @@ } // get localized text for labels and titles if ($attrib['title']) { - $attrib['title'] = Q(rcube_label($attrib['title'])); + $attrib['title'] = Q(rcube_label($attrib['title'], $attrib['domain'])); } if ($attrib['label']) { - $attrib['label'] = Q(rcube_label($attrib['label'])); + $attrib['label'] = Q(rcube_label($attrib['label'], $attrib['domain'])); } if ($attrib['alt']) { - $attrib['alt'] = Q(rcube_label($attrib['alt'])); + $attrib['alt'] = Q(rcube_label($attrib['alt'], $attrib['domain'])); } // set title to alt attribute for IE browsers if ($this->browser->ie && $attrib['title'] && !$attrib['alt']) { @@ -770,9 +796,6 @@ } else if (in_array($attrib['command'], $a_static_commands)) { $attrib['href'] = rcmail_url($attrib['command']); - } - else if ($attrib['command'] == 'permaurl' && !empty($this->env['permaurl'])) { - $attrib['href'] = $this->env['permaurl']; } } -- Gitblit v1.9.1