From bba13c33a097ac35ef8a29ef255be3ac47858f78 Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <alec@alec.pl>
Date: Fri, 04 Oct 2013 12:27:32 -0400
Subject: [PATCH] Fix sound notification in Internet Explorer (use mp3 file for IE and other browsers which support audio/mp3 files)
---
plugins/newmail_notifier/package.xml | 4 ++--
plugins/newmail_notifier/composer.json | 2 +-
plugins/newmail_notifier/sound.mp3 | 0
plugins/newmail_notifier/newmail_notifier.js | 8 +++++++-
4 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/plugins/newmail_notifier/composer.json b/plugins/newmail_notifier/composer.json
index 9809237..2ca5db7 100644
--- a/plugins/newmail_notifier/composer.json
+++ b/plugins/newmail_notifier/composer.json
@@ -3,7 +3,7 @@
"type": "roundcube-plugin",
"description": "Supports three methods of notification: 1. Basic - focus browser window and change favicon 2. Sound - play wav file 3. Desktop - display desktop notification (using webkitNotifications feature, supported by Chrome and Firefox with 'HTML5 Notifications' plugin).",
"license": "GNU GPLv3+",
- "version": "0.6",
+ "version": "0.7",
"authors": [
{
"name": "Aleksander Machniak",
diff --git a/plugins/newmail_notifier/newmail_notifier.js b/plugins/newmail_notifier/newmail_notifier.js
index 846bc94..2beacf6 100644
--- a/plugins/newmail_notifier/newmail_notifier.js
+++ b/plugins/newmail_notifier/newmail_notifier.js
@@ -71,7 +71,13 @@
// Sound notification
function newmail_notifier_sound()
{
- var elem, src = 'plugins/newmail_notifier/sound.wav';
+ var elem, src = 'plugins/newmail_notifier/sound',
+ plugin = navigator.mimeTypes ? navigator.mimeTypes['audio/mp3'] : {};
+
+ // Internet Explorer does not support wav files,
+ // support in other browsers depends on enabled plugins,
+ // so we use wav as a fallback
+ src += bw.ie || (plugin && plugin.enabledPlugin) ? '.mp3' : '.wav';
// HTML5
try {
diff --git a/plugins/newmail_notifier/package.xml b/plugins/newmail_notifier/package.xml
index e46c9bc..3d7277b 100644
--- a/plugins/newmail_notifier/package.xml
+++ b/plugins/newmail_notifier/package.xml
@@ -19,9 +19,9 @@
<email>alec@alec.pl</email>
<active>yes</active>
</lead>
- <date>2013-09-12</date>
+ <date>2013-10-04</date>
<version>
- <release>0.6</release>
+ <release>0.7</release>
<api>0.5</api>
</version>
<stability>
diff --git a/plugins/newmail_notifier/sound.mp3 b/plugins/newmail_notifier/sound.mp3
new file mode 100644
index 0000000..3b494a9
--- /dev/null
+++ b/plugins/newmail_notifier/sound.mp3
Binary files differ
--
Gitblit v1.9.1