From c17dc6aa31aaa6e7f61bd25993be55354e428996 Mon Sep 17 00:00:00 2001
From: alecpl <alec@alec.pl>
Date: Sat, 20 Sep 2008 13:21:15 -0400
Subject: [PATCH] #1485385: fix missing close form tag
---
program/steps/settings/manage_folders.inc | 207 +++++++++++++++++++++++++++++----------------------
1 files changed, 117 insertions(+), 90 deletions(-)
diff --git a/program/steps/settings/manage_folders.inc b/program/steps/settings/manage_folders.inc
index 6c056a1..28d02df 100644
--- a/program/steps/settings/manage_folders.inc
+++ b/program/steps/settings/manage_folders.inc
@@ -19,7 +19,7 @@
*/
-$OUTPUT->set_pagetitle(rcube_label('folders'));
+// WARNING: folder names in UI are encoded with UTF-8
// init IMAP connection
$RCMAIL->imap_init(true);
@@ -27,21 +27,15 @@
// subscribe to one or more mailboxes
if ($RCMAIL->action=='subscribe')
{
- if ($mbox = get_input_value('_mbox', RCUBE_INPUT_POST))
+ if ($mbox = get_input_value('_mbox', RCUBE_INPUT_POST, false, 'UTF-7'))
$IMAP->subscribe(array($mbox));
-
- if ($OUTPUT->ajax_call)
- $OUTPUT->remote_response('// subscribed');
}
// unsubscribe one or more mailboxes
else if ($RCMAIL->action=='unsubscribe')
{
- if ($mbox = get_input_value('_mbox', RCUBE_INPUT_POST))
+ if ($mbox = get_input_value('_mbox', RCUBE_INPUT_POST, false, 'UTF-7'))
$IMAP->unsubscribe(array($mbox));
-
- if ($OUTPUT->ajax_call)
- $OUTPUT->remote_response('// unsubscribed');
}
// create a new mailbox
@@ -50,7 +44,7 @@
if (!empty($_POST['_name']))
{
$name = trim(get_input_value('_name', RCUBE_INPUT_POST, FALSE, 'UTF-7'));
- // #1485036 (RFC3501, 5.1.3) TODO: it should be done on read not on write
+ // #1485036 (RFC3501, 5.1.3) TODO: it should be done on read not on write
$name = str_replace('&-', '&', $name);
$create = $IMAP->create_mailbox($name, TRUE);
}
@@ -58,9 +52,15 @@
if ($create && $OUTPUT->ajax_call)
{
$delimiter = $IMAP->get_hierarchy_delimiter();
+ $folderlist = $IMAP->list_unsubscribed();
+ $index = array_search($create, $folderlist);
+ $before = $index !== false && isset($folderlist[$index+1]) ? rcube_charset_convert($folderlist[$index+1], 'UTF-7') : false;
+
+ $create = rcube_charset_convert($create, 'UTF-7');
$foldersplit = explode($delimiter, $create);
- $display_create = str_repeat(' ', substr_count($create, $delimiter)) . rcube_charset_convert($foldersplit[count($foldersplit)-1], 'UTF-7');
- $OUTPUT->command('add_folder_row', $create, $display_create);
+ $display_create = str_repeat(' ', substr_count($create, $delimiter)) . $foldersplit[count($foldersplit)-1];
+
+ $OUTPUT->command('add_folder_row', $create, $display_create, false, $before);
}
else if (!$create)
{
@@ -73,30 +73,50 @@
{
if (!empty($_POST['_folder_oldname']) && !empty($_POST['_folder_newname']))
{
- $name = trim(get_input_value('_folder_newname', RCUBE_INPUT_POST, FALSE, 'UTF-7'));
- // #1485036 (RFC3501, 5.1.3) TODO: it should be done on read not on write
+ $name_utf8 = trim(get_input_value('_folder_newname', RCUBE_INPUT_POST));
+ $oldname_utf8 = get_input_value('_folder_oldname', RCUBE_INPUT_POST);
+ $name = rcube_charset_convert($name_utf8, 'UTF-8', 'UTF-7');
+ $oldname = rcube_charset_convert($oldname_utf8, 'UTF-8', 'UTF-7');
+
+ // #1485036 (RFC3501, 5.1.3) TODO: it should be done on read not on write
$name = str_replace('&-', '&', $name);
- $rename = $IMAP->rename_mailbox(($oldname = get_input_value('_folder_oldname', RCUBE_INPUT_POST)), $name);
+
+ $rename = $IMAP->rename_mailbox($oldname, $name);
}
if ($rename && $OUTPUT->ajax_call)
{
- $a_mboxes = array_unique(array_merge($IMAP->list_mailboxes(), $IMAP->list_unsubscribed()));
+ $folderlist = $IMAP->list_unsubscribed();
$delimiter = $IMAP->get_hierarchy_delimiter();
+
+ $regexp = '/^' . preg_quote($rename . $delimiter, '/') . '/';
+
+ // subfolders
+ for ($x=sizeof($folderlist)-1; $x>=0; $x--)
+ {
+ if (preg_match($regexp, $folderlist[$x]))
+ {
+ $oldfolder = $oldname . $delimiter . preg_replace($regexp, '', $folderlist[$x]);
+ $foldersplit = explode($delimiter, $folderlist[$x]);
+ $level = count($foldersplit) - 1;
+ $display_rename = str_repeat(' ', $level)
+ . rcube_charset_convert($foldersplit[$level], 'UTF-7');
+
+ $before = isset($folderlist[$x+1]) ? rcube_charset_convert($folderlist[$x+1], 'UTF-7') : false;
+
+ $OUTPUT->command('replace_folder_row', rcube_charset_convert($oldfolder, 'UTF-7'),
+ rcube_charset_convert($folderlist[$x], 'UTF-7'), $display_rename, $before);
+ }
+ }
+
$foldersplit = explode($delimiter, $rename);
$level = count($foldersplit) - 1;
$display_rename = str_repeat(' ', $level) . rcube_charset_convert($foldersplit[$level], 'UTF-7');
- $OUTPUT->command('replace_folder_row', $oldname, $rename, $display_rename);
+ $index = array_search($rename, $folderlist);
+ $before = $index !== false && isset($folderlist[$index+1]) ? rcube_charset_convert($folderlist[$index+1], 'UTF-7') : false;
- foreach ($a_mboxes as $mbox)
- if (preg_match('/^'.preg_quote($oldname . $delimiter, '/').'/', $mbox))
- {
- $c_rename = preg_replace('/^'.preg_quote($oldname, '/').'/', $rename, $mbox);
- $foldersplit = explode($delimiter, $c_rename);
- $level = count($foldersplit) - 1;
- $display_rename = str_repeat(' ', $level) . rcube_charset_convert($foldersplit[$level], 'UTF-7');
- $OUTPUT->command('replace_folder_row', $mbox, $c_rename, $display_rename);
- }
+ $OUTPUT->command('replace_folder_row', $oldname_utf8, rcube_charset_convert($rename, 'UTF-7'), $display_rename, $before);
+
$OUTPUT->command('reset_folder_rename');
}
else if (!$rename && $OUTPUT->ajax_call)
@@ -111,22 +131,23 @@
// delete an existing IMAP mailbox
else if ($RCMAIL->action=='delete-folder')
{
- $a_mboxes = array_merge($IMAP->list_mailboxes(), $IMAP->list_unsubscribed());
+ $a_mboxes = $IMAP->list_unsubscribed();
$delimiter = $IMAP->get_hierarchy_delimiter();
+
+ $mboxes_utf8 = get_input_value('_mboxes', RCUBE_INPUT_POST);
+ $mboxes = rcube_charset_convert($mboxes_utf8, 'UTF-8', 'UTF-7');
- if ($mboxes = get_input_value('_mboxes', RCUBE_INPUT_POST))
+ if ($mboxes)
$deleted = $IMAP->delete_mailbox(array($mboxes));
if ($OUTPUT->ajax_call && $deleted)
{
- $OUTPUT->command('remove_folder_row', get_input_value('_mboxes', RCUBE_INPUT_POST));
+ $OUTPUT->command('remove_folder_row', $mboxes_utf8);
foreach ($a_mboxes as $mbox)
{
- $regex = get_input_value('_mboxes', RCUBE_INPUT_POST) . $delimiter;
- $regex = preg_quote($regex, '/');
- if (preg_match('/^'. $regex .'/', $mbox))
+ if (preg_match('/^'. preg_quote($mboxes.$delimiter, '/') .'/', $mbox))
{
- $OUTPUT->command('remove_folder_row', $mbox);
+ $OUTPUT->command('remove_folder_row', rcube_charset_convert($mbox, 'UTF-7'));
}
}
$OUTPUT->show_message('folderdeleted', 'confirmation');
@@ -149,23 +170,17 @@
list($form_start, $form_end) = get_form_tags($attrib, 'folders');
unset($attrib['form']);
-
if (!$attrib['id'])
$attrib['id'] = 'rcmSubscriptionlist';
- // allow the following attributes to be added to the <table> tag
- $attrib_str = create_attrib_string($attrib, array('style', 'class', 'id', 'cellpadding', 'cellspacing', 'border', 'summary'));
-
- $out = "$form_start\n<table" . $attrib_str . ">\n";
-
+ $table = new html_table();
// add table header
- $out .= "<thead><tr>\n";
- $out .= sprintf('<td class="name">%s</td><td class="msgcount">%s</td><td class="subscribed">%s</td>'.
- '<td class="rename"> </td><td class="delete"> </td>',
- rcube_label('foldername'), rcube_label('messagecount'), rcube_label('subscribed'));
-
- $out .= "\n</tr></thead>\n<tbody>\n";
+ $table->add_header('name', rcube_label('foldername'));
+ $table->add_header('msgcount', rcube_label('messagecount'));
+ $table->add_header('subscribed', rcube_label('subscribed'));
+ $table->add_header('rename', ' ');
+ $table->add_header('delete', ' ');
// get folders from server
@@ -174,69 +189,80 @@
$a_unsubscribed = $IMAP->list_unsubscribed();
$a_subscribed = $IMAP->list_mailboxes();
$delimiter = $IMAP->get_hierarchy_delimiter();
- $a_js_folders = array();
-
- $checkbox_subscribe = new html_checkbox(array('name' => '_subscribed[]', 'onclick' => JS_OBJECT_NAME.".command(this.checked?'subscribe':'unsubscribe',this.value)"));
+ $a_js_folders = $seen_folders = $list_folders = array();
+
+ // pre-process folders list
+ foreach ($a_unsubscribed as $i => $folder) {
+ $foldersplit = explode($delimiter, $folder);
+ $name = rcube_charset_convert(array_pop($foldersplit), 'UTF-7');
+ $parent_folder = join($delimiter, $foldersplit);
+ $level = count($foldersplit);
+
+ // add a "virtual" parent folder
+ if ($parent_folder && !$seen[$parent_folder]++) {
+ $parent_name = rcube_charset_convert($foldersplit[$level-1], 'UTF-7');
+ $list_folders[] = array('id' => $parent_folder, 'name' => $parent_name, 'level' => $level-1, 'virtual' => true);
+ }
+
+ $list_folders[] = array('id' => $folder, 'name' => $name, 'level' => $level);
+ $seen[$folder]++;
+ }
+
+ $checkbox_subscribe = new html_checkbox(array(
+ 'name' => '_subscribed[]',
+ 'onclick' => JS_OBJECT_NAME.".command(this.checked?'subscribe':'unsubscribe',this.value)",
+ ));
if (!empty($attrib['deleteicon']))
- $del_button = sprintf('<img src="%s%s" alt="%s" border="0" />', $CONFIG['skin_path'], $attrib['deleteicon'], rcube_label('delete'));
+ $del_button = html::img(array('src' => $CONFIG['skin_path'] . $attrib['deleteicon'], 'alt' => rcube_label('delete'), 'border' => 0));
else
$del_button = rcube_label('delete');
if (!empty($attrib['renameicon']))
- $edit_button = sprintf('<img src="%s%s" alt="%s" border="0" />', $CONFIG['skin_path'], $attrib['renameicon'], rcube_label('rename'));
+ $edit_button = html::img(array('src' => $CONFIG['skin_path'] . $attrib['renameicon'], 'alt' => rcube_label('rename'), 'border' => 0));
else
$del_button = rcube_label('rename');
-
+
// create list of available folders
- foreach ($a_unsubscribed as $i => $folder)
- {
- $subscribed = in_array($folder, $a_subscribed);
- $protected = ($CONFIG['protect_default_folders'] == TRUE && in_array($folder,$CONFIG['default_imap_folders']));
- $zebra_class = $i%2 ? 'even' : 'odd';
- $folder_js = JQ($folder);
- $foldersplit = explode($delimiter, $folder);
- $level = count($foldersplit) - 1;
- $display_folder = str_repeat(' ', $level) . rcube_charset_convert($foldersplit[$level], 'UTF-7');
- $folder_html = $CONFIG['protect_default_folders'] && in_array($folder, $CONFIG['default_imap_folders']) ? rcmail_localize_foldername($folder) : $display_folder;
+ foreach ($list_folders as $i => $folder) {
+ $idx = $i + 1;
+ $subscribed = in_array($folder['id'], $a_subscribed);
+ $protected = ($folder['virtual'] || ($CONFIG['protect_default_folders'] == true && in_array($folder['id'], $CONFIG['default_imap_folders'])));
+ $classes = array($i%2 ? 'even' : 'odd');
+ $folder_js = JQ($folder['id']);
+ $display_folder = str_repeat(' ', $folder['level']) . ($protected ? rcmail_localize_foldername($folder['id']) : $folder['name']);
+ $folder_utf8 = rcube_charset_convert($folder['id'], 'UTF-7');
- if (!$protected)
- $a_js_folders['rcmrow'.($i+1)] = array($folder, rcube_charset_convert($folder, 'UTF-7'));
-
- $out .= sprintf('<tr id="rcmrow%d" class="%s"><td class="name">%s</td><td class="msgcount">%d</td>',
- $i+1,
- $zebra_class,
- Q($folder_html),
- $IMAP->messagecount($folder));
-
- if ($protected)
- $out .= '<td class="subscribed"> '.($subscribed ? '•' : '-').'</td>';
- else
- $out .= '<td class="subscribed">'.$checkbox_subscribe->show($subscribed?$folder:'', array('value' => $folder)).'</td>';
-
+ if ($folder['virtual'])
+ $classes[] = 'virtual';
+
+ $table->add_row(array('id' => 'rcmrow'.$idx, 'class' => join(' ', $classes)));
+
+ $table->add('name', Q($display_folder));
+ $table->add('msgcount', ($folder['virtual'] ? '' : $IMAP->messagecount($folder['id'])));
+ $table->add('subscribed', $protected ? ($subscribed ? ' •' : ' -') :
+ $checkbox_subscribe->show(($subscribed ? $folder_utf8 : ''), array('value' => $folder_utf8)));
+
// add rename and delete buttons
- if (!$protected)
- $out .= sprintf('<td class="rename"><a href="#rename" title="%s">%s</a>'.
- '<td class="delete"><a href="#delete" title="%s">%s</a></td>',
- rcube_label('renamefolder'),
- $edit_button,
- rcube_label('deletefolder'),
- $del_button);
- else
- $out .= '<td></td><td></td>';
-
- $out .= "</tr>\n";
+ if (!$protected) {
+ $table->add('rename', html::a(array('href' => "#rename", 'title' => rcube_label('renamefolder')), $edit_button));
+ $table->add('delete', html::a(array('href' => "#delete", 'title' => rcube_label('deletefolder')), $del_button));
}
+ else {
+ $table->add(null, '');
+ $table->add(null, '');
+ }
+
+ $a_js_folders['rcmrow'.$idx] = array($folder_utf8, $display_folder, $protected);
+ }
- $out .= "</tbody>\n</table>";
- $out .= "\n$form_end";
$OUTPUT->add_gui_object('subscriptionlist', $attrib['id']);
$OUTPUT->set_env('subscriptionrows', $a_js_folders);
$OUTPUT->set_env('defaultfolders', $CONFIG['default_imap_folders']);
$OUTPUT->set_env('delimiter', $delimiter);
- return $out;
+ return $form_start . $table->show($attrib) . $form_end;
}
@@ -309,6 +335,7 @@
return $out;
}
+$OUTPUT->set_pagetitle(rcube_label('folders'));
$OUTPUT->include_script('list.js');
// register UI objects
@@ -319,7 +346,7 @@
));
// add some labels to client
-rcube_add_label('deletefolderconfirm','addsubfolderhint');
+$OUTPUT->add_label('deletefolderconfirm','addsubfolderhint','forbiddencharacter','folderdeleting','folderrenaming','foldercreating');
$OUTPUT->send('managefolders');
?>
--
Gitblit v1.9.1