From c33e08a3cfd1b33cbe9f50f199a77f1f264cfcdd Mon Sep 17 00:00:00 2001 From: alecpl <alec@alec.pl> Date: Thu, 08 Jul 2010 13:05:39 -0400 Subject: [PATCH] - css improvements --- program/include/rcube_plugin_api.php | 136 ++++++++++++++++++++++++++++++++++----------- 1 files changed, 102 insertions(+), 34 deletions(-) diff --git a/program/include/rcube_plugin_api.php b/program/include/rcube_plugin_api.php index 4780f2e..9053a0d 100644 --- a/program/include/rcube_plugin_api.php +++ b/program/include/rcube_plugin_api.php @@ -15,14 +15,14 @@ | Author: Thomas Bruederli <roundcube@gmail.com> | +-----------------------------------------------------------------------+ - $Id: $ + $Id$ */ /** * The plugin loader and global API * - * @package Core + * @package PluginAPI */ class rcube_plugin_api { @@ -34,12 +34,14 @@ public $handlers = array(); private $plugins = array(); + private $tasks = array(); private $actions = array(); private $actionmap = array(); private $objectsmap = array(); private $template_contents = array(); - private $required_plugins = array('filesystem_attachments'); + private $required_plugins = array('filesystem_attachments'); + private $active_hook = false; /** * This implements the 'singleton' design pattern @@ -61,15 +63,14 @@ */ private function __construct() { - $rcmail = rcmail::get_instance(); - $this->dir = realpath($rcmail->config->get('plugins_dir')); + $this->dir = INSTALL_PATH . $this->url; } /** * Load and init all enabled plugins * - * This has to be done after rcmail::load_gui() or rcmail::init_json() + * This has to be done after rcmail::load_gui() or rcmail::json_init() * was called because plugins need to have access to rcmail->output */ public function init() @@ -90,17 +91,21 @@ if (class_exists($plugin_name, false)) { $plugin = new $plugin_name($this); // check inheritance and task specification - if (is_subclass_of($plugin, 'rcube_plugin') && (!$plugin->task || $plugin->task == $rcmail->task)) { + if (is_subclass_of($plugin, 'rcube_plugin') && (!$plugin->task || preg_match('/^('.$plugin->task.')$/i', $rcmail->task))) { $plugin->init(); $this->plugins[] = $plugin; } } else { - raise_error(array('code' => 520, 'type' => 'php', 'message' => "No plugin class $plugin_name found in $fn"), true, false); + raise_error(array('code' => 520, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "No plugin class $plugin_name found in $fn"), true, false); } } else { - raise_error(array('code' => 520, 'type' => 'php', 'message' => "Failed to load plugin file $fn"), true, false); + raise_error(array('code' => 520, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Failed to load plugin file $fn"), true, false); } } @@ -118,15 +123,17 @@ if (!$loaded) { $fn = $plugins_dir->path . DIRECTORY_SEPARATOR . $plugin_name . DIRECTORY_SEPARATOR . $plugin_name . '.php'; if (file_exists($fn)) { - include($fn); + include_once($fn); if (class_exists($plugin_name, false)) { $plugin = new $plugin_name($this); // check inheritance if (is_subclass_of($plugin, 'rcube_plugin')) { - $plugin->init(); - $this->plugins[] = $plugin; - $loaded = true; + if (!$plugin->task || preg_match('/('.$plugin->task.')/i', $rcmail->task)) { + $plugin->init(); + $this->plugins[] = $plugin; + } + $loaded = true; } } } @@ -134,7 +141,9 @@ // trigger fatal error if still not loaded if (!$loaded) { - raise_error(array('code' => 520, 'type' => 'php', 'message' => "Requried plugin $plugin_name was not loaded"), true, true); + raise_error(array('code' => 520, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Requried plugin $plugin_name was not loaded"), true, true); } } @@ -142,15 +151,6 @@ $this->register_hook('template_container', array($this, 'template_container_hook')); // maybe also register a shudown function which triggers shutdown functions of all plugin objects - - - // call imap_init right now - // (should actually be done in rcmail::imap_init() but plugins are not initialized then) - if ($rcmail->imap) { - $hook = $this->exec_hook('imap_init', array('fetch_headers' => $rcmail->imap->fetch_add_headers)); - if ($hook['fetch_headers']) - $rcmail->imap->fetch_add_headers = $hook['fetch_headers']; - } } @@ -165,7 +165,9 @@ if (is_callable($callback)) $this->handlers[$hook][] = $callback; else - raise_error(array('code' => 521, 'type' => 'php', 'message' => "Invalid callback function for $hook"), true, false); + raise_error(array('code' => 521, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Invalid callback function for $hook"), true, false); } @@ -179,7 +181,11 @@ */ public function exec_hook($hook, $args = array()) { + if (!is_array($args)) + $args = array('arg' => $args); + $args += array('abort' => false); + $this->active_hook = $hook; foreach ((array)$this->handlers[$hook] as $callback) { $ret = call_user_func($callback, $args); @@ -190,6 +196,7 @@ break; } + $this->active_hook = false; return $args; } @@ -200,11 +207,14 @@ * @param string Action name (_task=mail&_action=plugin.foo) * @param string Plugin name that registers this action * @param mixed Callback: string with global function name or array($obj, 'methodname') + * @param string Task name registered by this plugin */ - public function register_action($action, $owner, $callback) + public function register_action($action, $owner, $callback, $task = null) { // check action name - if (strpos($action, 'plugin.') !== 0) + if ($task) + $action = $task.'.'.$action; + else if (strpos($action, 'plugin.') !== 0) $action = 'plugin.'.$action; // can register action only if it's not taken or registered by myself @@ -213,7 +223,9 @@ $this->actionmap[$action] = $owner; } else { - raise_error(array('code' => 523, 'type' => 'php', 'message' => "Cannot register action $action; already taken by another plugin"), true, false); + raise_error(array('code' => 523, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Cannot register action $action; already taken by another plugin"), true, false); } } @@ -230,7 +242,9 @@ call_user_func($this->actions[$action]); } else { - raise_error(array('code' => 524, 'type' => 'php', 'message' => "No handler found for action $action"), true, true); + raise_error(array('code' => 524, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "No handler found for action $action"), true, true); } } @@ -254,8 +268,62 @@ $this->objectsmap[$name] = $owner; } else { - raise_error(array('code' => 525, 'type' => 'php', 'message' => "Cannot register template handler $name; already taken by another plugin"), true, false); + raise_error(array('code' => 525, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Cannot register template handler $name; already taken by another plugin"), true, false); } + } + + + /** + * Register this plugin to be responsible for a specific task + * + * @param string Task name (only characters [a-z0-9_.-] are allowed) + * @param string Plugin name that registers this action + */ + public function register_task($task, $owner) + { + if ($task != asciiwords($task)) { + raise_error(array('code' => 526, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Invalid task name: $task. Only characters [a-z0-9_.-] are allowed"), true, false); + } + else if (in_array($task, rcmail::$main_tasks)) { + raise_error(array('code' => 526, 'type' => 'php', + 'file' => __FILE__, 'line' => __LINE__, + 'message' => "Cannot register taks $task; already taken by another plugin or the application itself"), true, false); + } + else { + $this->tasks[$task] = $owner; + rcmail::$main_tasks[] = $task; + return true; + } + + return false; + } + + + /** + * Checks whether the given task is registered by a plugin + * + * @return boolean True if registered, otherwise false + */ + public function is_plugin_task($task) + { + return $this->tasks[$task] ? true : false; + } + + + /** + * Check if a plugin hook is currently processing. + * Mainly used to prevent loops and recursion. + * + * @param string Hook to check (optional) + * @return boolean True if any/the given hook is currently processed, otherwise false + */ + public function is_processing($hook = null) + { + return $this->active_hook && (!$hook || $this->active_hook == $hook); } /** @@ -264,7 +332,7 @@ public function include_script($fn) { if ($this->output->type == 'html') { - $src = $this->ressource_url($fn); + $src = $this->resource_url($fn); $this->output->add_header(html::tag('script', array('type' => "text/javascript", 'src' => $src))); } } @@ -275,7 +343,7 @@ public function include_stylesheet($fn) { if ($this->output->type == 'html') { - $src = $this->ressource_url($fn); + $src = $this->resource_url($fn); $this->output->add_header(html::tag('link', array('rel' => "stylesheet", 'type' => "text/css", 'href' => $src))); } } @@ -294,15 +362,15 @@ private function template_container_hook($attrib) { $container = $attrib['name']; - return array('content' => $this->template_contents[$container]); + return array('content' => $attrib['content'] . $this->template_contents[$container]); } /** * Make the given file name link into the plugins directory */ - private function ressource_url($fn) + private function resource_url($fn) { - if ($fn[0] != '/' && !eregi('^https?://', $fn)) + if ($fn[0] != '/' && !preg_match('|^https?://|i', $fn)) return $this->url . $fn; else return $fn; -- Gitblit v1.9.1