From c5418bd82c081d7c89012f2d6e497535224ad29d Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Sun, 09 Mar 2008 13:54:20 -0400 Subject: [PATCH] Correctly encode mailbox names (#1484313) --- program/js/app.js | 25 +++++++++---------------- 1 files changed, 9 insertions(+), 16 deletions(-) diff --git a/program/js/app.js b/program/js/app.js index 0715724..ec5fac3 100644 --- a/program/js/app.js +++ b/program/js/app.js @@ -712,7 +712,7 @@ break; case 'load-attachment': - var qstring = '_mbox='+this.env.mailbox+'&_uid='+this.env.uid+'&_part='+props.part; + var qstring = '_mbox='+urlencode(this.env.mailbox)+'&_uid='+this.env.uid+'&_part='+props.part; // open attachment in frame if it's of a supported mimetype if (this.env.uid && props.mimetype && find_in_array(props.mimetype, this.mimetypes)>=0) @@ -1095,15 +1095,11 @@ // onmouseup handler for folder list item this.folder_mouse_up = function(id) { - // Hide message command buttons until a message is selected - this.enable_command('reply', 'reply-all', 'forward', 'delete', 'mark', 'print', false); - if (this.drag_active) { this.unfocus_folder(id); this.command('moveto', id); } - }; this.click_on_list = function(e) @@ -1387,11 +1383,8 @@ this.move_messages = function(mbox) { // exit if current or no mailbox specified or if selection is empty - if (!mbox || !this.env.uid || mbox==this.env.mailbox) - { - if (!this.message_list || !this.message_list.get_selection().length) - return; - } + if (!mbox || mbox == this.env.mailbox || (!this.env.uid && (!this.message_list || !this.message_list.get_selection().length))) + return; var lock = false; var add_url = '&_target_mbox='+urlencode(mbox)+'&_from='+(this.env.action ? this.env.action : ''); @@ -1404,6 +1397,9 @@ } else this.show_contentframe(false); + + // Hide message command buttons until a message is selected + this.enable_command('reply', 'reply-all', 'forward', 'delete', 'mark', 'print', false); this._with_selected_messages('moveto', lock, add_url); }; @@ -2014,7 +2010,7 @@ // reset vars this.env.current_page = 1; this.set_busy(true, 'searching'); - this.http_request('search', '_q='+urlencode(value)+(this.env.mailbox ? '&_mbox='+this.env.mailbox : '')+(this.env.source ? '&_source='+urlencode(this.env.source) : ''), true); + this.http_request('search', '_q='+urlencode(value)+(this.env.mailbox ? '&_mbox='+urlencode(this.env.mailbox) : '')+(this.env.source ? '&_source='+urlencode(this.env.source) : ''), true); } return true; }; @@ -3287,11 +3283,8 @@ if (!this.gui_objects.mailboxlist) return false; - var reg, text_obj; - var item = this.get_folder_li(mbox); - mbox = String(mbox).toLowerCase().replace(this.identifier_expr, ''); - - if (item && item.className && item.className.indexOf('mailbox '+mbox)>=0) + var reg, text_obj, item; + if (item = this.get_folder_li(mbox)) { // set new text text_obj = item.firstChild; -- Gitblit v1.9.1