From dbd069154a00a563464b4f2dd4088cabdf5fc652 Mon Sep 17 00:00:00 2001
From: alecpl <alec@alec.pl>
Date: Thu, 22 Apr 2010 04:58:51 -0400
Subject: [PATCH] - code cleanup
---
program/include/rcube_user.php | 157 ++++++++++++++--------------------------------------
1 files changed, 42 insertions(+), 115 deletions(-)
diff --git a/program/include/rcube_user.php b/program/include/rcube_user.php
index c2cad11..2d0eff2 100644
--- a/program/include/rcube_user.php
+++ b/program/include/rcube_user.php
@@ -16,7 +16,7 @@
| Author: Thomas Bruederli <roundcube@gmail.com> |
+-----------------------------------------------------------------------+
- $Id: rcube_user.inc 933 2007-11-29 14:17:32Z thomasb $
+ $Id$
*/
@@ -47,7 +47,7 @@
if ($id && !$sql_arr)
{
- $sql_result = $this->db->query("SELECT * FROM ".get_table_name('users')." WHERE user_id=?", $id);
+ $sql_result = $this->db->query("SELECT * FROM ".get_table_name('users')." WHERE user_id=?", $id);
$sql_arr = $this->db->fetch_assoc($sql_result);
}
@@ -111,19 +111,22 @@
if (!isset($old_prefs[$key]) && ($value == $config->get($key)))
unset($save_prefs[$key]);
}
-
+
+ $save_prefs = serialize($save_prefs);
+
$this->db->query(
"UPDATE ".get_table_name('users')."
SET preferences=?,
language=?
WHERE user_id=?",
- serialize($save_prefs),
+ $save_prefs,
$_SESSION['language'],
$this->ID);
$this->language = $_SESSION['language'];
if ($this->db->affected_rows()) {
- $config->merge($a_user_prefs);
+ $config->set_user_prefs($a_user_prefs);
+ $this->data['preferences'] = $save_prefs;
return true;
}
@@ -154,8 +157,7 @@
// get contacts from DB
$sql_result = $this->db->query(
"SELECT * FROM ".get_table_name('identities')."
- WHERE del<>1
- AND user_id=?
+ WHERE del<>1 AND user_id=?
$sql_add
ORDER BY ".$this->db->quoteIdentifier('standard')." DESC, name ASC, identity_id ASC",
$this->ID);
@@ -192,7 +194,7 @@
$query_params[] = $this->ID;
$sql = "UPDATE ".get_table_name('identities')."
- SET ".join(', ', $query_cols)."
+ SET changed=".$this->db->now().", ".join(', ', $query_cols)."
WHERE identity_id=?
AND user_id=?
AND del<>1";
@@ -215,6 +217,8 @@
if (!$this->ID)
return false;
+ unset($data['user_id']);
+
$insert_cols = $insert_values = array();
foreach ((array)$data as $col => $value)
{
@@ -225,8 +229,8 @@
$insert_values[] = $this->ID;
$sql = "INSERT INTO ".get_table_name('identities')."
- (".join(', ', $insert_cols).")
- VALUES (".join(', ', array_pad(array(), sizeof($insert_values), '?')).")";
+ (changed, ".join(', ', $insert_cols).")
+ VALUES (".$this->db->now().", ".join(', ', array_pad(array(), sizeof($insert_values), '?')).")";
call_user_func_array(array($this->db, 'query'),
array_merge(array($sql), $insert_values));
@@ -246,12 +250,9 @@
if (!$this->ID)
return false;
- if (!$this->ID || $this->ID == '')
- return false;
-
- $sql_result = $this->db->query("SELECT count(*) AS ident_count FROM " .
- get_table_name('identities') .
- " WHERE user_id = ? AND del <> 1",
+ $sql_result = $this->db->query(
+ "SELECT count(*) AS ident_count FROM ".get_table_name('identities')."
+ WHERE user_id = ? AND del <> 1",
$this->ID);
$sql_arr = $this->db->fetch_assoc($sql_result);
@@ -260,7 +261,7 @@
$this->db->query(
"UPDATE ".get_table_name('identities')."
- SET del=1
+ SET del=1, changed=".$this->db->now()."
WHERE user_id=?
AND identity_id=?",
$this->ID,
@@ -361,7 +362,7 @@
// try to resolve user in virtuser table and file
if ($email_list = self::user2email($user, false, true)) {
- $user_email = is_array($email_list[0]) ? $email_list[0][0] : $email_list[0];
+ $user_email = is_array($email_list[0]) ? $email_list[0]['email'] : $email_list[0];
}
$data = $rcmail->plugins->exec_hook('create_user',
@@ -409,36 +410,26 @@
// create new identities records
$standard = 1;
foreach ($email_list as $row) {
+ $record = array();
+
if (is_array($row)) {
- $email = $row[0];
- $name = $row[1] ? $row[1] : $user_name;
+ $record = $row;
}
else {
- $email = $row;
- $name = $user_name;
+ $record['email'] = $row;
}
- $plugin = $rcmail->plugins->exec_hook('create_identity', array(
- 'login' => true,
- 'record' => array(
- 'user_id' => $user_id,
- 'name' => strip_newlines($name),
- 'email' => $email,
- 'standard' => $standard,
- 'signature' => '',
- ),
- ));
+ if (empty($record['name']))
+ $record['name'] = $user_name;
+ $record['name'] = strip_newlines($record['name']);
+ $record['user_id'] = $user_id;
+ $record['standard'] = $standard;
+
+ $plugin = $rcmail->plugins->exec_hook('create_identity',
+ array('login' => true, 'record' => $record));
if (!$plugin['abort'] && $plugin['record']['email']) {
- $dbh->query(
- "INSERT INTO ".get_table_name('identities')."
- (user_id, del, standard, name, email, signature)
- VALUES (?, 0, ?, ?, ?, ?)",
- $user_id,
- $plugin['record']['standard'],
- $plugin['record']['name'] != NULL ? $plugin['record']['name'] : '',
- $plugin['record']['email'],
- $plugin['record']['signature']);
+ $rcmail->user->insert_identity($plugin['record']);
}
$standard = 0;
}
@@ -458,29 +449,23 @@
/**
- * Resolve username using a virtuser file
+ * Resolve username using a virtuser plugins
*
* @param string E-mail address to resolve
* @return string Resolved IMAP username
*/
static function email2user($email)
{
- $r = self::findinvirtual('/^' . preg_quote($email, '/') . '\s/');
+ $rcmail = rcmail::get_instance();
+ $plugin = $rcmail->plugins->exec_hook('email2user',
+ array('email' => $email, 'user' => NULL));
- for ($i=0; $i<count($r); $i++)
- {
- $data = trim($r[$i]);
- $arr = preg_split('/\s+/', $data);
- if (count($arr) > 0)
- return trim($arr[count($arr)-1]);
- }
-
- return NULL;
+ return $plugin['user'];
}
/**
- * Resolve e-mail address from virtuser file/table
+ * Resolve e-mail address from virtuser plugins
*
* @param string User name
* @param boolean If true returns first found entry
@@ -489,70 +474,12 @@
*/
static function user2email($user, $first=true, $extended=false)
{
- $result = array();
$rcmail = rcmail::get_instance();
- $dbh = $rcmail->get_dbh();
+ $plugin = $rcmail->plugins->exec_hook('user2email',
+ array('email' => NULL, 'user' => $user,
+ 'first' => $first, 'extended' => $extended));
- // SQL lookup
- if ($virtuser_query = $rcmail->config->get('virtuser_query')) {
- $sql_result = $dbh->query(preg_replace('/%u/', $dbh->escapeSimple($user), $virtuser_query));
- while ($sql_arr = $dbh->fetch_array($sql_result))
- if (strpos($sql_arr[0], '@')) {
- $result[] = ($extended && count($sql_arr) > 1) ? $sql_arr : $sql_arr[0];
- if ($first)
- return $result[0];
- }
- }
- // File lookup
- $r = self::findinvirtual('/\s' . preg_quote($user, '/') . '\s*$/');
- for ($i=0; $i<count($r); $i++)
- {
- $data = $r[$i];
- $arr = preg_split('/\s+/', $data);
- if (count($arr) > 0 && strpos($arr[0], '@'))
- {
- $result[] = trim(str_replace('\\@', '@', $arr[0]));
-
- if ($first)
- return $result[0];
- }
- }
-
- return empty($result) ? NULL : $result;
+ return empty($plugin['email']) ? NULL : $plugin['email'];
}
-
- /**
- * Find matches of the given pattern in virtuser file
- *
- * @param string Regular expression to search for
- * @return array Matching entries
- */
- private static function findinvirtual($pattern)
- {
- $result = array();
- $virtual = null;
-
- if ($virtuser_file = rcmail::get_instance()->config->get('virtuser_file'))
- $virtual = file($virtuser_file);
-
- if (empty($virtual))
- return $result;
-
- // check each line for matches
- foreach ($virtual as $line)
- {
- $line = trim($line);
- if (empty($line) || $line{0}=='#')
- continue;
-
- if (preg_match($pattern, $line))
- $result[] = $line;
- }
-
- return $result;
- }
-
}
-
-
--
Gitblit v1.9.1