From bd0551b22076b82a6d49e9f7a2b2e0c90a1b2326 Mon Sep 17 00:00:00 2001
From: Aleksander Machniak <alec@alec.pl>
Date: Fri, 05 Feb 2016 07:25:27 -0500
Subject: [PATCH] Secure also downloads of addressbook exports, managesieve script exports and Enigma keys exports
---
plugins/password/drivers/ldap_simple.php | 119 ++++++++++++++++++++++++++++++++++++++++++++++++++---------
1 files changed, 100 insertions(+), 19 deletions(-)
diff --git a/plugins/password/drivers/ldap_simple.php b/plugins/password/drivers/ldap_simple.php
index 4a53582..5b82205 100644
--- a/plugins/password/drivers/ldap_simple.php
+++ b/plugins/password/drivers/ldap_simple.php
@@ -9,25 +9,57 @@
*
* @version 2.0
* @author Wout Decre <wout@canodus.be>
+ * @author Aleksander Machniak <machniak@kolabsys.com>
+ *
+ * Copyright (C) 2005-2014, The Roundcube Dev Team
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see http://www.gnu.org/licenses/.
*/
class rcube_ldap_simple_password
{
+ private $debug = false;
+
function save($curpass, $passwd)
{
$rcmail = rcmail::get_instance();
+ $this->debug = $rcmail->config->get('ldap_debug');
+
+ $ldap_host = $rcmail->config->get('password_ldap_host');
+ $ldap_port = $rcmail->config->get('password_ldap_port');
+
+ $this->_debug("C: Connect to $ldap_host:$ldap_port");
+
// Connect
- if (!$ds = ldap_connect($rcmail->config->get('password_ldap_host'), $rcmail->config->get('password_ldap_port'))) {
- ldap_unbind($ds);
+ if (!$ds = ldap_connect($ldap_host, $ldap_port)) {
+ $this->_debug("S: NOT OK");
+
+ rcube::raise_error(array(
+ 'code' => 100, 'type' => 'ldap',
+ 'file' => __FILE__, 'line' => __LINE__,
+ 'message' => "Could not connect to LDAP server"
+ ),
+ true);
+
return PASSWORD_CONNECT_ERROR;
}
+ $this->_debug("S: OK");
+
// Set protocol version
- if (!ldap_set_option($ds, LDAP_OPT_PROTOCOL_VERSION, $rcmail->config->get('password_ldap_version'))) {
- ldap_unbind($ds);
- return PASSWORD_CONNECT_ERROR;
- }
+ ldap_set_option($ds, LDAP_OPT_PROTOCOL_VERSION, $rcmail->config->get('password_ldap_version'));
// Start TLS
if ($rcmail->config->get('password_ldap_starttls')) {
@@ -40,8 +72,15 @@
// include 'ldap' driver, we share some static methods with it
require_once INSTALL_PATH . 'plugins/password/drivers/ldap.php';
+ // other plugins might want to modify user DN
+ $plugin = $rcmail->plugins->exec_hook('password_ldap_bind', array(
+ 'user_dn' => '', 'conn' => $ds));
+
// Build user DN
- if ($user_dn = $rcmail->config->get('password_ldap_userDN_mask')) {
+ if (!empty($plugin['user_dn'])) {
+ $user_dn = $plugin['user_dn'];
+ }
+ else if ($user_dn = $rcmail->config->get('password_ldap_userDN_mask')) {
$user_dn = rcube_ldap_password::substitute_vars($user_dn);
}
else {
@@ -72,7 +111,7 @@
$smblchattr = $rcmail->config->get('password_ldap_samba_lchattr');
$samba = $rcmail->config->get('password_ldap_samba');
$pass_mode = $rcmail->config->get('password_ldap_encodage');
- $crypted_pass = rcube_ldap_password::hash_password($passwd, $pass_mode);
+ $crypted_pass = password::hash_password($passwd, $pass_mode);
// Support password_ldap_samba option for backward compat.
if ($samba && !$smbpwattr) {
@@ -86,40 +125,55 @@
}
// Crypt new Samba password
- if ($smbpwattr && !($samba_pass = rcube_ldap_password::hash_password($passwd, 'samba'))) {
+ if ($smbpwattr && !($samba_pass = password::hash_password($passwd, 'samba'))) {
return PASSWORD_CRYPT_ERROR;
}
+ $this->_debug("C: Bind $binddn, pass: **** [" . strlen($bindpw) . "]");
+
// Bind
if (!ldap_bind($ds, $binddn, $bindpw)) {
+ $this->_debug("S: ".ldap_error($ds));
+
ldap_unbind($ds);
+
return PASSWORD_CONNECT_ERROR;
}
- $entree[$pwattr] = $crypted_pass;
+ $this->_debug("S: OK");
+
+ $entry[$pwattr] = $crypted_pass;
// Update PasswordLastChange Attribute if desired
if ($lchattr) {
- $entree[$lchattr] = (int)(time() / 86400);
+ $entry[$lchattr] = (int)(time() / 86400);
}
// Update Samba password
if ($smbpwattr) {
- $entree[$smbpwattr] = $samba_pass;
+ $entry[$smbpwattr] = $samba_pass;
}
// Update Samba password last change
if ($smblchattr) {
- $entree[$smblchattr] = time();
+ $entry[$smblchattr] = time();
}
- if (!ldap_modify($ds, $user_dn, $entree)) {
+ $this->_debug("C: Modify $user_dn: " . print_r($entry, true));
+
+ if (!ldap_modify($ds, $user_dn, $entry)) {
+ $this->_debug("S: ".ldap_error($ds));
+
ldap_unbind($ds);
+
return PASSWORD_CONNECT_ERROR;
}
+ $this->_debug("S: OK");
+
// All done, no error
ldap_unbind($ds);
+
return PASSWORD_SUCCESS;
}
@@ -130,28 +184,55 @@
*/
function search_userdn($rcmail, $ds)
{
- $search_user = $rcmail->config->get('password_ldap_searchDN');
- $search_pass = $rcmail->config->get('password_ldap_searchPW');
+ $search_user = $rcmail->config->get('password_ldap_searchDN');
+ $search_pass = $rcmail->config->get('password_ldap_searchPW');
+ $search_base = $rcmail->config->get('password_ldap_search_base');
+ $search_filter = $rcmail->config->get('password_ldap_search_filter');
+
+ if (empty($search_filter)) {
+ return false;
+ }
+
+ $this->_debug("C: Bind " . ($search_user ? $search_user : '[anonymous]'));
// Bind
if (!ldap_bind($ds, $search_user, $search_pass)) {
+ $this->_debug("S: ".ldap_error($ds));
return false;
}
- $search_base = $rcmail->config->get('password_ldap_search_base');
- $search_filter = $rcmail->config->get('password_ldap_search_filter');
+ $this->_debug("S: OK");
+
+ $search_base = rcube_ldap_password::substitute_vars($search_base);
$search_filter = rcube_ldap_password::substitute_vars($search_filter);
+
+ $this->_debug("C: Search $search_base for $search_filter");
// Search for the DN
if (!$sr = ldap_search($ds, $search_base, $search_filter)) {
+ $this->_debug("S: ".ldap_error($ds));
return false;
}
+ $found = ldap_count_entries($ds, $sr);
+
+ $this->_debug("S: OK [found $found records]");
+
// If no or more entries were found, return false
- if (ldap_count_entries($ds, $sr) != 1) {
+ if ($found != 1) {
return false;
}
return ldap_get_dn($ds, ldap_first_entry($ds, $sr));
}
+
+ /**
+ * Prints debug info to the log
+ */
+ private function _debug($str)
+ {
+ if ($this->debug) {
+ rcube::write_log('ldap', $str);
+ }
+ }
}
--
Gitblit v1.9.1