From f22c2cefb4c7f8b1a995d5de6f706d49861c473c Mon Sep 17 00:00:00 2001 From: svncommit <devs@roundcube.net> Date: Tue, 12 May 2009 10:10:30 -0400 Subject: [PATCH] Really, really logout (fixes r2467). --- program/include/rcmail.php | 23 ++++++++++------------- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/program/include/rcmail.php b/program/include/rcmail.php index 603ac33..1443617 100644 --- a/program/include/rcmail.php +++ b/program/include/rcmail.php @@ -91,7 +91,7 @@ } // set task and action properties - $this->set_task(strip_quotes(get_input_value('_task', RCUBE_INPUT_GPC))); + $this->set_task(get_input_value('_task', RCUBE_INPUT_GPC)); $this->action = asciiwords(get_input_value('_action', RCUBE_INPUT_GPC)); // connect to database @@ -124,7 +124,7 @@ // reset some session parameters when changing task if ($_SESSION['task'] != $this->task) - unset($_SESSION['page']); + rcube_sess_unset('page'); // set current task to session $_SESSION['task'] = $this->task; @@ -145,14 +145,12 @@ */ public function set_task($task) { - if (!in_array($task, self::$main_tasks)) - $task = 'mail'; - - $this->task = $task; - $this->comm_path = $this->url(array('task' => $task)); + $task = asciiwords($task); + $this->task = $task ? $task : 'mail'; + $this->comm_path = $this->url(array('task' => $this->task)); if ($this->output) - $this->output->set_env('task', $task); + $this->output->set_env('task', $this->task); } @@ -795,6 +793,8 @@ */ public function kill_session() { + foreach (array_keys($_SESSION) as $var) + rcube_sess_unset($var); $_SESSION = array('language' => $this->user->language, 'auth_time' => time(), 'temp' => true); rcmail::setcookie('sessauth', '-del-', time() - 60); $this->user->reset(); @@ -936,11 +936,8 @@ { if (!is_array($p)) $p = array('_action' => @func_get_arg(0)); - - $task = $p['_task'] ? $p['_task'] : $p['task']; - if (!$task || !in_array($task, rcmail::$main_tasks)) - $task = $this->task; - + + $task = $p['_task'] ? $p['_task'] : ($p['task'] ? $p['task'] : $this->task); $p['_task'] = $task; unset($p['task']); -- Gitblit v1.9.1