From f22c2cefb4c7f8b1a995d5de6f706d49861c473c Mon Sep 17 00:00:00 2001 From: svncommit <devs@roundcube.net> Date: Tue, 12 May 2009 10:10:30 -0400 Subject: [PATCH] Really, really logout (fixes r2467). --- program/include/rcube_user.php | 125 +++++++++++++++++++++++------------------ 1 files changed, 71 insertions(+), 54 deletions(-) diff --git a/program/include/rcube_user.php b/program/include/rcube_user.php index a5dc73b..79721d5 100644 --- a/program/include/rcube_user.php +++ b/program/include/rcube_user.php @@ -5,7 +5,7 @@ | program/include/rcube_user.inc | | | | This file is part of the RoundCube Webmail client | - | Copyright (C) 2005-2008, RoundCube Dev. - Switzerland | + | Copyright (C) 2005-2009, RoundCube Dev. - Switzerland | | Licensed under the GNU GPL | | | | PURPOSE: | @@ -31,7 +31,7 @@ { public $ID = null; public $data = null; - public $language = 'en_US'; + public $language = null; private $db = null; @@ -78,10 +78,13 @@ */ function get_prefs() { + if (!empty($this->language)) + $prefs = array('language' => $this->language); + if ($this->ID && $this->data['preferences']) - return array('language' => $this->language) + unserialize($this->data['preferences']); - else - return array(); + $prefs += (array)unserialize($this->data['preferences']); + + return $prefs; } @@ -154,7 +157,7 @@ WHERE del<>1 AND user_id=? $sql_add - ORDER BY ".$this->db->quoteIdentifier('standard')." DESC, name ASC", + ORDER BY ".$this->db->quoteIdentifier('standard')." DESC, name ASC, identity_id ASC", $this->ID); return $sql_result; @@ -343,13 +346,21 @@ */ static function create($user, $host) { + $user_name = ''; $user_email = ''; $rcmail = rcmail::get_instance(); + + $data = $rcmail->plugins->exec_hook('create_user', array('user'=>$user, 'user_name'=>$user_name, 'user_email'=>$user_email)); + $user_name = $data['user_name']; + $user_email = $data['user_email']; + $dbh = $rcmail->get_dbh(); - // try to resolve user in virtusertable - if ($rcmail->config->get('virtuser_file') && !strpos($user, '@')) - $user_email = rcube_user::user2email($user); + // try to resolve user in virtuser table and file + if ($user_email != '' && !strpos($user, '@')) { + if ($email_list = self::user2email($user, false)) + $user_email = $email_list[0]; + } $dbh->query( "INSERT INTO ".get_table_name('users')." @@ -357,7 +368,7 @@ VALUES (".$dbh->now().", ".$dbh->now().", ?, ?, ?, ?)", strip_newlines($user), strip_newlines($host), - strip_newlines($user_email), + strip_newlines($data['alias'] ? $data['alias'] : $user_email), $_SESSION['language']); if ($user_id = $dbh->insert_id(get_sequence_name('users'))) @@ -367,34 +378,29 @@ if ($user_email=='') $user_email = strpos($user, '@') ? $user : sprintf('%s@%s', $user, $mail_domain); - $user_name = $user != $user_email ? $user : ''; + if ($user_name == '') { + $user_name = $user != $user_email ? $user : ''; + } - // try to resolve the e-mail address from the virtuser table - if ($virtuser_query = $rcmail->config->get('virtuser_query') && - ($sql_result = $dbh->query(preg_replace('/%u/', $dbh->escapeSimple($user), $virtuser_query))) && - ($dbh->num_rows() > 0)) - { - while ($sql_arr = $dbh->fetch_array($sql_result)) - { - $dbh->query( + if (empty($email_list)) + $email_list[] = strip_newlines($user_email); + + // identities_level check + if (count($email_list) > 1 && $rcmail->config->get('identities_level', 0) > 1) + $email_list = array($email_list[0]); + + // create new identities records + $standard = 1; + foreach ($email_list as $email) { + $dbh->query( "INSERT INTO ".get_table_name('identities')." (user_id, del, standard, name, email) - VALUES (?, 0, 1, ?, ?)", + VALUES (?, 0, ?, ?, ?)", $user_id, + $standard, strip_newlines($user_name), - preg_replace('/^@/', $user . '@', $sql_arr[0])); - } - } - else - { - // also create new identity records - $dbh->query( - "INSERT INTO ".get_table_name('identities')." - (user_id, del, standard, name, email) - VALUES (?, 0, 1, ?, ?)", - $user_id, - strip_newlines($user_name), - strip_newlines($user_email)); + preg_replace('/^@/', $user . '@', $email)); + $standard = 0; } } else @@ -412,59 +418,71 @@ /** - * Resolve username using a virtuser table + * Resolve username using a virtuser file * * @param string E-mail address to resolve * @return string Resolved IMAP username */ static function email2user($email) { - $user = $email; - $r = self::findinvirtual('^' . quotemeta($email) . '[[:space:]]'); + $r = self::findinvirtual('/^' . preg_quote($email, '/') . '\s/'); for ($i=0; $i<count($r); $i++) { $data = trim($r[$i]); $arr = preg_split('/\s+/', $data); if (count($arr) > 0) - { - $user = trim($arr[count($arr)-1]); - break; - } + return trim($arr[count($arr)-1]); } - return $user; + return NULL; } /** - * Resolve e-mail address from virtuser table + * Resolve e-mail address from virtuser file/table * * @param string User name - * @return string Resolved e-mail address + * @param boolean If true returns first found entry + * @return mixed Resolved e-mail address string or array of strings */ - static function user2email($user) + static function user2email($user, $first=true) { - $email = ''; - $r = self::findinvirtual('[[:space:]]' . quotemeta($user) . '[[:space:]]*$'); + $result = array(); + $rcmail = rcmail::get_instance(); + $dbh = $rcmail->get_dbh(); + // SQL lookup + if ($virtuser_query = $rcmail->config->get('virtuser_query')) { + $sql_result = $dbh->query(preg_replace('/%u/', $dbh->escapeSimple($user), $virtuser_query)); + while ($sql_arr = $dbh->fetch_array($sql_result)) + if (strpos($sql_arr[0], '@')) { + $result[] = $sql_arr[0]; + if ($first) + return $result[0]; + } + } + // File lookup + $r = self::findinvirtual('/\s' . preg_quote($user, '/') . '\s*$/'); for ($i=0; $i<count($r); $i++) { $data = $r[$i]; $arr = preg_split('/\s+/', $data); - if (count($arr) > 0) + if (count($arr) > 0 && strpos($arr[0], '@')) { - $email = trim(str_replace('\\@', '@', $arr[0])); - break; + $result[] = trim(str_replace('\\@', '@', $arr[0])); + + if ($first) + return $result[0]; } } - - return $email; + + return empty($result) ? NULL : $result; } /** - * Find matches of the given pattern in virtuser table + * Find matches of the given pattern in virtuser file * * @param string Regular expression to search for * @return array Matching entries @@ -487,13 +505,12 @@ if (empty($line) || $line{0}=='#') continue; - if (eregi($pattern, $line)) + if (preg_match($pattern, $line)) $result[] = $line; } return $result; } - } -- Gitblit v1.9.1