From f5d61d845f8cfce4c7b559a900df846947e45b00 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Wed, 21 Oct 2009 04:47:40 -0400 Subject: [PATCH] Revert r3038 and allow to specify the port as value of force_https --- index.php | 101 +++++++++++++++++++++++++++++++++++--------------- 1 files changed, 71 insertions(+), 30 deletions(-) diff --git a/index.php b/index.php index 74c7c21..e0956b4 100644 --- a/index.php +++ b/index.php @@ -2,9 +2,9 @@ /* +-------------------------------------------------------------------------+ | RoundCube Webmail IMAP Client | - | Version 0.2-20080829 | + | Version 0.3-20090814 | | | - | Copyright (C) 2005-2008, RoundCube Dev. - Switzerland | + | Copyright (C) 2005-2009, RoundCube Dev. - Switzerland | | | | This program is free software; you can redistribute it and/or modify | | it under the terms of the GNU General Public License version 2 | @@ -36,18 +36,11 @@ // init output class $OUTPUT = !empty($_REQUEST['_remote']) ? $RCMAIL->init_json() : $RCMAIL->load_gui(!empty($_REQUEST['_framed'])); -// set output buffering -if ($RCMAIL->action != 'get' && $RCMAIL->action != 'viewsource') { - // use gzip compression if supported - if (function_exists('ob_gzhandler') - && !ini_get('zlib.output_compression') - && ini_get('output_handler') != 'ob_gzhandler') { - ob_start('ob_gzhandler'); - } - else { - ob_start(); - } -} +// init plugin API +$RCMAIL->plugins->init(); + +// turn on output buffering +ob_start(); // check if config files had errors if ($err_str = $RCMAIL->config->get_error()) { @@ -70,19 +63,40 @@ raise_error(array('code' => hexdec($_GET['_code'])), FALSE, TRUE); } +// check if https is required (for login) and redirect if necessary +if (empty($_SESSION['user_id']) && ($force_https = $RCMAIL->config->get('force_https', false))) { + $https_port = is_bool($force_https) ? 443 : $force_https; + if (!(isset($_SERVER['HTTPS']) || $_SERVER['SERVER_PORT'] == $use_https || $RCMAIL->config->get('use_https'))) { + header('Location: https://' . $_SERVER['HTTP_HOST'] . ($https_port != 443 ? ':' . $https_port : '') . $_SERVER['REQUEST_URI']); + exit; + } +} + +// trigger startup plugin hook +$startup = $RCMAIL->plugins->exec_hook('startup', array('task' => $RCMAIL->task, 'action' => $RCMAIL->action)); +$RCMAIL->set_task($startup['task']); +$RCMAIL->action = $startup['action']; + // try to log in if ($RCMAIL->action=='login' && $RCMAIL->task=='mail') { - $host = $RCMAIL->autoselect_host(); + // purge the session in case of new login when a session already exists + $RCMAIL->kill_session(); + $auth = $RCMAIL->plugins->exec_hook('authenticate', array( + 'host' => $RCMAIL->autoselect_host(), + 'user' => trim(get_input_value('_user', RCUBE_INPUT_POST)), + 'cookiecheck' => true, + )) + array('pass' => get_input_value('_pass', RCUBE_INPUT_POST, true, 'ISO-8859-1')); + // check if client supports cookies - if (empty($_COOKIE)) { + if ($auth['cookiecheck'] && empty($_COOKIE)) { $OUTPUT->show_message("cookiesdisabled", 'warning'); } - else if ($_SESSION['temp'] && !empty($_POST['_user']) && !empty($_POST['_pass']) && - $RCMAIL->login(trim(get_input_value('_user', RCUBE_INPUT_POST), ' '), - get_input_value('_pass', RCUBE_INPUT_POST, true, 'ISO-8859-1'), $host)) { + else if ($_SESSION['temp'] && !$auth['abort'] && !empty($auth['host']) && + !empty($auth['user']) && isset($auth['pass']) && + $RCMAIL->login($auth['user'], $auth['pass'], $auth['host'])) { // create new session ID - unset($_SESSION['temp']); + rcube_sess_unset('temp'); rcube_sess_regenerate_id(); // send auth cookie if necessary @@ -95,21 +109,33 @@ $RCMAIL->user->ID, $_SERVER['REMOTE_ADDR'])); } + + // restore original request parameters + $query = array(); + if ($url = get_input_value('_url', RCUBE_INPUT_POST)) + parse_str($url, $query); + + // allow plugins to control the redirect url after login success + $redir = $RCMAIL->plugins->exec_hook('login_after', $query + array('task' => $RCMAIL->task)); + unset($redir['abort']); // send redirect - $OUTPUT->redirect(); + $OUTPUT->redirect($redir); } else { $OUTPUT->show_message($IMAP->error_code < -1 ? 'imaperror' : 'loginfailed', 'warning'); + $RCMAIL->plugins->exec_hook('login_failed', array('code' => $IMAP->error_code, 'host' => $auth['host'], 'user' => $auth['user'])); $RCMAIL->kill_session(); } } // end session -else if (($RCMAIL->task=='logout' || $RCMAIL->action=='logout') && isset($_SESSION['user_id'])) { +else if ($RCMAIL->task=='logout' && isset($_SESSION['user_id'])) { + $userdata = array('user' => $_SESSION['username'], 'host' => $_SESSION['imap_host'], 'lang' => $RCMAIL->user->language); $OUTPUT->show_message('loggedout'); $RCMAIL->logout_actions(); $RCMAIL->kill_session(); + $RCMAIL->plugins->exec_hook('logout_after', $userdata); } // check session and auth cookie @@ -120,22 +146,30 @@ } } +// don't check for valid request tokens in these actions +$request_check_whitelist = array('login'=>1, 'spell'=>1); // check client X-header to verify request origin if ($OUTPUT->ajax_call) { - if (!$RCMAIL->config->get('devel_mode') && !rc_request_header('X-RoundCube-Referer')) { + if (!$RCMAIL->config->get('devel_mode') && rc_request_header('X-RoundCube-Request') != $RCMAIL->get_request_token() && !empty($RCMAIL->user->ID)) { header('HTTP/1.1 404 Not Found'); die("Invalid Request"); } } - +// check request token in POST form submissions +else if (!empty($_POST) && !$request_check_whitelist[$RCMAIL->action] && !$RCMAIL->check_request()) { + $OUTPUT->show_message('invalidrequest', 'error'); + $OUTPUT->send($RCMAIL->task); +} // not logged in -> show login page if (empty($RCMAIL->user->ID)) { - if ($OUTPUT->ajax_call) $OUTPUT->redirect(array(), 2000); + if (!empty($_REQUEST['_framed'])) + $OUTPUT->command('redirect', '?'); + // check if installer is still active if ($RCMAIL->config->get('enable_installer') && is_readable('./installer/index.php')) { $OUTPUT->add_footer(html::div(array('style' => "background:#ef9398; border:2px solid #dc5757; padding:0.5em; margin:2em auto; width:50em"), @@ -176,8 +210,9 @@ 'send' => 'sendmail.inc', 'expunge' => 'folders.inc', 'purge' => 'folders.inc', - 'remove-attachment' => 'compose.inc', - 'display-attachment' => 'compose.inc', + 'remove-attachment' => 'attachments.inc', + 'display-attachment' => 'attachments.inc', + 'upload' => 'attachments.inc', ), 'addressbook' => array( @@ -196,16 +231,22 @@ ); // include task specific functions -include_once 'program/steps/'.$RCMAIL->task.'/func.inc'; +if (is_file($incfile = 'program/steps/'.$RCMAIL->task.'/func.inc')) + include_once($incfile); // allow 5 "redirects" to another action $redirects = 0; $incstep = null; while ($redirects < 5) { $stepfile = !empty($action_map[$RCMAIL->task][$RCMAIL->action]) ? $action_map[$RCMAIL->task][$RCMAIL->action] : strtr($RCMAIL->action, '-', '_') . '.inc'; - + + // execute a plugin action + if (preg_match('/^plugin\./', $RCMAIL->action)) { + $RCMAIL->plugins->exec_action($RCMAIL->action); + break; + } // try to include the step file - if (is_file(($incfile = 'program/steps/'.$RCMAIL->task.'/'.$stepfile))) { + else if (is_file($incfile = 'program/steps/'.$RCMAIL->task.'/'.$stepfile)) { include($incfile); $redirects++; } -- Gitblit v1.9.1