From f7221df5c5082408591a779bb3616b358d496943 Mon Sep 17 00:00:00 2001
From: alecpl <alec@alec.pl>
Date: Tue, 28 Dec 2010 02:17:32 -0500
Subject: [PATCH] - Fix for ANNOTATEMORE drafts below 08 version (use quoted parameters)
---
program/include/rcube_imap_generic.php | 17 +++++++++++------
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/program/include/rcube_imap_generic.php b/program/include/rcube_imap_generic.php
index f1b704c..8b04a6b 100644
--- a/program/include/rcube_imap_generic.php
+++ b/program/include/rcube_imap_generic.php
@@ -2881,8 +2881,9 @@
$value = sprintf("{%d}\r\n%s", strlen($value), $value);
}
+ // ANNOTATEMORE drafts before version 08 require quoted parameters
$entries[] = sprintf('%s (%s %s)',
- $this->escape($name), $this->escape($attr), $value);
+ $this->escape($name, true), $this->escape($attr, true), $value);
}
$entries = implode(' ', $entries);
@@ -2932,8 +2933,9 @@
$entries = array($entries);
}
// create entries string
+ // ANNOTATEMORE drafts before version 08 require quoted parameters
foreach ($entries as $idx => $name) {
- $entries[$idx] = $this->escape($name);
+ $entries[$idx] = $this->escape($name, true);
}
$entries = '(' . implode(' ', $entries) . ')';
@@ -2942,7 +2944,7 @@
}
// create entries string
foreach ($attribs as $idx => $name) {
- $attribs[$idx] = $this->escape($name);
+ $attribs[$idx] = $this->escape($name, true);
}
$attribs = '(' . implode(' ', $attribs) . ')';
@@ -3237,12 +3239,13 @@
/**
* Escapes a string when it contains special characters (RFC3501)
*
- * @param string $string IMAP string
+ * @param string $string IMAP string
+ * @param boolean $force_quotes Forces string quoting
*
* @return string Escaped string
* @todo String literals, lists
*/
- static function escape($string)
+ static function escape($string, $force_quotes=false)
{
if ($string === null) {
return 'NIL';
@@ -3250,7 +3253,9 @@
else if ($string === '') {
return '""';
}
- else if (preg_match('/([\x00-\x20\x28-\x29\x7B\x25\x2A\x22\x5C\x5D\x7F]+)/', $string)) {
+ else if ($force_quotes ||
+ preg_match('/([\x00-\x20\x28-\x29\x7B\x25\x2A\x22\x5C\x5D\x7F]+)/', $string)
+ ) {
// string: special chars: SP, CTL, (, ), {, %, *, ", \, ]
return '"' . strtr($string, array('"'=>'\\"', '\\' => '\\\\')) . '"';
}
--
Gitblit v1.9.1