From fbe54043cf598b19a753dc2b21a7ed558d23fd15 Mon Sep 17 00:00:00 2001 From: thomascube <thomas@roundcube.net> Date: Thu, 18 Aug 2011 13:40:07 -0400 Subject: [PATCH] Fix folders drop-down list: descend into root folder (e.g. INBOX) even if part of the exception list --- program/include/rcube_config.php | 50 ++++++++++++++++++++++++++++++++------------------ 1 files changed, 32 insertions(+), 18 deletions(-) diff --git a/program/include/rcube_config.php b/program/include/rcube_config.php index a7e1d9e..9379e9e 100644 --- a/program/include/rcube_config.php +++ b/program/include/rcube_config.php @@ -5,7 +5,7 @@ | program/include/rcube_config.php | | | | This file is part of the Roundcube Webmail client | - | Copyright (C) 2008-2010, Roundcube Dev. - Switzerland | + | Copyright (C) 2008-2010, The Roundcube Dev Team | | Licensed under the GNU GPL | | | | PURPOSE: | @@ -47,10 +47,6 @@ */ private function load() { - // start output buffering, we don't need any output yet, - // it'll be cleared after reading of config files, etc. - ob_start(); - // load main config file if (!$this->load_from_file(RCMAIL_CONFIG_DIR . '/main.inc.php')) $this->errors[] = 'main.inc.php was not found.'; @@ -58,7 +54,7 @@ // load database config if (!$this->load_from_file(RCMAIL_CONFIG_DIR . '/db.inc.php')) $this->errors[] = 'db.inc.php was not found.'; - + // load host-specific configuration $this->load_host_config(); @@ -71,7 +67,7 @@ // fix paths $this->prop['log_dir'] = $this->prop['log_dir'] ? realpath(unslashify($this->prop['log_dir'])) : INSTALL_PATH . 'logs'; $this->prop['temp_dir'] = $this->prop['temp_dir'] ? realpath(unslashify($this->prop['temp_dir'])) : INSTALL_PATH . 'temp'; - + // fix default imap folders encoding foreach (array('drafts_mbox', 'junk_mbox', 'sent_mbox', 'trash_mbox') as $folder) $this->prop[$folder] = rcube_charset_convert($this->prop[$folder], RCMAIL_CHARSET, 'UTF7-IMAP'); @@ -91,15 +87,9 @@ ini_set('error_log', $this->prop['log_dir'].'/errors'); } } - if ($this->prop['debug_level'] & 4) { - ini_set('display_errors', 1); - } - else { - ini_set('display_errors', 0); - } - // clear output buffer - ob_end_clean(); + // enable display_errors in 'show' level, but not for ajax requests + ini_set('display_errors', intval(empty($_REQUEST['_remote']) && ($this->prop['debug_level'] & 4))); // export config data $GLOBALS['CONFIG'] = &$this->prop; @@ -136,7 +126,11 @@ public function load_from_file($fpath) { if (is_file($fpath) && is_readable($fpath)) { + // use output buffering, we don't need any output here + ob_start(); include($fpath); + ob_end_clean(); + if (is_array($rcmail_config)) { $this->prop = array_merge($this->prop, $rcmail_config, $this->userprefs); return true; @@ -156,7 +150,17 @@ */ public function get($name, $def = null) { - return isset($this->prop[$name]) ? $this->prop[$name] : $def; + $result = isset($this->prop[$name]) ? $this->prop[$name] : $def; + $rcmail = rcmail::get_instance(); + + if (is_object($rcmail->plugins)) { + $plugin = $rcmail->plugins->exec_hook('config_get', array( + 'name' => $name, 'default' => $def, 'result' => $result)); + + return $plugin['result']; + } + + return $result; } @@ -191,8 +195,18 @@ */ public function set_user_prefs($prefs) { + // Honor the dont_override setting for any existing user preferences + $dont_override = $this->get('dont_override'); + if (is_array($dont_override) && !empty($dont_override)) { + foreach ($prefs as $key => $pref) { + if (in_array($key, $dont_override)) { + unset($prefs[$key]); + } + } + } + $this->userprefs = $prefs; - $this->prop = array_merge($this->prop, $prefs); + $this->prop = array_merge($this->prop, $prefs); } @@ -290,7 +304,7 @@ $domain = rcube_parse_host($this->prop['mail_domain']); if ($encode) - $domain = idn_to_ascii($domain); + $domain = rcube_idn_to_ascii($domain); return $domain; } -- Gitblit v1.9.1