From 37b29231e47a0c4458dc1c15d98588f16f07e1e2 Mon Sep 17 00:00:00 2001
From: Marius Cramer <m.cramer@pixcept.de>
Date: Thu, 06 Aug 2015 03:18:44 -0400
Subject: [PATCH] - don't set password via remoting if field is empty

---
 interface/lib/classes/searchform.inc.php |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/interface/lib/classes/searchform.inc.php b/interface/lib/classes/searchform.inc.php
index cfa8f28..0a290c1 100644
--- a/interface/lib/classes/searchform.inc.php
+++ b/interface/lib/classes/searchform.inc.php
@@ -177,7 +177,7 @@
 		if($this->searchChanged == 1)   $_SESSION['search'][$list_name]['page'] = 0;
 
 		$sql_von = $_SESSION['search'][$list_name]['page'] * $records_per_page;
-		$record_count = $app->db->queryOneRecord("SELECT count(*) AS anzahl FROM $table WHERE $sql_where");
+		$record_count = $app->db->queryOneRecord("SELECT count(*) AS anzahl FROM ?? WHERE $sql_where", $table);
 		$pages = $app->functions->intval(($record_count['anzahl'] - 1) / $records_per_page);
 
 		$vars['list_file']      = $this->listDef['file'];
@@ -247,7 +247,7 @@
 		$list_name = $this->listDef['name'];
 		$settings = $_SESSION['search'][$list_name];
 		unset($settings['page']);
-		$data = $app->db->quote(serialize($settings));
+		$data = serialize($settings);
 
 		$userid = $_SESSION['s']['user']['userid'];
 		$groupid = $_SESSION['s']['user']['default_group'];
@@ -260,9 +260,8 @@
 
 		$sql = 'INSERT INTO `searchform` ( '
 			.'`sys_userid` , `sys_groupid` , `sys_perm_user` , `sys_perm_group` , `sys_perm_other` , `module` , `searchform` , `title` , `data` '
-			.')VALUES ('
-			."'$userid', '$groupid', '$sys_perm_user', '$sys_perm_group', '$sys_perm_other', '$module', '$searchform', '$title', '$data')";
-		$app->db->query($sql);
+			.')VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)';
+		$app->db->query($sql, $userid, $groupid, $sys_perm_user, $sys_perm_group, $sys_perm_other, $module, $searchform, $title, $data);
 	}
 
 	public function decode($record)
@@ -303,6 +302,7 @@
 		return $record;
 	}
 
+	/* TODO: check for double quoting mysql value */
 	public function encode($record)
 	{
 		global $app;

--
Gitblit v1.9.1