From 37b29231e47a0c4458dc1c15d98588f16f07e1e2 Mon Sep 17 00:00:00 2001
From: Marius Cramer <m.cramer@pixcept.de>
Date: Thu, 06 Aug 2015 03:18:44 -0400
Subject: [PATCH] - don't set password via remoting if field is empty

---
 server/plugins-available/mail_plugin_dkim.inc.php |   74 +++++++++++++++++++------------------
 1 files changed, 38 insertions(+), 36 deletions(-)

diff --git a/server/plugins-available/mail_plugin_dkim.inc.php b/server/plugins-available/mail_plugin_dkim.inc.php
index 7fea83c..7ded684 100755
--- a/server/plugins-available/mail_plugin_dkim.inc.php
+++ b/server/plugins-available/mail_plugin_dkim.inc.php
@@ -75,9 +75,9 @@
 	 */
 	function get_amavis_config() {
 		$pos_config=array(
-			'/etc/amavisd.conf',
 			'/etc/amavisd.conf/50-user',
 			'/etc/amavis/conf.d/50-user',
+			'/etc/amavisd.conf',
 			'/etc/amavisd/amavisd.conf'
 		);
 		$amavis_configfile='';
@@ -325,7 +325,7 @@
 					$this->remove_dkim_key($mail_config['dkim_path']."/".$data['new']['domain'], $data['new']['domain']);
 				}
 			} else {
-				$app->log('Error saving the DKIM Private-key for '.$data['new']['domain'].' - DKIM is not enabled for the domain.', LOGLEVEL_ERROR);
+				$app->log('Error saving the DKIM Private-key for '.$data['new']['domain'].' - DKIM is not enabled for the domain.', LOGLEVEL_DEBUG);
 			}
 		}
 	}
@@ -369,44 +369,46 @@
 	 */
 	function domain_dkim_update($event_name, $data) {
 		global $app;
-		if ($this->check_system($data)) {
-			/* maildomain disabled */
-			if ($data['new']['active'] == 'n' && $data['old']['active'] == 'y' && $data['new']['dkim']=='y') {
-				$app->log('Maildomain '.$data['new']['domain'].' disabled - remove DKIM-settings', LOGLEVEL_DEBUG);
-				$this->remove_dkim($data['new']);
-			}
-			/* maildomain re-enabled */
-			if ($data['new']['active'] == 'y' && $data['old']['active'] == 'n' && $data['new']['dkim']=='y') 
-				$this->add_dkim($data);
-
-			/* maildomain active - only dkim changes */
-			if ($data['new']['active'] == 'y' && $data['old']['active'] == 'y') {
-				/* dkim disabled */
-				if ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'n') {
+		if($data['new']['dkim'] == 'y' || $data['old']['dkim'] == 'y'){
+			if ($this->check_system($data)) {
+				/* maildomain disabled */
+				if ($data['new']['active'] == 'n' && $data['old']['active'] == 'y' && $data['new']['dkim']=='y') {
+					$app->log('Maildomain '.$data['new']['domain'].' disabled - remove DKIM-settings', LOGLEVEL_DEBUG);
 					$this->remove_dkim($data['new']);
 				}
-				/* dkim enabled */
-				elseif ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'y') {
+				/* maildomain re-enabled */
+				if ($data['new']['active'] == 'y' && $data['old']['active'] == 'n' && $data['new']['dkim']=='y') 
 					$this->add_dkim($data);
-				}
-				/* new private-key */
-				if ($data['new']['dkim_private'] != $data['old']['dkim_private'] && $data['new']['dkim'] == 'y') {
-					$this->add_dkim($data);
-				}
-				/* new selector */
-				if ($data['new']['dkim_selector'] != $data['old']['dkim_selector'] && $data['new']['dkim'] == 'y') {
-					$this->add_dkim($data);
-				}
-				/* new domain-name */
-				if ($data['new']['domain'] != $data['old']['domain']) {
-					$this->remove_dkim($data['old']);
-					$this->add_dkim($data);
-				}
-			}
 
-			/* resync */
-			if ($data['new']['active'] == 'y' && $data['new'] == $data['old'] && $data['new']['dkim']=='y') {
-				$this->add_dkim($data);
+				/* maildomain active - only dkim changes */
+				if ($data['new']['active'] == 'y' && $data['old']['active'] == 'y') {
+					/* dkim disabled */
+					if ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'n') {
+						$this->remove_dkim($data['new']);
+					}
+					/* dkim enabled */
+					elseif ($data['new']['dkim'] != $data['old']['dkim'] && $data['new']['dkim'] == 'y') {
+						$this->add_dkim($data);
+					}
+					/* new private-key */
+					if ($data['new']['dkim_private'] != $data['old']['dkim_private'] && $data['new']['dkim'] == 'y') {
+						$this->add_dkim($data);
+					}
+					/* new selector */
+					if ($data['new']['dkim_selector'] != $data['old']['dkim_selector'] && $data['new']['dkim'] == 'y') {
+						$this->add_dkim($data);
+					}
+					/* new domain-name */
+					if ($data['new']['domain'] != $data['old']['domain']) {
+						$this->remove_dkim($data['old']);
+						$this->add_dkim($data);
+					}
+				}
+
+				/* resync */
+				if ($data['new']['active'] == 'y' && $data['new'] == $data['old'] && $data['new']['dkim']=='y') {
+					$this->add_dkim($data);
+				}
 			}
 		}
 	}

--
Gitblit v1.9.1