From 4569cae57f127afd093794310ccd290d2d9fdf36 Mon Sep 17 00:00:00 2001
From: Marius Burkard <m.burkard@pixcept.de>
Date: Wed, 20 Apr 2016 10:58:46 -0400
Subject: [PATCH] Merge branch 'stable-3.1'

---
 interface/lib/classes/tform_base.inc.php |  156 +++++++++++++++++++++++++++------------------------
 1 files changed, 83 insertions(+), 73 deletions(-)

diff --git a/interface/lib/classes/tform_base.inc.php b/interface/lib/classes/tform_base.inc.php
index 784e96a..1739c1f 100644
--- a/interface/lib/classes/tform_base.inc.php
+++ b/interface/lib/classes/tform_base.inc.php
@@ -98,7 +98,7 @@
 	var $errorMessage = '';
 
 	var $dateformat = "d.m.Y";
-	var $datetimeformat = 'd.m.Y H:i';
+	var $datetimeformat = 'd.m.Y H:i'; // is set to the correct value in loadFormDef
 	var $formDef = array();
 	var $wordbook;
 	var $module;
@@ -127,6 +127,7 @@
 		global $app, $conf;
 
 		include $file;
+		$app->plugin->raiseEvent($_SESSION['s']['module']['name'].':'.$form['name'] . ':on_before_formdef', $this);
 		$this->formDef = $form;
 
 		$this->module = $module;
@@ -150,8 +151,10 @@
 			$wb = $app->functions->array_merge($wb_global, $wb);
 		}
 		if(isset($wb_global)) unset($wb_global);
-
+		
 		$this->wordbook = $wb;
+		
+		$app->plugin->raiseEvent($_SESSION['s']['module']['name'].':'.$app->tform->formDef['name'] . ':on_after_formdef', $this);
 
 		$this->dateformat = $app->lng('conf_format_dateshort');
 		$this->datetimeformat = $app->lng('conf_format_datetime');
@@ -203,7 +206,7 @@
 					break;
 
 				case 'DATE':
-					if($record[$key] != '' && $record[$key] != '0000-00-00') {
+					if($record[$key] != '' && !is_null($record[$key]) && $record[$key] != '0000-00-00') {
 						$tmp = explode('-', $record[$key]);
 						$new_record[$key] = date($this->dateformat, mktime(0, 0, 0, $tmp[1]  , $tmp[2], $tmp[0]));
 					}
@@ -767,7 +770,7 @@
 					}
 					break;
 				case 'DATE':
-					if($record[$key] != '' && $record[$key] != '0000-00-00') {
+					if($record[$key] != '' && !is_null($record[$key]) && $record[$key] != '0000-00-00') {
 						if(function_exists('date_parse_from_format')) {
 							$date_parts = date_parse_from_format($this->dateformat, $record[$key]);
 							$new_record[$key] = $date_parts['year'].'-'.str_pad($date_parts['month'], 2, "0", STR_PAD_LEFT).'-'.str_pad($date_parts['day'], 2, "0", STR_PAD_LEFT);
@@ -776,7 +779,7 @@
 							$new_record[$key] = date('Y-m-d', $tmp);
 						}
 					} else {
-						$new_record[$key] = '0000-00-00';
+						$new_record[$key] = null;
 					}
 					break;
 				case 'INTEGER':
@@ -799,11 +802,19 @@
 							$new_record[$key] = date( 'Y-m-d H:i:s', mktime($_dt_hour, $_dt_minute, $_dt_second, $_dt_month, $_dt_day, $_dt_year) );
 						}
 					} else {*/
-						if($record[$key] != '' && $record[$key] != '0000-00-00 00:00:00') {
-							$tmp = strtotime($record[$key]);
-							$new_record[$key] = date($this->datetimeformat, $tmp);
+						if($record[$key] != '' && !is_null($record[$key]) && $record[$key] != '0000-00-00 00:00:00') {
+							//$tmp = strtotime($record[$key]);
+							//$new_record[$key] = date($this->datetimeformat, $tmp);
+							$parsed_date = date_parse_from_format($this->datetimeformat,$record[$key]);
+							if($parsed_date['error_count'] > 0 || ($parsed_date['year'] == 1899 && $parsed_date['month'] == 12 && $parsed_date['day'] == 31)) {
+								// There was an error, set the date to 0
+								$new_record[$key] = null;
+							} else {
+								// Date parsed successfully. Convert it to database format
+								$new_record[$key] = date( 'Y-m-d H:i:s', mktime($parsed_date['hour'], $parsed_date['minute'], $parsed_date['second'], $parsed_date['month'], $parsed_date['day'], $parsed_date['year']) );
+							}
 						} else {
-							$new_record[$key] = '0000-00-00 00:00:00';
+							$new_record[$key] = null;
 						}
 					/*}*/
 					break;
@@ -874,6 +885,9 @@
 					break;
 				case 'TRIM':
 					$returnval = trim($returnval);
+					break;
+				case 'NOWHITESPACE':
+					$returnval = preg_replace('/\s+/', '', $returnval);
 					break;
 				default:
 					$this->errorMessage .= "Unknown Filter: ".$filter['type'];
@@ -960,28 +974,25 @@
 					}
 				}
 			case 'ISEMAIL':
-				if(function_exists('filter_var')) {
-					if(filter_var($field_value, FILTER_VALIDATE_EMAIL) === false) {
-						$errmsg = $validator['errmsg'];
-						if(isset($this->wordbook[$errmsg])) {
-							$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
-						} else {
-							$this->errorMessage .= $errmsg."<br />\r\n";
-						}
-					}
+				if($validator['allowempty'] != 'y') $validator['allowempty'] = 'n';
+				if($validator['allowempty'] == 'y' && $field_value == '') {
+					//* Do nothing
 				} else {
-					if(!preg_match("/^\w+[\w\.\-\+]*\w{0,}@\w+[\w.-]*\w+\.[a-zA-Z0-9\-]{2,30}$/i", $field_value)) {
-						$errmsg = $validator['errmsg'];
-						if(isset($this->wordbook[$errmsg])) {
-							$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
-						} else {
-							$this->errorMessage .= $errmsg."<br />\r\n";
+					if(function_exists('filter_var')) {
+						if(filter_var($field_value, FILTER_VALIDATE_EMAIL) === false) {
+							$errmsg = $validator['errmsg'];
+							if(isset($this->wordbook[$errmsg])) {
+								$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
+							} else {
+								$this->errorMessage .= $errmsg."<br />\r\n";
+							}
 						}
-					}
+					} else $this->errorMessage .= "function filter_var missing <br />\r\n";
 				}
 				break;
 			case 'ISINT':
 				if(function_exists('filter_var') && $field_value < 2147483647) {
+					//if($field_value != '' && filter_var($field_value, FILTER_VALIDATE_INT, array("options" => array('min_range'=>0))) === false) {
 					if($field_value != '' && filter_var($field_value, FILTER_VALIDATE_INT) === false) {
 						$errmsg = $validator['errmsg'];
 						if(isset($this->wordbook[$errmsg])) {
@@ -990,9 +1001,11 @@
 							$this->errorMessage .= $errmsg."<br />\r\n";
 						}
 					}
-				} else {
-					$tmpval = $app->functions->intval($field_value);
-					if($tmpval === 0 and !empty($field_value)) {
+				} else $this->errorMessage .= "function filter_var missing <br />\r\n";
+				break;
+			case 'ISPOSITIVE':
+				if(function_exists('filter_var')) {
+					if($field_value != '' && filter_var($field_value, FILTER_VALIDATE_INT, array("options" => array('min_range'=>1))) === false) {
 						$errmsg = $validator['errmsg'];
 						if(isset($this->wordbook[$errmsg])) {
 							$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
@@ -1000,21 +1013,10 @@
 							$this->errorMessage .= $errmsg."<br />\r\n";
 						}
 					}
-				}
-				break;
-			case 'ISPOSITIVE':
-				if(!is_numeric($field_value) || $field_value <= 0){
-					$errmsg = $validator['errmsg'];
-					if(isset($this->wordbook[$errmsg])) {
-						$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
-					} else {
-						$this->errorMessage .= $errmsg."<br />\r\n";
-					}
-				}
+				} else $this->errorMessage .= "function filter_var missing <br />\r\n";
 				break;
 			case 'V6PREFIXEND':
 				$explode_field_value = explode(':',$field_value);
-//				if ($explode_field_value[count($explode_field_value)-1]=='' && $explode_field_value[count($explode_field_value)-2]=='' ){ }
 				if (!$explode_field_value[count($explode_field_value)-1]=='' && $explode_field_value[count($explode_field_value)-2]!='' ) {
 					$errmsg = $validator['errmsg'];
 					if(isset($this->wordbook[$errmsg])) {
@@ -1058,26 +1060,32 @@
 				}
 				break;
 
-
-
 			case 'ISIPV4':
-				$vip=1;
-				if(preg_match("/^[0-9]{1,3}(\.)[0-9]{1,3}(\.)[0-9]{1,3}(\.)[0-9]{1,3}$/", $field_value)){
-					$groups=explode(".", $field_value);
-					foreach($groups as $group){
-						if($group<0 or $group>255)
-							$vip=0;
+				if(function_exists('filter_var')) {
+					if(!filter_var($field_value, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
+						$errmsg = $validator['errmsg'];
+						if(isset($this->wordbook[$errmsg])) {
+							$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
+						} else {
+							$this->errorMessage .= $errmsg."<br />\r\n";
+						}
 					}
-				}else{$vip=0;}
-				if($vip==0) {
-					$errmsg = $validator['errmsg'];
-					if(isset($this->wordbook[$errmsg])) {
-						$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
-					} else {
-						$this->errorMessage .= $errmsg."<br />\r\n";
-					}
-				}
+				} else $this->errorMessage .= "function filter_var missing <br />\r\n";
 				break;
+
+			case 'ISIPV6':
+				if(function_exists('filter_var')) {
+					if(!filter_var($field_value, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
+						$errmsg = $validator['errmsg'];
+						if(isset($this->wordbook[$errmsg])) {
+							$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
+						} else {
+							$this->errorMessage .= $errmsg."<br />\r\n";
+						}
+					}
+				} else $this->errorMessage .= "function filter_var missing <br />\r\n";
+				break;
+
 			case 'ISIP':
 				if($validator['allowempty'] != 'y') $validator['allowempty'] = 'n';
 				if($validator['allowempty'] == 'y' && $field_value == '') {
@@ -1101,27 +1109,29 @@
 									$this->errorMessage .= $errmsg."<br />\r\n";
 								}
 							}
+						} else $this->errorMessage .= "function filter_var missing <br />\r\n";
+					}
+				}
+				break;
+			
+			case 'ISDATETIME':
+				/* Checks a datetime value against the date format of the current language */
+				if($validator['allowempty'] != 'y') $validator['allowempty'] = 'n';
+				if($validator['allowempty'] == 'y' && $field_value == '') {
+					//* Do nothing
+				} else {
+					$parsed_date = date_parse_from_format($this->datetimeformat,$field_value);
+					if($parsed_date['error_count'] > 0 || ($parsed_date['year'] == 1899 && $parsed_date['month'] == 12 && $parsed_date['day'] == 31)) {
+						$errmsg = $validator['errmsg'];
+						if(isset($this->wordbook[$errmsg])) {
+							$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
 						} else {
-							//* Check content with regex, if we use php < 5.2
-							$ip_ok = 0;
-							if(preg_match("/^(\:\:([a-f0-9]{1,4}\:){0,6}?[a-f0-9]{0,4}|[a-f0-9]{1,4}(\:[a-f0-9]{1,4}){0,6}?\:\:|[a-f0-9]{1,4}(\:[a-f0-9]{1,4}){1,6}?\:\:([a-f0-9]{1,4}\:){1,6}?[a-f0-9]{1,4})(\/\d{1,3})?$/i", $field_value)){
-								$ip_ok = 1;
-							}
-							if(preg_match("/^[0-9]{1,3}(\.)[0-9]{1,3}(\.)[0-9]{1,3}(\.)[0-9]{1,3}$/", $field_value)){
-								$ip_ok = 1;
-							}
-							if($ip_ok == 0) {
-								$errmsg = $validator['errmsg'];
-								if(isset($this->wordbook[$errmsg])) {
-									$this->errorMessage .= $this->wordbook[$errmsg]."<br />\r\n";
-								} else {
-									$this->errorMessage .= $errmsg."<br />\r\n";
-								}
-							}
+							$this->errorMessage .= $errmsg."<br />\r\n";
 						}
 					}
 				}
 				break;
+			
 			case 'RANGE':
 				//* Checks if the value is within the given range or above / below a value
 				//* Range examples: < 10 = ":10", between 2 and 10 = "2:10", above 5 = "5:".

--
Gitblit v1.9.1