From 7fe908c50c8dbc5cc05f571dbe11d66141caacd4 Mon Sep 17 00:00:00 2001 From: Marius Cramer <m.cramer@pixcept.de> Date: Thu, 14 Nov 2013 09:01:22 -0500 Subject: [PATCH] Cleaning up code to match coding guidelines --- server/lib/classes/monitor_tools.inc.php | 519 +++++++++++++++++++++++++++++---------------------------- 1 files changed, 261 insertions(+), 258 deletions(-) diff --git a/server/lib/classes/monitor_tools.inc.php b/server/lib/classes/monitor_tools.inc.php index 0b1caa6..8f00088 100644 --- a/server/lib/classes/monitor_tools.inc.php +++ b/server/lib/classes/monitor_tools.inc.php @@ -55,64 +55,64 @@ $distname = 'Ubuntu'; $distid = 'debian40'; $distbaseid = 'debian'; - $ver = explode(' ',$issue); + $ver = explode(' ', $issue); $ver = array_filter($ver); $ver = next($ver); - $mainver = explode('.',$ver); + $mainver = explode('.', $ver); $mainver = array_filter($mainver); $mainver = current($mainver).'.'.next($mainver); switch ($mainver){ case "12.10": $relname = "(Quantal Quetzal)"; - break; + break; case "12.04": $relname = "(Precise Pangolin)"; - break; + break; case "11.10": $relname = "(Oneiric Ocelot)"; - break; + break; case "11.14": $relname = "(Natty Narwhal)"; - break; + break; case "10.10": $relname = "(Maverick Meerkat)"; - break; + break; case "10.04": $relname = "(Lucid Lynx)"; - break; + break; case "9.10": $relname = "(Karmic Koala)"; - break; + break; case "9.04": $relname = "(Jaunty Jackpole)"; - break; + break; case "8.10": - $relname = "(Intrepid Ibex)"; - break; + $relname = "(Intrepid Ibex)"; + break; case "8.04": $relname = "(Hardy Heron)"; - break; + break; case "7.10": $relname = "(Gutsy Gibbon)"; - break; + break; case "7.04": $relname = "(Feisty Fawn)"; - break; + break; case "6.10": $relname = "(Edgy Eft)"; - break; + break; case "6.06": $relname = "(Dapper Drake)"; - break; + break; case "5.10": $relname = "(Breezy Badger)"; - break; + break; case "5.04": $relname = "(Hoary Hedgehog)"; - break; + break; case "4.10": $relname = "(Warty Warthog)"; - break; + break; default: $relname = "UNKNOWN"; } @@ -226,9 +226,9 @@ return array('name' => $distname, 'version' => $distver, 'id' => $distid, 'baseid' => $distbaseid); } - //** Email Quota - public function monitorEmailQuota() { - global $conf, $app; + //** Email Quota + public function monitorEmailQuota() { + global $conf, $app; //* Initialize data array $data = array(); @@ -246,15 +246,15 @@ if(is_array($mailboxes)) { foreach($mailboxes as $mb) { $email = $mb['email']; - $email_parts = explode('@',$mb['email']); + $email_parts = explode('@', $mb['email']); $filename = $mb['maildir'].'/.quotausage'; if(file_exists($filename) && !is_link($filename)) { $quotafile = file($filename); $data[$email]['used'] = trim($quotafile['1']); unset($quotafile); } else { - exec('du -s '.escapeshellcmd($mb['maildir']),$out); - $parts = explode(' ',$out[0]); + exec('du -s '.escapeshellcmd($mb['maildir']), $out); + $parts = explode(' ', $out[0]); $data[$email]['used'] = intval($parts[0])*1024; unset($out); unset($parts); @@ -264,7 +264,7 @@ unset($mailboxes); - //* Dovecot quota check Courier in progress lathama@gmail.com + //* Dovecot quota check Courier in progress lathama@gmail.com /* if($dir = opendir("/var/vmail")){ while (($quotafiles = readdir($dir)) !== false){ @@ -282,10 +282,10 @@ $res['type'] = $type; $res['data'] = $data; $res['state'] = $state; - return $res; - } + return $res; + } - //** Filesystem Quota + //** Filesystem Quota public function monitorHDQuota() { global $conf; @@ -370,6 +370,8 @@ $server_id = intval($conf['server_id']); /** The type of the data */ + + $type = 'server_load'; /* @@ -473,7 +475,7 @@ } public function monitorDiskUsage() { - global $app,$conf; + global $app, $conf; /* the id of the server as int */ $server_id = intval($conf['server_id']); @@ -487,8 +489,8 @@ /** Fetch the data of ALL devices into a array (needed for monitoring!) */ //$dfData = shell_exec('df -hT 2>/dev/null'); $app->uses('getconf'); - $web_config = $app->getconf->get_server_config($conf['server_id'], 'web'); - $dfData = shell_exec('df -hT|grep -v "'.$web_config['website_basedir'].'/" 2>/dev/null'); + $web_config = $app->getconf->get_server_config($conf['server_id'], 'web'); + $dfData = shell_exec('df -hT|grep -v "'.$web_config['website_basedir'].'/" 2>/dev/null'); // split into array $df = explode("\n", $dfData); @@ -515,9 +517,9 @@ $usePercent = floatval($data[$i]['percent']); //* get the free memsize - if(substr($data[$i]['available'],-1) == 'G') { + if(substr($data[$i]['available'], -1) == 'G') { $freesize = floatval($data[$i]['available'])*1024; - } elseif(substr($data[$i]['available'],-1) == 'T') { + } elseif(substr($data[$i]['available'], -1) == 'T') { $freesize = floatval($data[$i]['available'])*1024*1024; } else { $freesize = floatval($data[$i]['available']); @@ -525,23 +527,23 @@ //* We don't want to check some filesystem which have no sensible filling levels switch ($data[$i]['type']) { - case 'iso9660': - case 'cramfs': - case 'udf': - case 'tmpfs': - case 'devtmpfs': - case 'udev': - break; - default: - if ($usePercent > 75 && $freesize < 2000) - $state = $this->_setState($state, 'info'); - if ($usePercent > 80 && $freesize < 1000) - $state = $this->_setState($state, 'warning'); - if ($usePercent > 90 && $freesize < 500) - $state = $this->_setState($state, 'critical'); - if ($usePercent > 95 && $freesize < 100) - $state = $this->_setState($state, 'error'); - break; + case 'iso9660': + case 'cramfs': + case 'udf': + case 'tmpfs': + case 'devtmpfs': + case 'udev': + break; + default: + if ($usePercent > 75 && $freesize < 2000) + $state = $this->_setState($state, 'info'); + if ($usePercent > 80 && $freesize < 1000) + $state = $this->_setState($state, 'warning'); + if ($usePercent > 90 && $freesize < 500) + $state = $this->_setState($state, 'critical'); + if ($usePercent > 95 && $freesize < 100) + $state = $this->_setState($state, 'error'); + break; } } } @@ -1152,49 +1154,49 @@ $state = 'ok'; if(is_array($data['output'])) { - foreach ($data['output'] as $item) { - if (strpos($item, 'RAID') !== false) { - if (strpos($item, ' VERIFYING ') !== false) { - $this->_setState($state, 'info'); - } - else if (strpos($item, ' MIGRATE-PAUSED ') !== false) { - $this->_setState($state, 'info'); - } - else if (strpos($item, ' MIGRATING ') !== false) { - $this->_setState($state, 'ok'); - } - else if (strpos($item, ' INITIALIZING ') !== false) { - $this->_setState($state, 'info'); - } - else if (strpos($item, ' INIT-PAUSED ') !== false) { - $this->_setState($state, 'info'); - } - else if (strpos($item, ' REBUILDING ') !== false) { - $this->_setState($state, 'info'); - } - else if (strpos($item, ' REBUILD-PAUSED ') !== false) { - $this->_setState($state, 'warning'); - } - else if (strpos($item, ' RECOVERY ') !== false) { - $this->_setState($state, 'warning'); - } - else if (strpos($item, ' DEGRADED ') !== false) { - $this->_setState($state, 'critical'); - } - else if (strpos($item, ' UNKNOWN ') !== false) { - $this->_setState($state, 'critical'); - } - else if (strpos($item, ' OK ') !== false) { - $this->_setState($state, 'ok'); - } - else if (strpos($item, ' OPTIMAL ') !== false) { - $this->_setState($state, 'ok'); - } - else { - $this->_setState($state, 'critical'); + foreach ($data['output'] as $item) { + if (strpos($item, 'RAID') !== false) { + if (strpos($item, ' VERIFYING ') !== false) { + $this->_setState($state, 'info'); + } + else if (strpos($item, ' MIGRATE-PAUSED ') !== false) { + $this->_setState($state, 'info'); + } + else if (strpos($item, ' MIGRATING ') !== false) { + $this->_setState($state, 'ok'); + } + else if (strpos($item, ' INITIALIZING ') !== false) { + $this->_setState($state, 'info'); + } + else if (strpos($item, ' INIT-PAUSED ') !== false) { + $this->_setState($state, 'info'); + } + else if (strpos($item, ' REBUILDING ') !== false) { + $this->_setState($state, 'info'); + } + else if (strpos($item, ' REBUILD-PAUSED ') !== false) { + $this->_setState($state, 'warning'); + } + else if (strpos($item, ' RECOVERY ') !== false) { + $this->_setState($state, 'warning'); + } + else if (strpos($item, ' DEGRADED ') !== false) { + $this->_setState($state, 'critical'); + } + else if (strpos($item, ' UNKNOWN ') !== false) { + $this->_setState($state, 'critical'); + } + else if (strpos($item, ' OK ') !== false) { + $this->_setState($state, 'ok'); + } + else if (strpos($item, ' OPTIMAL ') !== false) { + $this->_setState($state, 'ok'); + } + else { + $this->_setState($state, 'critical'); + } } } - } } } @@ -1300,54 +1302,54 @@ } public function monitorIPTables() { - global $conf; + global $conf; - /* the id of the server as int */ - $server_id = intval($conf['server_id']); + /* the id of the server as int */ + $server_id = intval($conf['server_id']); - /** The type of the data */ - $type = 'iptables_rules'; + /** The type of the data */ + $type = 'iptables_rules'; - /* This monitoring is only available if fail2ban is installed */ - system('which iptables', $retval); // Debian, Ubuntu, Fedora - if ($retval === 0) { - /* Get the data of the log */ - $data['output'] = '<h2>iptables -S (ipv4)</h2>'.shell_exec('iptables -S 2>/dev/null'); + /* This monitoring is only available if fail2ban is installed */ + system('which iptables', $retval); // Debian, Ubuntu, Fedora + if ($retval === 0) { + /* Get the data of the log */ + $data['output'] = '<h2>iptables -S (ipv4)</h2>'.shell_exec('iptables -S 2>/dev/null'); - /* + /* * At this moment, there is no state (maybe later) */ - $state = 'no_state'; - } else { - $state = 'no_state'; - $data = ''; - } + $state = 'no_state'; + } else { + $state = 'no_state'; + $data = ''; + } - /* This monitoring is only available if fail2ban is installed */ - system('which ip6tables', $retval); // Debian, Ubuntu, Fedora - if ($retval === 0) { - /* Get the data of the log */ - $data['output'] .= '<br><h2>ip6tables -S (ipv6)</h2>'.shell_exec('ip6tables -S 2>/dev/null'); + /* This monitoring is only available if fail2ban is installed */ + system('which ip6tables', $retval); // Debian, Ubuntu, Fedora + if ($retval === 0) { + /* Get the data of the log */ + $data['output'] .= '<br><h2>ip6tables -S (ipv6)</h2>'.shell_exec('ip6tables -S 2>/dev/null'); - /* + /* * At this moment, there is no state (maybe later) */ - $state = 'no_state'; - } else { - $state = 'no_state'; - $data = ''; - } + $state = 'no_state'; + } else { + $state = 'no_state'; + $data = ''; + } - /* + /* * Return the Result */ - $res['server_id'] = $server_id; - $res['type'] = $type; - $res['data'] = $data; - $res['state'] = $state; - return $res; - } + $res['server_id'] = $server_id; + $res['type'] = $type; + $res['data'] = $data; + $res['state'] = $state; + return $res; + } public function monitorSysLog() { global $app; @@ -1657,108 +1659,108 @@ } switch ($log) { - case 'log_mail': - if ($dist == 'debian') { - $logfile = '/var/log/mail.log'; - } elseif ($dist == 'redhat') { - $logfile = '/var/log/maillog'; - } elseif ($dist == 'suse') { - $logfile = '/var/log/mail.info'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/maillog'; - } - break; - case 'log_mail_warn': - if ($dist == 'debian') { - $logfile = '/var/log/mail.warn'; - } elseif ($dist == 'redhat') { - $logfile = '/var/log/maillog'; - } elseif ($dist == 'suse') { - $logfile = '/var/log/mail.warn'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/maillog'; - } - break; - case 'log_mail_err': - if ($dist == 'debian') { - $logfile = '/var/log/mail.err'; - } elseif ($dist == 'redhat') { - $logfile = '/var/log/maillog'; - } elseif ($dist == 'suse') { - $logfile = '/var/log/mail.err'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/maillog'; - } - break; - case 'log_messages': - if ($dist == 'debian') { - $logfile = '/var/log/syslog'; - } elseif ($dist == 'redhat') { - $logfile = '/var/log/messages'; - } elseif ($dist == 'suse') { - $logfile = '/var/log/messages'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/messages'; - } - break; - case 'log_ispc_cron': - if ($dist == 'debian') { - $logfile = $conf['ispconfig_log_dir'] . '/cron.log'; - } elseif ($dist == 'redhat') { - $logfile = $conf['ispconfig_log_dir'] . '/cron.log'; - } elseif ($dist == 'suse') { - $logfile = $conf['ispconfig_log_dir'] . '/cron.log'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/cron'; - } - break; - case 'log_freshclam': - if ($dist == 'debian') { - $logfile = '/var/log/clamav/freshclam.log'; - } elseif ($dist == 'redhat') { - $logfile = (is_file('/var/log/clamav/freshclam.log') ? '/var/log/clamav/freshclam.log' : '/var/log/freshclam.log'); - } elseif ($dist == 'suse') { - $logfile = '/var/log/freshclam.log'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/clamav/freshclam.log'; - } - break; - case 'log_clamav': - if ($dist == 'debian') { - $logfile = '/var/log/clamav/clamav.log'; - } elseif ($dist == 'redhat') { - $logfile = (is_file('/var/log/clamav/clamd.log') ? '/var/log/clamav/clamd.log' : '/var/log/maillog'); - } elseif ($dist == 'suse') { - $logfile = '/var/log/clamd.log'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/clamav/clamd.log'; - } - break; - case 'log_fail2ban': - if ($dist == 'debian') { - $logfile = '/var/log/fail2ban.log'; - } elseif ($dist == 'redhat') { - $logfile = '/var/log/fail2ban.log'; - } elseif ($dist == 'suse') { - $logfile = '/var/log/fail2ban.log'; - } elseif ($dist == 'gentoo') { - $logfile = '/var/log/fail2ban.log'; - } - break; - case 'log_ispconfig': - if ($dist == 'debian') { - $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; - } elseif ($dist == 'redhat') { - $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; - } elseif ($dist == 'suse') { - $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; - } elseif ($dist == 'gentoo') { - $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; - } - break; - default: - $logfile = ''; - break; + case 'log_mail': + if ($dist == 'debian') { + $logfile = '/var/log/mail.log'; + } elseif ($dist == 'redhat') { + $logfile = '/var/log/maillog'; + } elseif ($dist == 'suse') { + $logfile = '/var/log/mail.info'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/maillog'; + } + break; + case 'log_mail_warn': + if ($dist == 'debian') { + $logfile = '/var/log/mail.warn'; + } elseif ($dist == 'redhat') { + $logfile = '/var/log/maillog'; + } elseif ($dist == 'suse') { + $logfile = '/var/log/mail.warn'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/maillog'; + } + break; + case 'log_mail_err': + if ($dist == 'debian') { + $logfile = '/var/log/mail.err'; + } elseif ($dist == 'redhat') { + $logfile = '/var/log/maillog'; + } elseif ($dist == 'suse') { + $logfile = '/var/log/mail.err'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/maillog'; + } + break; + case 'log_messages': + if ($dist == 'debian') { + $logfile = '/var/log/syslog'; + } elseif ($dist == 'redhat') { + $logfile = '/var/log/messages'; + } elseif ($dist == 'suse') { + $logfile = '/var/log/messages'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/messages'; + } + break; + case 'log_ispc_cron': + if ($dist == 'debian') { + $logfile = $conf['ispconfig_log_dir'] . '/cron.log'; + } elseif ($dist == 'redhat') { + $logfile = $conf['ispconfig_log_dir'] . '/cron.log'; + } elseif ($dist == 'suse') { + $logfile = $conf['ispconfig_log_dir'] . '/cron.log'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/cron'; + } + break; + case 'log_freshclam': + if ($dist == 'debian') { + $logfile = '/var/log/clamav/freshclam.log'; + } elseif ($dist == 'redhat') { + $logfile = (is_file('/var/log/clamav/freshclam.log') ? '/var/log/clamav/freshclam.log' : '/var/log/freshclam.log'); + } elseif ($dist == 'suse') { + $logfile = '/var/log/freshclam.log'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/clamav/freshclam.log'; + } + break; + case 'log_clamav': + if ($dist == 'debian') { + $logfile = '/var/log/clamav/clamav.log'; + } elseif ($dist == 'redhat') { + $logfile = (is_file('/var/log/clamav/clamd.log') ? '/var/log/clamav/clamd.log' : '/var/log/maillog'); + } elseif ($dist == 'suse') { + $logfile = '/var/log/clamd.log'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/clamav/clamd.log'; + } + break; + case 'log_fail2ban': + if ($dist == 'debian') { + $logfile = '/var/log/fail2ban.log'; + } elseif ($dist == 'redhat') { + $logfile = '/var/log/fail2ban.log'; + } elseif ($dist == 'suse') { + $logfile = '/var/log/fail2ban.log'; + } elseif ($dist == 'gentoo') { + $logfile = '/var/log/fail2ban.log'; + } + break; + case 'log_ispconfig': + if ($dist == 'debian') { + $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; + } elseif ($dist == 'redhat') { + $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; + } elseif ($dist == 'suse') { + $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; + } elseif ($dist == 'gentoo') { + $logfile = $conf['ispconfig_log_dir'] . '/ispconfig.log'; + } + break; + default: + $logfile = ''; + break; } // Getting the logfile content @@ -1865,39 +1867,39 @@ * Calculate the weight of the old state */ switch ($oldState) { - case 'no_state': $oldInt = 0; - break; - case 'ok': $oldInt = 1; - break; - case 'unknown': $oldInt = 2; - break; - case 'info': $oldInt = 3; - break; - case 'warning': $oldInt = 4; - break; - case 'critical': $oldInt = 5; - break; - case 'error': $oldInt = 6; - break; + case 'no_state': $oldInt = 0; + break; + case 'ok': $oldInt = 1; + break; + case 'unknown': $oldInt = 2; + break; + case 'info': $oldInt = 3; + break; + case 'warning': $oldInt = 4; + break; + case 'critical': $oldInt = 5; + break; + case 'error': $oldInt = 6; + break; } /* * Calculate the weight of the new state */ switch ($newState) { - case 'no_state': $newInt = 0; - break; - case 'ok': $newInt = 1; - break; - case 'unknown': $newInt = 2; - break; - case 'info': $newInt = 3; - break; - case 'warning': $newInt = 4; - break; - case 'critical': $newInt = 5; - break; - case 'error': $newInt = 6; - break; + case 'no_state': $newInt = 0; + break; + case 'ok': $newInt = 1; + break; + case 'unknown': $newInt = 2; + break; + case 'info': $newInt = 3; + break; + case 'warning': $newInt = 4; + break; + case 'critical': $newInt = 5; + break; + case 'error': $newInt = 6; + break; } /* @@ -1911,6 +1913,7 @@ } private function _getIntArray($line) { + /** The array of float found */ $res = array(); /* First build a array from the line */ @@ -1926,4 +1929,4 @@ } -?> \ No newline at end of file +?> -- Gitblit v1.9.1